Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66404/?format=api
{ "id": 66404, "url": "http://patches.dpdk.org/api/patches/66404/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200309093243.63204-6-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200309093243.63204-6-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200309093243.63204-6-huwei013@chinasoftinc.com", "date": "2020-03-09T09:32:43", "name": "[v2,5/5] net/hns3: fix promiscuous mode for PF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2f8d8ccc72071f4419e40fd71bd503bdb851471f", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200309093243.63204-6-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 8836, "url": "http://patches.dpdk.org/api/series/8836/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8836", "date": "2020-03-09T09:32:39", "name": "misc updates and fixes for hns3 PMD driver", "version": 2, "mbox": "http://patches.dpdk.org/series/8836/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66404/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66404/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E7DA3A052E;\n\tMon, 9 Mar 2020 10:34:28 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C6DC51C0C4;\n\tMon, 9 Mar 2020 10:33:30 +0100 (CET)", "from incedge.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 9E4191C021\n for <dev@dpdk.org>; Mon, 9 Mar 2020 10:33:23 +0100 (CET)", "from mail.chinasoftinc.com (inccas001.ito.icss [10.168.0.51]) by\n incedge.chinasoftinc.com with ESMTP id 6yQph95g9umiSDWV (version=TLSv1\n cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO) for <dev@dpdk.org>;\n Mon, 09 Mar 2020 17:32:51 +0800 (CST)", "from localhost.localdomain (114.119.4.74) by INCCAS001.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Mon, 9 Mar 2020\n 17:32:50 +0800" ], "X-ASG-Debug-ID": "1583746368-0a3dd1404a03530006-TfluYd", "X-Barracuda-Envelope-From": "huwei013@chinasoftinc.com", "X-Barracuda-RBL-Trusted-Forwarder": [ "10.168.0.51", "10.168.0.60" ], "X-ASG-Whitelist": "Client", "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "Date": "Mon, 9 Mar 2020 17:32:43 +0800", "X-ASG-Orig-Subj": "[PATCH v2 5/5] net/hns3: fix promiscuous mode for PF", "Message-ID": "<20200309093243.63204-6-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20200309093243.63204-1-huwei013@chinasoftinc.com>", "References": "<20200309093243.63204-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[114.119.4.74]", "X-Barracuda-Connect": "inccas001.ito.icss[10.168.0.51]", "X-Barracuda-Start-Time": "1583746370", "X-Barracuda-Encrypted": "ECDHE-RSA-AES256-SHA", "X-Barracuda-URL": "https://incspam.chinasofti.com:443/cgi-mod/mark.cgi", "X-Virus-Scanned": "by bsmtpd at chinasoftinc.com", "X-Barracuda-Scan-Msg-Size": "4480", "Subject": "[dpdk-dev] [PATCH v2 5/5] net/hns3: fix promiscuous mode for PF", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengchang Tang <tangchengchang@huawei.com>\n\nCurrently, when promiscuous mode is enabled, it is just allowed to accept\nall the unicast and broadcast packets in hns3 PF PMD driver. It should\nalso be able to receive multicast packets.\n\nFixes: 19a3ca4c99cf (\"net/hns3: add start/stop and configure operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengchang Tang <tangchengchang@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 41 ++++++++++++++++++----------------\n 1 file changed, 22 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex f6495623e..58aaed47a 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -3649,7 +3649,7 @@ hns3_cmd_set_promisc_mode(struct hns3_hw *hw, struct hns3_promisc_param *param)\n \n \tret = hns3_cmd_send(hw, &desc, 1);\n \tif (ret)\n-\t\tPMD_INIT_LOG(ERR, \"Set promisc mode fail, status is %d\", ret);\n+\t\tPMD_INIT_LOG(ERR, \"Set promisc mode fail, ret = %d\", ret);\n \n \treturn ret;\n }\n@@ -3702,14 +3702,14 @@ hns3_dev_promiscuous_enable(struct rte_eth_dev *dev)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n-\tbool en_mc_pmc = (dev->data->all_multicast == 1) ? true : false;\n \tint ret;\n \n \trte_spinlock_lock(&hw->lock);\n-\tret = hns3_set_promisc_mode(hw, true, en_mc_pmc);\n+\tret = hns3_set_promisc_mode(hw, true, true);\n \trte_spinlock_unlock(&hw->lock);\n \tif (ret)\n-\t\thns3_err(hw, \"Failed to enable promiscuous mode: %d\", ret);\n+\t\thns3_err(hw, \"Failed to enable promiscuous mode, ret = %d\",\n+\t\t\t ret);\n \n \treturn ret;\n }\n@@ -3717,17 +3717,18 @@ hns3_dev_promiscuous_enable(struct rte_eth_dev *dev)\n static int\n hns3_dev_promiscuous_disable(struct rte_eth_dev *dev)\n {\n+\tbool allmulti = dev->data->all_multicast ? true : false;\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n-\tbool en_mc_pmc = (dev->data->all_multicast == 1) ? true : false;\n \tint ret;\n \n \t/* If now in all_multicast mode, must remain in all_multicast mode. */\n \trte_spinlock_lock(&hw->lock);\n-\tret = hns3_set_promisc_mode(hw, false, en_mc_pmc);\n+\tret = hns3_set_promisc_mode(hw, false, allmulti);\n \trte_spinlock_unlock(&hw->lock);\n \tif (ret)\n-\t\thns3_err(hw, \"Failed to disable promiscuous mode: %d\", ret);\n+\t\thns3_err(hw, \"Failed to disable promiscuous mode, ret = %d\",\n+\t\t\t ret);\n \n \treturn ret;\n }\n@@ -3737,14 +3738,17 @@ hns3_dev_allmulticast_enable(struct rte_eth_dev *dev)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n-\tbool en_uc_pmc = (dev->data->promiscuous == 1) ? true : false;\n \tint ret;\n \n+\tif (dev->data->promiscuous)\n+\t\treturn 0;\n+\n \trte_spinlock_lock(&hw->lock);\n-\tret = hns3_set_promisc_mode(hw, en_uc_pmc, true);\n+\tret = hns3_set_promisc_mode(hw, false, true);\n \trte_spinlock_unlock(&hw->lock);\n \tif (ret)\n-\t\thns3_err(hw, \"Failed to enable allmulticast mode: %d\", ret);\n+\t\thns3_err(hw, \"Failed to enable allmulticast mode, ret = %d\",\n+\t\t\t ret);\n \n \treturn ret;\n }\n@@ -3754,18 +3758,18 @@ hns3_dev_allmulticast_disable(struct rte_eth_dev *dev)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n-\tbool en_uc_pmc = (dev->data->promiscuous == 1) ? true : false;\n \tint ret;\n \n \t/* If now in promiscuous mode, must remain in all_multicast mode. */\n-\tif (dev->data->promiscuous == 1)\n+\tif (dev->data->promiscuous)\n \t\treturn 0;\n \n \trte_spinlock_lock(&hw->lock);\n-\tret = hns3_set_promisc_mode(hw, en_uc_pmc, false);\n+\tret = hns3_set_promisc_mode(hw, false, false);\n \trte_spinlock_unlock(&hw->lock);\n \tif (ret)\n-\t\thns3_err(hw, \"Failed to disable allmulticast mode: %d\", ret);\n+\t\thns3_err(hw, \"Failed to disable allmulticast mode, ret = %d\",\n+\t\t\t ret);\n \n \treturn ret;\n }\n@@ -3774,13 +3778,12 @@ static int\n hns3_dev_promisc_restore(struct hns3_adapter *hns)\n {\n \tstruct hns3_hw *hw = &hns->hw;\n-\tbool en_mc_pmc;\n-\tbool en_uc_pmc;\n+\tbool allmulti = hw->data->all_multicast ? true : false;\n \n-\ten_uc_pmc = (hw->data->promiscuous == 1) ? true : false;\n-\ten_mc_pmc = (hw->data->all_multicast == 1) ? true : false;\n+\tif (hw->data->promiscuous)\n+\t\treturn hns3_set_promisc_mode(hw, true, true);\n \n-\treturn hns3_set_promisc_mode(hw, en_uc_pmc, en_mc_pmc);\n+\treturn hns3_set_promisc_mode(hw, false, allmulti);\n }\n \n static int\n", "prefixes": [ "v2", "5/5" ] }