Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66375/?format=api
{ "id": 66375, "url": "http://patches.dpdk.org/api/patches/66375/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200309065106.23800-9-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200309065106.23800-9-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200309065106.23800-9-mattias.ronnblom@ericsson.com", "date": "2020-03-09T06:51:06", "name": "[8/8] event/dsw: add port busy cycles xstats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e88c7acbba62d51a56767f769a936d00f807e377", "submitter": { "id": 1077, "url": "http://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200309065106.23800-9-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 8828, "url": "http://patches.dpdk.org/api/series/8828/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8828", "date": "2020-03-09T06:51:04", "name": "DSW performance and statistics improvements", "version": 1, "mbox": "http://patches.dpdk.org/series/8828/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66375/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66375/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C8E20A052E;\n\tMon, 9 Mar 2020 07:52:53 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EE9D01C044;\n\tMon, 9 Mar 2020 07:51:58 +0100 (CET)", "from EUR02-VE1-obe.outbound.protection.outlook.com\n (mail-eopbgr20066.outbound.protection.outlook.com [40.107.2.66])\n by dpdk.org (Postfix) with ESMTP id BA06F1BFFB\n for <dev@dpdk.org>; Mon, 9 Mar 2020 07:51:47 +0100 (CET)", "from AM6P195CA0002.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::15)\n by AM0PR07MB5603.eurprd07.prod.outlook.com (2603:10a6:208:100::17) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.5; Mon, 9 Mar\n 2020 06:51:45 +0000", "from VE1EUR02FT021.eop-EUR02.prod.protection.outlook.com\n (2603:10a6:209:81:cafe::14) by AM6P195CA0002.outlook.office365.com\n (2603:10a6:209:81::15) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.15 via Frontend\n Transport; Mon, 9 Mar 2020 06:51:45 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n VE1EUR02FT021.mail.protection.outlook.com (10.152.12.111) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id\n 15.20.2793.11 via Frontend Transport; Mon, 9 Mar 2020 06:51:45 +0000", "from ESESSMB503.ericsson.se (153.88.183.164) by\n ESESBMR505.ericsson.se (153.88.183.201) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.1713.5; Mon, 9 Mar 2020 07:51:44 +0100", "from ESESSMB501.ericsson.se (153.88.183.162) by\n ESESSMB503.ericsson.se (153.88.183.164) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.1713.5; Mon, 9 Mar 2020 07:51:43 +0100", "from selio1a020.lmera.ericsson.se (153.88.183.153) by\n smtp.internal.ericsson.com (153.88.183.189) with Microsoft SMTP Server id\n 15.1.1713.5 via Frontend Transport; Mon, 9 Mar 2020 07:51:43 +0100", "from breslau.lmera.ericsson.se (breslau.lmera.ericsson.se\n [150.132.109.241])\n by selio1a020.lmera.ericsson.se (8.15.1+Sun/8.15.1) with ESMTP id\n 0296pgIS024126; Mon, 9 Mar 2020 07:51:44 +0100 (CET)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=M59Ms7q0dNG9GCQGocM/58dLtGKPPQWDa1/8fkJklY9KymuLF8W4jzBinh3OJYrBWwft4dPxiMIHxwxeBFas/KUwzuJcox+O+bMcnPEk5O1+WAAMcBVQHMqQJQnlvKotDTYfKUe+X0QJZkpAYyuU76ZgG80kuuPapVZSGoBci1zj1yK8r3gRe+ImcqxIFxCocqSi4DYLF/MEAedqL1enuDOzrZ9AmH9ifdsjtTM9Ev5vI/bq2+GDb9phIrX9+ksv5NwsxRj2qpOlkkMTvgGQ0sPSWnhZCnieDIp3YFCe6u4vC48cfZShHFn+xn2uKnUBLAlKQxmVfH4PhLT9b2A1qA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=N1CBtpf0tfHF9UhxJu/7kZa6F9qQkQaWr93qjIPCTGg=;\n b=GzA1zbs8LULzGQC8sP1RxFjjBJoRN3rUI9Wvs44UiMatLuSqFEFWE9XChZEoF8KBKVDgPFN2bpOHwJJMMwd5ieAhr83Q2Vr9L5TPxK/g1kxhmqCttsvHQFyhlDvhY2+hF4fWYRoc26zBdI2JjhRMbnZxr2v/H/OqY/oT9EUorKGHluFdWcLoludzyEDlQpI3e1gl1n1YvzalbYkhwEUg3BcRIiqCH3g3cI0GvLNqDSrENpVCoaAsrvb7FYnq3AFxNOzESsSM7UUchythryUZvAzucovaZUtCBC2SWaxEQ06H+N5nhfZZcTZCkr3ucW5n6/TOvAZIvCFvEayJxIEjRg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=arm.com smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=none pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=N1CBtpf0tfHF9UhxJu/7kZa6F9qQkQaWr93qjIPCTGg=;\n b=A3/vEelIEe467fFq9l1kM3iaN//WJagZu+z8Z1hsWtm+bd/96zXQolaJjb3YWSNH4G7l0EEKI7a3aIms8MDcUDB6KzATqP2sg3FX5Da2Ec2L0imNngFQ+BsOCugW3kB8a0qfCdyAIjiK0m6Kt74WPi1UzIJ41QbTsX3kUt7iP2M=", "Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; arm.com; dkim=none (message not signed)\n header.d=none;arm.com; dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com;", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<jerinj@marvell.com>", "CC": "<dev@dpdk.org>, <stefan.sundkvist@ericsson.com>, <Ola.Liljedahl@arm.com>,\n\t=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "Date": "Mon, 9 Mar 2020 07:51:06 +0100", "Message-ID": "<20200309065106.23800-9-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200309065106.23800-1-mattias.ronnblom@ericsson.com>", "References": "<20200309065106.23800-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; IPV:; CTRY:SE; EFV:NLI;\n SFV:NSPM;\n SFS:(10009020)(4636009)(136003)(346002)(39860400002)(376002)(396003)(199004)(189003)(54906003)(8676002)(4326008)(26005)(478600001)(1076003)(316002)(66574012)(246002)(336012)(107886003)(7636002)(186003)(956004)(6916009)(6666004)(356004)(5660300002)(70586007)(70206006)(86362001)(8936002)(36756003)(2906002)(2616005);\n DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR07MB5603; H:oa.msg.ericsson.com; FPR:;\n SPF:Pass; LANG:en; PTR:office365.se.ericsson.net; A:1; MX:1;", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "0e879517-b452-4738-773c-08d7c3f654f4", "X-MS-TrafficTypeDiagnostic": "AM0PR07MB5603:", "X-Microsoft-Antispam-PRVS": "\n <AM0PR07MB5603E40344211770C93A30FCE1FE0@AM0PR07MB5603.eurprd07.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:4714;", "X-Forefront-PRVS": "0337AFFE9A", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n JpL6y4vGHD2g+glEaanufsIdG+VLs78shzlTiYJ4bkQxZ1ADXG9rIkFCWpiwIe8d00YdX1j/2yzIorCUPRQTUV9rn3Ni6X6REY5vH1EWc3qrNa1/9k4aqcVsr6xCJ9KdfIvtC6psjBe2EME4IjPMebp30EZ2wBk7lF8ERNW8CTkpLqyAX4UBNB6YhYX85NnJGZLFEBJL5RA/6HDUpW6QI8bRRZeDpCSt2VbmeTxqn4PSN+zjGYtPyHVkZiehQdKYRUuy3Gkzqt6gTDsvFCY5XxstNpHzAcFSk9a+IVvb3J3D8A4f9tCpFWzECwplNWhaC+ddNhmCfy6sBpZa52RftfwOmcu7UIFxrCH4swD/xBtHMNOOcFRy6SkU2U7x7SyRcSnk0MTLfkSmUyQiPF/4GeW9D/6z4oNV5Yeso/Fw58fiF5VEEqRQ+wgyjni/LWw0", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "09 Mar 2020 06:51:45.0082 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0e879517-b452-4738-773c-08d7c3f654f4", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR07MB5603", "Subject": "[dpdk-dev] [PATCH 8/8] event/dsw: add port busy cycles xstats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "DSW keeps an internal port load estimate, used by the load balancing\nmechanism. As a side effect, it keeps track of the total number of\nbusy cycles since startup. This metric is indirectly exposed in the\nform of DSW xstats' \"port_<n>_event_proc_latency\", which is the total\nnumber of busy cycles divided by the total number of events processed\non a particular port.\n\nAn external application can take (event_latency * dequeued) to go back\nto busy_cycles. One reason for doing this is to measure the port's\nload during a longer time period, without resorting to sampling\n\"port_<n>_load\". However, as the number dequeued events grows, a\nrounding error in event_latency renders the application-calculated\nbusy_cycles inaccurate.\n\nThus, it makes sense to directly expose the number of busy cycles as a\nDSW xstats, even though it might seem redundant.\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n drivers/event/dsw/dsw_xstats.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/drivers/event/dsw/dsw_xstats.c b/drivers/event/dsw/dsw_xstats.c\nindex d332a57b6..e8e92183e 100644\n--- a/drivers/event/dsw/dsw_xstats.c\n+++ b/drivers/event/dsw/dsw_xstats.c\n@@ -109,6 +109,13 @@ dsw_xstats_port_get_event_proc_latency(struct dsw_evdev *dsw, uint8_t port_id,\n \treturn dequeued > 0 ? total_busy_cycles / dequeued : 0;\n }\n \n+static uint64_t\n+dsw_xstats_port_get_busy_cycles(struct dsw_evdev *dsw, uint8_t port_id,\n+\t\t\t\tuint8_t queue_id __rte_unused)\n+{\n+\treturn dsw->ports[port_id].total_busy_cycles;\n+}\n+\n DSW_GEN_PORT_ACCESS_FN(inflight_credits)\n \n DSW_GEN_PORT_ACCESS_FN(pending_releases)\n@@ -147,6 +154,8 @@ static struct dsw_xstats_port dsw_port_xstats[] = {\n \t false },\n \t{ \"port_%u_event_proc_latency\", dsw_xstats_port_get_event_proc_latency,\n \t false },\n+\t{ \"port_%u_busy_cycles\", dsw_xstats_port_get_busy_cycles,\n+\t false },\n \t{ \"port_%u_inflight_credits\", dsw_xstats_port_get_inflight_credits,\n \t false },\n \t{ \"port_%u_pending_releases\", dsw_xstats_port_get_pending_releases,\n", "prefixes": [ "8/8" ] }