Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66363/?format=api
{ "id": 66363, "url": "http://patches.dpdk.org/api/patches/66363/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200307132235.210168-2-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200307132235.210168-2-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200307132235.210168-2-xiaolong.ye@intel.com", "date": "2020-03-07T13:22:34", "name": "[v1,1/2] net/virtio: fix for out of date comment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e4de642d4e0e7bf852a8bceec346110cc3147e95", "submitter": { "id": 1120, "url": "http://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200307132235.210168-2-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 8823, "url": "http://patches.dpdk.org/api/series/8823/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8823", "date": "2020-03-07T13:22:33", "name": "small fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/8823/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66363/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66363/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 07EF6A0564;\n\tSat, 7 Mar 2020 14:35:19 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CBCD51BFE6;\n\tSat, 7 Mar 2020 14:35:18 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id 77B211BFE2;\n Sat, 7 Mar 2020 14:35:17 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 07 Mar 2020 05:35:16 -0800", "from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.201])\n by fmsmga001.fm.intel.com with ESMTP; 07 Mar 2020 05:35:15 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,526,1574150400\"; d=\"scan'208\";a=\"352980466\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "maxime.coquelin@redhat.com, Tiwei Bie <tiwei.bie@intel.com>,\n Zhihong Wang <zhihong.wang@intel.com>", "Cc": "dev@dpdk.org,\n\tXiaolong Ye <xiaolong.ye@intel.com>,\n\tstable@dpdk.org", "Date": "Sat, 7 Mar 2020 21:22:34 +0800", "Message-Id": "<20200307132235.210168-2-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200307132235.210168-1-xiaolong.ye@intel.com>", "References": "<20200307132235.210168-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 1/2] net/virtio: fix for out of date comment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix the comment that's incorrect as the code evolves.\n\nFixes: 9470427c88e1 (\"net/virtio: do not store PCI device pointer at shared memory\")\nCc: stable@dpdk.org\n\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex f9d0ea70d..35203940a 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -466,7 +466,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)\n \t}\n \n \tif (!vtpci_packed_queue(hw) && !rte_is_power_of_2(vq_size)) {\n-\t\tPMD_INIT_LOG(ERR, \"split virtqueue size is not powerof 2\");\n+\t\tPMD_INIT_LOG(ERR, \"split virtqueue size is not power of 2\");\n \t\treturn -EINVAL;\n \t}\n \n@@ -588,8 +588,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)\n \t\thw->cvq = cvq;\n \t}\n \n-\t/* For virtio_user case (that is when hw->dev is NULL), we use\n-\t * virtual address. And we need properly set _offset_, please see\n+\t/* For virtio_user case (that is when hw->virtio_user_dev is not NULL),\n+\t * we use virtual address. And we need properly set _offset_, please see\n \t * VIRTIO_MBUF_DATA_DMA_ADDR in virtqueue.h for more information.\n \t */\n \tif (!hw->virtio_user_dev)\n", "prefixes": [ "v1", "1/2" ] }