Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6635/?format=api
http://patches.dpdk.org/api/patches/6635/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1438083563-5668-2-git-send-email-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1438083563-5668-2-git-send-email-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1438083563-5668-2-git-send-email-konstantin.ananyev@intel.com", "date": "2015-07-28T11:39:22", "name": "[dpdk-dev,PATCHv2,1/2] ixgbe: fix scalar scatter RX doesn't take into account CRC length", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "89791d656b473bb59588d3db39e798aa89db8976", "submitter": { "id": 33, "url": "http://patches.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1438083563-5668-2-git-send-email-konstantin.ananyev@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/6635/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/6635/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 113BFC5EC;\n\tTue, 28 Jul 2015 13:40:01 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 3B405C5E4\n\tfor <dev@dpdk.org>; Tue, 28 Jul 2015 13:39:59 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga101.jf.intel.com with ESMTP; 28 Jul 2015 04:39:36 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 28 Jul 2015 04:39:35 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt6SBdZFV016949; Tue, 28 Jul 2015 12:39:35 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t6SBdYb6006075;\n\tTue, 28 Jul 2015 12:39:34 +0100", "(from kananye1@localhost)\n\tby sivswdev02.ir.intel.com with id t6SBdY6s006071;\n\tTue, 28 Jul 2015 12:39:34 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,562,1432623600\"; d=\"scan'208\";a=\"771352815\"", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 28 Jul 2015 12:39:22 +0100", "Message-Id": "<1438083563-5668-2-git-send-email-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1438083563-5668-1-git-send-email-konstantin.ananyev@intel.com>", "References": "<1438076509-11650-2-git-send-email-konstantin.ananyev@intel.com>\n\t<1438083563-5668-1-git-send-email-konstantin.ananyev@intel.com>", "Subject": "[dpdk-dev] [PATCHv2 1/2] ixgbe: fix scalar scatter RX doesn't take\n\tinto account CRC length", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For 2.1 release, in attempt to minimize number of RX routines to support,\nixgbe scatter and ixgbe LRO RX routines were merged into one\nthat can handle both cases.\nThough I completely missed the fact, that while LRO could only be used\nwhen HW CRC strip is enabled, scatter RX should work for both cases\n(HW CRC strip on/off).\nThat patch restores missed functionality.\n\nFixes: 9d8a92628f21 (\"ixgbe: remove simple scalar scattered Rx method\")\n\nv2 changes:\n- updated commit message with 'Fixes'.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++++\n 1 file changed, 19 insertions(+)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex a0c8847..a1b25aa 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -1817,6 +1817,25 @@ next_desc:\n \t\tixgbe_fill_cluster_head_buf(first_seg, &rxd, rxq->port_id,\n \t\t\t\t\t staterr);\n \n+\t\t/*\n+\t\t * Deal with the case, when HW CRC srip is disabled.\n+\t\t * That can't happen when LRO is enabled, but still could\n+\t\t * happen for scattered RX mode.\n+\t\t */\n+\t\tfirst_seg->pkt_len -= rxq->crc_len;\n+\t\tif (unlikely(rxm->data_len <= rxq->crc_len)) {\n+\t\t\tstruct rte_mbuf *lp;\n+\n+\t\t\tfor (lp = first_seg; lp->next != rxm; lp = lp->next)\n+\t\t\t\t;\n+\n+\t\t\tfirst_seg->nb_segs--;\n+\t\t\tlp->data_len -= rxq->crc_len - rxm->data_len;\n+\t\t\tlp->next = NULL;\n+\t\t\trte_pktmbuf_free_seg(rxm);\n+\t\t} else\n+\t\t\trxm->data_len -= rxq->crc_len;\n+\n \t\t/* Prefetch data of first segment, if configured to do so. */\n \t\trte_packet_prefetch((char *)first_seg->buf_addr +\n \t\t\tfirst_seg->data_off);\n", "prefixes": [ "dpdk-dev", "PATCHv2", "1/2" ] }{ "id": 6635, "url": "