Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66334/?format=api
http://patches.dpdk.org/api/patches/66334/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200306095742.18080-16-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200306095742.18080-16-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200306095742.18080-16-hemant.agrawal@nxp.com", "date": "2020-03-06T09:57:41", "name": "[v2,15/16] bus/dpaa: enable set link status", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "646846c3df17eb280b5dae3016ed4f3bd648e623", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200306095742.18080-16-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 8810, "url": "http://patches.dpdk.org/api/series/8810/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8810", "date": "2020-03-06T09:57:26", "name": "NXP DPAAx fixes and enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/8810/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66334/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66334/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4D954A056A;\n\tFri, 6 Mar 2020 11:02:14 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D9B761C0C3;\n\tFri, 6 Mar 2020 11:00:09 +0100 (CET)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by dpdk.org (Postfix) with ESMTP id 1300D1C038\n for <dev@dpdk.org>; Fri, 6 Mar 2020 10:59:57 +0100 (CET)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id C09B71A0A80;\n Fri, 6 Mar 2020 10:59:56 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 6BE931A0AA5;\n Fri, 6 Mar 2020 10:59:54 +0100 (CET)", "from bf-netperf1.ap.com (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id B7BE54029B;\n Fri, 6 Mar 2020 17:59:51 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tRohit Raj <rohit.raj@nxp.com>", "Date": "Fri, 6 Mar 2020 15:27:41 +0530", "Message-Id": "<20200306095742.18080-16-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200306095742.18080-1-hemant.agrawal@nxp.com>", "References": "<20200302145829.27808-1-hemant.agrawal@nxp.com>\n <20200306095742.18080-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 15/16] bus/dpaa: enable set link status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Rohit Raj <rohit.raj@nxp.com>\n\nEnabled set link status API to start/stop phy\ndevice from application.\n\nSigned-off-by: Rohit Raj <rohit.raj@nxp.com>\n---\n drivers/bus/dpaa/base/qbman/process.c | 35 ++++++++++++++++++++---\n drivers/bus/dpaa/include/process.h | 3 ++\n drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 +\n drivers/net/dpaa/dpaa_ethdev.c | 14 +++++++--\n 4 files changed, 47 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/base/qbman/process.c b/drivers/bus/dpaa/base/qbman/process.c\nindex 598b10661..8ab57f105 100644\n--- a/drivers/bus/dpaa/base/qbman/process.c\n+++ b/drivers/bus/dpaa/base/qbman/process.c\n@@ -317,7 +317,7 @@ int rte_dpaa_intr_enable(char *if_name, int efd)\n \n \tret = ioctl(fd, DPAA_IOCTL_ENABLE_LINK_STATUS_INTERRUPT, &args);\n \tif (ret) {\n-\t\tperror(\"Failed to enable interrupt\\n\");\n+\t\tprintf(\"Failed to enable interrupt: Not Supported\\n\");\n \t\treturn ret;\n \t}\n \n@@ -333,7 +333,7 @@ int rte_dpaa_intr_disable(char *if_name)\n \n \tret = ioctl(fd, DPAA_IOCTL_DISABLE_LINK_STATUS_INTERRUPT, &if_name);\n \tif (ret) {\n-\t\tperror(\"Failed to disable interrupt\\n\");\n+\t\tprintf(\"Failed to disable interrupt: Not Supported\\n\");\n \t\treturn ret;\n \t}\n \n@@ -356,9 +356,36 @@ int rte_dpaa_get_link_status(char *if_name)\n \n \tret = ioctl(fd, DPAA_IOCTL_GET_LINK_STATUS, &args);\n \tif (ret) {\n-\t\tperror(\"Failed to get link status\\n\");\n-\t\treturn ret;\n+\t\tprintf(\"Failed to get link status: Not Supported\\n\");\n+\t\treturn -errno;\n \t}\n \n \treturn args.link_status;\n }\n+\n+#define DPAA_IOCTL_UPDATE_LINK_STATUS \\\n+\t_IOW(DPAA_IOCTL_MAGIC, 0x11, struct usdpaa_ioctl_link_status_args)\n+\n+int rte_dpaa_update_link_status(char *if_name, int link_status)\n+{\n+\tstruct usdpaa_ioctl_link_status_args args;\n+\tint ret;\n+\n+\tret = check_fd();\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tstrcpy(args.if_name, if_name);\n+\targs.link_status = link_status;\n+\n+\tret = ioctl(fd, DPAA_IOCTL_UPDATE_LINK_STATUS, &args);\n+\tif (ret) {\n+\t\tif (errno == EINVAL)\n+\t\t\tprintf(\"Failed to set link status: Not Supported\\n\");\n+\t\telse\n+\t\t\tperror(\"Failed to set link status\");\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\ndiff --git a/drivers/bus/dpaa/include/process.h b/drivers/bus/dpaa/include/process.h\nindex 312da1245..9f8c85895 100644\n--- a/drivers/bus/dpaa/include/process.h\n+++ b/drivers/bus/dpaa/include/process.h\n@@ -94,4 +94,7 @@ struct usdpaa_ioctl_link_status_args {\n __rte_experimental\n int rte_dpaa_get_link_status(char *if_name);\n \n+__rte_experimental\n+int rte_dpaa_update_link_status(char *if_name, int link_status);\n+\n #endif\t/* __PROCESS_H */\ndiff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map\nindex bf70e6656..146f29556 100644\n--- a/drivers/bus/dpaa/rte_bus_dpaa_version.map\n+++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map\n@@ -103,4 +103,5 @@ EXPERIMENTAL {\n \trte_dpaa_get_link_status;\n \trte_dpaa_intr_disable;\n \trte_dpaa_intr_enable;\n+\trte_dpaa_update_link_status;\n };\ndiff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex 28c6b1c17..c0a96dd47 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -972,17 +972,27 @@ dpaa_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \n static int dpaa_link_down(struct rte_eth_dev *dev)\n {\n+\tstruct fman_if *fif = dev->process_private;\n+\tstruct __fman_if *__fif;\n+\n \tPMD_INIT_FUNC_TRACE();\n \n-\tdpaa_eth_dev_stop(dev);\n+\t__fif = container_of(fif, struct __fman_if, __if);\n+\n+\trte_dpaa_update_link_status(__fif->node_name, ETH_LINK_DOWN);\n \treturn 0;\n }\n \n static int dpaa_link_up(struct rte_eth_dev *dev)\n {\n+\tstruct fman_if *fif = dev->process_private;\n+\tstruct __fman_if *__fif;\n+\n \tPMD_INIT_FUNC_TRACE();\n \n-\tdpaa_eth_dev_start(dev);\n+\t__fif = container_of(fif, struct __fman_if, __if);\n+\n+\trte_dpaa_update_link_status(__fif->node_name, ETH_LINK_UP);\n \treturn 0;\n }\n \n", "prefixes": [ "v2", "15/16" ] }{ "id": 66334, "url": "