Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66327/?format=api
{ "id": 66327, "url": "http://patches.dpdk.org/api/patches/66327/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200306095742.18080-9-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200306095742.18080-9-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200306095742.18080-9-hemant.agrawal@nxp.com", "date": "2020-03-06T09:57:34", "name": "[v2,08/16] drivers: enhance portal allocation failure log", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3363b2b5f4f9331ea757a60e1420699839de1250", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200306095742.18080-9-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 8810, "url": "http://patches.dpdk.org/api/series/8810/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8810", "date": "2020-03-06T09:57:26", "name": "NXP DPAAx fixes and enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/8810/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66327/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/66327/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE959A056A;\n\tFri, 6 Mar 2020 11:01:04 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2F96D1C066;\n\tFri, 6 Mar 2020 10:59:58 +0100 (CET)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by dpdk.org (Postfix) with ESMTP id F21461C00E\n for <dev@dpdk.org>; Fri, 6 Mar 2020 10:59:50 +0100 (CET)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id D2B821A0A62;\n Fri, 6 Mar 2020 10:59:50 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 818F31A0AA4;\n Fri, 6 Mar 2020 10:59:48 +0100 (CET)", "from bf-netperf1.ap.com (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 44EEA4029B;\n Fri, 6 Mar 2020 17:59:45 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tNipun Gupta <nipun.gupta@nxp.com>", "Date": "Fri, 6 Mar 2020 15:27:34 +0530", "Message-Id": "<20200306095742.18080-9-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200306095742.18080-1-hemant.agrawal@nxp.com>", "References": "<20200302145829.27808-1-hemant.agrawal@nxp.com>\n <20200306095742.18080-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 08/16] drivers: enhance portal allocation\n\tfailure log", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nThe change adds printing the thread id when portal allocation\nfailure occurs\n\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 ++++++--\n drivers/event/dpaa2/dpaa2_eventdev.c | 8 ++++++--\n drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 12 +++++++++---\n drivers/net/dpaa2/dpaa2_ethdev.c | 4 +++-\n drivers/net/dpaa2/dpaa2_rxtx.c | 16 ++++++++++++----\n drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 8 ++++++--\n drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 12 +++++++++---\n 7 files changed, 51 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex 6ed2701ab..cf08003cc 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -1459,7 +1459,9 @@ dpaa2_sec_enqueue_burst(void *qp, struct rte_crypto_op **ops,\n \tif (!DPAA2_PER_LCORE_DPIO) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_SEC_ERR(\"Failure in affining portal\");\n+\t\t\tDPAA2_SEC_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\n@@ -1641,7 +1643,9 @@ dpaa2_sec_dequeue_burst(void *qp, struct rte_crypto_op **ops,\n \tif (!DPAA2_PER_LCORE_DPIO) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_SEC_ERR(\"Failure in affining portal\");\n+\t\t\tDPAA2_SEC_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\ndiff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c\nindex 1833d659d..bb02ea9fb 100644\n--- a/drivers/event/dpaa2/dpaa2_eventdev.c\n+++ b/drivers/event/dpaa2/dpaa2_eventdev.c\n@@ -74,7 +74,9 @@ dpaa2_eventdev_enqueue_burst(void *port, const struct rte_event ev[],\n \t\t/* Affine current thread context to a qman portal */\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret < 0) {\n-\t\t\tDPAA2_EVENTDEV_ERR(\"Failure in affining portal\");\n+\t\t\tDPAA2_EVENTDEV_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\n@@ -273,7 +275,9 @@ dpaa2_eventdev_dequeue_burst(void *port, struct rte_event ev[],\n \t\t/* Affine current thread context to a qman portal */\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret < 0) {\n-\t\t\tDPAA2_EVENTDEV_ERR(\"Failure in affining portal\");\n+\t\t\tDPAA2_EVENTDEV_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\ndiff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\nindex 48887beb7..fa9b53e64 100644\n--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\n+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\n@@ -69,7 +69,9 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp)\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_MEMPOOL_ERR(\"Failure in affining portal\");\n+\t\t\tDPAA2_MEMPOOL_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\tgoto err1;\n \t\t}\n \t}\n@@ -198,7 +200,9 @@ rte_dpaa2_mbuf_release(struct rte_mempool *pool __rte_unused,\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret != 0) {\n-\t\t\tDPAA2_MEMPOOL_ERR(\"Failed to allocate IO portal\");\n+\t\t\tDPAA2_MEMPOOL_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn;\n \t\t}\n \t}\n@@ -317,7 +321,9 @@ rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool,\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret != 0) {\n-\t\t\tDPAA2_MEMPOOL_ERR(\"Failed to allocate IO portal\");\n+\t\t\tDPAA2_MEMPOOL_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn ret;\n \t\t}\n \t}\ndiff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex 4fc550a88..4a61c6f78 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -887,7 +887,9 @@ dpaa2_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_PMD_ERR(\"Failure in affining portal\");\n+\t\t\tDPAA2_PMD_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn -EINVAL;\n \t\t}\n \t}\ndiff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c\nindex 52d913d9e..d809e0f4b 100644\n--- a/drivers/net/dpaa2/dpaa2_rxtx.c\n+++ b/drivers/net/dpaa2/dpaa2_rxtx.c\n@@ -760,7 +760,9 @@ dpaa2_dev_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_PMD_ERR(\"Failure in affining portal\\n\");\n+\t\t\tDPAA2_PMD_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\n@@ -872,7 +874,9 @@ uint16_t dpaa2_dev_tx_conf(void *queue)\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_PMD_ERR(\"Failure in affining portal\\n\");\n+\t\t\tDPAA2_PMD_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\n@@ -1011,7 +1015,9 @@ dpaa2_dev_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_PMD_ERR(\"Failure in affining portal\");\n+\t\t\tDPAA2_PMD_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\n@@ -1272,7 +1278,9 @@ dpaa2_dev_tx_ordered(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_PMD_ERR(\"Failure in affining portal\");\n+\t\t\tDPAA2_PMD_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\ndiff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c\nindex 997d1c873..7c21c6a52 100644\n--- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c\n+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c\n@@ -70,7 +70,9 @@ dpaa2_cmdif_enqueue_bufs(struct rte_rawdev *dev,\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_CMDIF_ERR(\"Failure in affining portal\\n\");\n+\t\t\tDPAA2_CMDIF_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\n@@ -133,7 +135,9 @@ dpaa2_cmdif_dequeue_bufs(struct rte_rawdev *dev,\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_CMDIF_ERR(\"Failure in affining portal\\n\");\n+\t\t\tDPAA2_CMDIF_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\ndiff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\nindex c90595400..d5202d652 100644\n--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\n+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\n@@ -666,7 +666,9 @@ dpdmai_dev_enqueue_multi(struct dpaa2_dpdmai_dev *dpdmai_dev,\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_QDMA_ERR(\"Failure in affining portal\");\n+\t\t\tDPAA2_QDMA_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\n@@ -788,7 +790,9 @@ dpdmai_dev_dequeue_multijob_prefetch(\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_QDMA_ERR(\"Failure in affining portal\");\n+\t\t\tDPAA2_QDMA_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\n@@ -929,7 +933,9 @@ dpdmai_dev_dequeue_multijob_no_prefetch(\n \tif (unlikely(!DPAA2_PER_LCORE_DPIO)) {\n \t\tret = dpaa2_affine_qbman_swp();\n \t\tif (ret) {\n-\t\t\tDPAA2_QDMA_ERR(\"Failure in affining portal\");\n+\t\t\tDPAA2_QDMA_ERR(\n+\t\t\t\t\"Failed to allocate IO portal, tid: %d\\n\",\n+\t\t\t\trte_gettid());\n \t\t\treturn 0;\n \t\t}\n \t}\n", "prefixes": [ "v2", "08/16" ] }