Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66321/?format=api
{ "id": 66321, "url": "http://patches.dpdk.org/api/patches/66321/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200306095742.18080-3-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200306095742.18080-3-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200306095742.18080-3-hemant.agrawal@nxp.com", "date": "2020-03-06T09:57:28", "name": "[v2,02/16] bus/fslmc: fix dereferencing null pointer", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "ea7b9dacea66c9e3baad21c3e762b2d47e91223a", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200306095742.18080-3-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 8810, "url": "http://patches.dpdk.org/api/series/8810/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8810", "date": "2020-03-06T09:57:26", "name": "NXP DPAAx fixes and enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/8810/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66321/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66321/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C7D44A056A;\n\tFri, 6 Mar 2020 11:00:02 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 560CF1C002;\n\tFri, 6 Mar 2020 10:59:48 +0100 (CET)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id 2931F1BFF2;\n Fri, 6 Mar 2020 10:59:46 +0100 (CET)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id A4350200AD2;\n Fri, 6 Mar 2020 10:59:45 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 1EDA9200ADA;\n Fri, 6 Mar 2020 10:59:43 +0100 (CET)", "from bf-netperf1.ap.com (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 4EFC7402D5;\n Fri, 6 Mar 2020 17:59:39 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, stable@dpdk.org,\n Apeksha Gupta <apeksha.gupta@nxp.com>", "Date": "Fri, 6 Mar 2020 15:27:28 +0530", "Message-Id": "<20200306095742.18080-3-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200306095742.18080-1-hemant.agrawal@nxp.com>", "References": "<20200302145829.27808-1-hemant.agrawal@nxp.com>\n <20200306095742.18080-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 02/16] bus/fslmc: fix dereferencing null\n\tpointer", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Apeksha Gupta <apeksha.gupta@nxp.com>\n\nThis patch fixees the nxp internal coverity reported\nnull pointer dereferncing issue.\n\nFixes: 6fef517e17cf (\"bus/fslmc: add qman HW fq query count API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>\n---\n drivers/bus/fslmc/qbman/qbman_debug.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/qbman/qbman_debug.c b/drivers/bus/fslmc/qbman/qbman_debug.c\nindex 0bb2ce880..34374ae4b 100644\n--- a/drivers/bus/fslmc/qbman/qbman_debug.c\n+++ b/drivers/bus/fslmc/qbman/qbman_debug.c\n@@ -20,26 +20,27 @@ struct qbman_fq_query_desc {\n \tuint8_t verb;\n \tuint8_t reserved[3];\n \tuint32_t fqid;\n-\tuint8_t reserved2[57];\n+\tuint8_t reserved2[56];\n };\n \n int qbman_fq_query_state(struct qbman_swp *s, uint32_t fqid,\n \t\t\t struct qbman_fq_query_np_rslt *r)\n {\n \tstruct qbman_fq_query_desc *p;\n+\tstruct qbman_fq_query_np_rslt *var;\n \n \tp = (struct qbman_fq_query_desc *)qbman_swp_mc_start(s);\n \tif (!p)\n \t\treturn -EBUSY;\n \n \tp->fqid = fqid;\n-\t*r = *(struct qbman_fq_query_np_rslt *)qbman_swp_mc_complete(s, p,\n-\t\t\t\t\t\tQBMAN_FQ_QUERY_NP);\n-\tif (!r) {\n+\tvar = qbman_swp_mc_complete(s, p, QBMAN_FQ_QUERY_NP);\n+\tif (!var) {\n \t\tpr_err(\"qbman: Query FQID %d NP fields failed, no response\\n\",\n \t\t fqid);\n \t\treturn -EIO;\n \t}\n+\t*r = *var;\n \n \t/* Decode the outcome */\n \tQBMAN_BUG_ON((r->verb & QBMAN_RESPONSE_VERB_MASK) != QBMAN_FQ_QUERY_NP);\n", "prefixes": [ "v2", "02/16" ] }