Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66314/?format=api
{ "id": 66314, "url": "http://patches.dpdk.org/api/patches/66314/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200306050427.66114-3-gavin.hu@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200306050427.66114-3-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200306050427.66114-3-gavin.hu@arm.com", "date": "2020-03-06T05:04:26", "name": "[v1,2/3] net/i40e: restrict pointer aliasing for neon vec", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "782e758013629e83e18cbb16924e03b1171976a6", "submitter": { "id": 1018, "url": "http://patches.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200306050427.66114-3-gavin.hu@arm.com/mbox/", "series": [ { "id": 8806, "url": "http://patches.dpdk.org/api/series/8806/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8806", "date": "2020-03-06T05:04:24", "name": "i40e vPMD optimization on aarch64", "version": 1, "mbox": "http://patches.dpdk.org/series/8806/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66314/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66314/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 07D54A056A;\n\tFri, 6 Mar 2020 06:05:25 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DF5C11BFF0;\n\tFri, 6 Mar 2020 06:05:12 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id F1AB71BFEE\n for <dev@dpdk.org>; Fri, 6 Mar 2020 06:05:11 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7AA0730E;\n Thu, 5 Mar 2020 21:05:11 -0800 (PST)", "from net-arm-thunderx2-04.shanghai.arm.com\n (net-arm-thunderx2-04.shanghai.arm.com [10.169.40.184])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 90A1F3F6CF;\n Thu, 5 Mar 2020 21:05:08 -0800 (PST)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com, david.marchand@redhat.com, thomas@monjalon.net,\n jerinj@marvell.com, xiaolong.ye@intel.com, Honnappa.Nagarahalli@arm.com,\n ruifeng.wang@arm.com, phil.yang@arm.com, joyce.kong@arm.com,\n steve.capper@arm.com", "Date": "Fri, 6 Mar 2020 13:04:26 +0800", "Message-Id": "<20200306050427.66114-3-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200306050427.66114-1-gavin.hu@arm.com>", "References": "<20200306050427.66114-1-gavin.hu@arm.com>", "Subject": "[dpdk-dev] [PATCH v1 2/3] net/i40e: restrict pointer aliasing for\n\tneon vec", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "restrict pointer aliasing to optimize the code generated.\n\nThe patch showed ~3% performnace uplift on Arm N1SDP platform, and no\ndegradation on ThunderX2. The tet case is RFC2544 zero-loss L2\nforwarding running testpmd.\n\n[1] https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/Restricted-Pointers.html\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Steve Capper <steve.capper@arm.com>\n---\n drivers/net/i40e/i40e_rxtx_vec_neon.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c\nindex 4376d8911..405bd82df 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_neon.c\n+++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c\n@@ -172,8 +172,8 @@ desc_to_olflags_v(struct i40e_rx_queue *rxq, uint64x2_t descs[4],\n #define I40E_UINT16_BIT (CHAR_BIT * sizeof(uint16_t))\n \n static inline void\n-desc_to_ptype_v(uint64x2_t descs[4], struct rte_mbuf **rx_pkts,\n-\t\tuint32_t *ptype_tbl)\n+desc_to_ptype_v(uint64x2_t descs[4], struct rte_mbuf **restrict rx_pkts,\n+\t\tuint32_t *restrict ptype_tbl)\n {\n \tint i;\n \tuint8_t ptype;\n@@ -194,8 +194,8 @@ desc_to_ptype_v(uint64x2_t descs[4], struct rte_mbuf **rx_pkts,\n * numbers of DD bits\n */\n static inline uint16_t\n-_recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n-\t\t uint16_t nb_pkts, uint8_t *split_packet)\n+_recv_raw_pkts_vec(struct i40e_rx_queue *restrict rxq, struct rte_mbuf\n+\t**restrict rx_pkts, uint16_t nb_pkts, uint8_t *split_packet)\n {\n \tvolatile union i40e_rx_desc *rxdp;\n \tstruct i40e_rx_entry *sw_ring;\n@@ -432,7 +432,7 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n * numbers of DD bits\n */\n uint16_t\n-i40e_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n+i40e_recv_pkts_vec(void *restrict rx_queue, struct rte_mbuf **restrict rx_pkts,\n \t\t uint16_t nb_pkts)\n {\n \treturn _recv_raw_pkts_vec(rx_queue, rx_pkts, nb_pkts, NULL);\n@@ -494,8 +494,8 @@ vtx1(volatile struct i40e_tx_desc *txdp,\n }\n \n static inline void\n-vtx(volatile struct i40e_tx_desc *txdp,\n-\t\tstruct rte_mbuf **pkt, uint16_t nb_pkts, uint64_t flags)\n+vtx(volatile struct i40e_tx_desc *txdp, struct rte_mbuf **pkt,\n+\t\tuint16_t nb_pkts, uint64_t flags)\n {\n \tint i;\n \n@@ -504,8 +504,8 @@ vtx(volatile struct i40e_tx_desc *txdp,\n }\n \n uint16_t\n-i40e_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf **tx_pkts,\n-\t\t\t uint16_t nb_pkts)\n+i40e_xmit_fixed_burst_vec(void *restrict tx_queue,\n+\tstruct rte_mbuf **restrict tx_pkts, uint16_t nb_pkts)\n {\n \tstruct i40e_tx_queue *txq = (struct i40e_tx_queue *)tx_queue;\n \tvolatile struct i40e_tx_desc *txdp;\n", "prefixes": [ "v1", "2/3" ] }