Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66313/?format=api
{ "id": 66313, "url": "http://patches.dpdk.org/api/patches/66313/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200306050427.66114-2-gavin.hu@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200306050427.66114-2-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200306050427.66114-2-gavin.hu@arm.com", "date": "2020-03-06T05:04:25", "name": "[v1,1/3] net/i40e: relax barrier in the Tx fastpath of vPMD", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e127b64b655daee77c4e1797adfd10f30ac73f24", "submitter": { "id": 1018, "url": "http://patches.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200306050427.66114-2-gavin.hu@arm.com/mbox/", "series": [ { "id": 8806, "url": "http://patches.dpdk.org/api/series/8806/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8806", "date": "2020-03-06T05:04:24", "name": "i40e vPMD optimization on aarch64", "version": 1, "mbox": "http://patches.dpdk.org/series/8806/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66313/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66313/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2DF6A056A;\n\tFri, 6 Mar 2020 06:05:15 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 63D771BFDB;\n\tFri, 6 Mar 2020 06:05:10 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id A11011BFDA;\n Fri, 6 Mar 2020 06:05:08 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2336430E;\n Thu, 5 Mar 2020 21:05:08 -0800 (PST)", "from net-arm-thunderx2-04.shanghai.arm.com\n (net-arm-thunderx2-04.shanghai.arm.com [10.169.40.184])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 190B33F6CF;\n Thu, 5 Mar 2020 21:05:04 -0800 (PST)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com, david.marchand@redhat.com, thomas@monjalon.net,\n jerinj@marvell.com, xiaolong.ye@intel.com, Honnappa.Nagarahalli@arm.com,\n ruifeng.wang@arm.com, phil.yang@arm.com, joyce.kong@arm.com,\n steve.capper@arm.com, stable@dpdk.org", "Date": "Fri, 6 Mar 2020 13:04:25 +0800", "Message-Id": "<20200306050427.66114-2-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200306050427.66114-1-gavin.hu@arm.com>", "References": "<20200306050427.66114-1-gavin.hu@arm.com>", "Subject": "[dpdk-dev] [PATCH v1 1/3] net/i40e: relax barrier in the Tx\n\tfastpath of vPMD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To keep ordering of mixed accesses, rte_cio is sufficient.\nThe rte_io barrier inside the I40E_PCI_REG_WRITE is overkill.[1]\n\nThis patch fixes by replacing with just sufficient barriers in the\nnormal PMD and vPMD.\n\nIt showed 7% performance uplift on ThunderX2 and 4% on Arm N1SDP.\nThe test case is the RFC2544 zero-loss test running testpmd.\n\n[1] http://inbox.dpdk.org/dev/CALBAE1M-ezVWCjqCZDBw+MMDEC4O9\nqf0Kpn89EMdGDajepKoZQ@mail.gmail.com\n\nFixes: 4861cde46116 (\"i40e: new poll mode driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\n---\n drivers/net/i40e/i40e_rxtx_vec_neon.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c\nindex deb185fe2..4376d8911 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_neon.c\n+++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c\n@@ -72,8 +72,9 @@ i40e_rxq_rearm(struct i40e_rx_queue *rxq)\n \trx_id = (uint16_t)((rxq->rxrearm_start == 0) ?\n \t\t\t (rxq->nb_rx_desc - 1) : (rxq->rxrearm_start - 1));\n \n+\trte_cio_wmb();\n \t/* Update the tail pointer on the NIC */\n-\tI40E_PCI_REG_WRITE(rxq->qrx_tail, rx_id);\n+\tI40E_PCI_REG_WRITE_RELAXED(rxq->qrx_tail, rx_id);\n }\n \n static inline void\n@@ -564,7 +565,8 @@ i40e_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \ttxq->tx_tail = tx_id;\n \n-\tI40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail);\n+\trte_cio_wmb();\n+\tI40E_PCI_REG_WRITE_RELAXED(txq->qtx_tail, tx_id);\n \n \treturn nb_pkts;\n }\n", "prefixes": [ "v1", "1/3" ] }