Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66295/?format=api
{ "id": 66295, "url": "http://patches.dpdk.org/api/patches/66295/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1583405273-14176-5-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1583405273-14176-5-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1583405273-14176-5-git-send-email-arybchenko@solarflare.com", "date": "2020-03-05T10:47:50", "name": "[4/7] net/sfc: introduce flow allocation and free path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0f587e244534ed3428de72b2ea35862315e8e2d6", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1583405273-14176-5-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 8796, "url": "http://patches.dpdk.org/api/series/8796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8796", "date": "2020-03-05T10:47:46", "name": "net/sfc: prepare rte_flow to have one more backend", "version": 1, "mbox": "http://patches.dpdk.org/series/8796/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66295/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66295/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D86D1A0573;\n\tThu, 5 Mar 2020 11:48:51 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A1EAB1C01E;\n\tThu, 5 Mar 2020 11:48:13 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 4903F1BFF1\n for <dev@dpdk.org>; Thu, 5 Mar 2020 11:48:08 +0100 (CET)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 04691800061\n for <dev@dpdk.org>; Thu, 5 Mar 2020 10:48:07 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1395.4; Thu, 5 Mar 2020 10:48:01 +0000", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1395.4 via Frontend Transport; Thu, 5 Mar 2020 10:48:01 +0000", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 025Am1LQ016221;\n Thu, 5 Mar 2020 10:48:01 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 4973F161250;\n Thu, 5 Mar 2020 10:48:01 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Thu, 5 Mar 2020 10:47:50 +0000", "Message-ID": "<1583405273-14176-5-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1583405273-14176-1-git-send-email-arybchenko@solarflare.com>", "References": "<1583405273-14176-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1020-25270.003", "X-TM-AS-Result": "No-2.948200-8.000000-10", "X-TMASE-MatchedRID": "tJBzqNGT4BrIVeuQnVnkwMqlR6dnL7KewZJymmK7rZL5+tteD5RzhVcc\n sLFgYQ2ETgLCpjD2796Pbtzbp+lSUaH2g9syPs88PwKTD1v8YV5MkOX0UoduuVVkJxysad/IYZK\n N7WXQYpTZpnQsEwZkvSlZbcpUYplkNtywwIf5ksWeAiCmPx4NwBnUJ0Ek6yhjxEHRux+uk8hxKp\n vEGAbTDlGlsX220R0mb4OC2UKFfQZM4qIDUDaKB+hCflZZlMpAUI5xulRneMtlxOw0E2wcqlVGR\n k/R/2NS9m+HH7VyXqbG4YbaY/H9uJN1JFeUKeMEiOOUXfTkScBZSbxIRLLN380Goa3UM++8", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.948200-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1020-25270.003", "X-MDID": "1583405287-Ff7A4VNK2RVh", "Subject": "[dpdk-dev] [PATCH 4/7] net/sfc: introduce flow allocation and free\n\tpath", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nRiverhead boards maintain support for MAE, a low-level Match-Action Engine.\nThe upcoming patches will bring support for MAE to RTE flow implementation.\n\nA follow-up patch will introduce MAE-specific specification cleanup method.\nIn order to prepare for the patch, introduce flow allocation and free path.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_flow.c | 49 ++++++++++++++++++++++++++++----------\n 1 file changed, 37 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c\nindex 9be1f9ac8..2ddde6168 100644\n--- a/drivers/net/sfc/sfc_flow.c\n+++ b/drivers/net/sfc/sfc_flow.c\n@@ -2309,6 +2309,27 @@ sfc_flow_parse(struct rte_eth_dev *dev,\n \treturn rc;\n }\n \n+static struct rte_flow *\n+sfc_flow_zmalloc(struct rte_flow_error *error)\n+{\n+\tstruct rte_flow *flow;\n+\n+\tflow = rte_zmalloc(\"sfc_rte_flow\", sizeof(*flow), 0);\n+\tif (flow == NULL) {\n+\t\trte_flow_error_set(error, ENOMEM,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n+\t\t\t\t \"Failed to allocate memory\");\n+\t}\n+\n+\treturn flow;\n+}\n+\n+static void\n+sfc_flow_free(__rte_unused struct sfc_adapter *sa, struct rte_flow *flow)\n+{\n+\trte_free(flow);\n+}\n+\n static int\n sfc_flow_validate(struct rte_eth_dev *dev,\n \t\t const struct rte_flow_attr *attr,\n@@ -2316,11 +2337,19 @@ sfc_flow_validate(struct rte_eth_dev *dev,\n \t\t const struct rte_flow_action actions[],\n \t\t struct rte_flow_error *error)\n {\n-\tstruct rte_flow flow;\n+\tstruct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);\n+\tstruct rte_flow *flow;\n+\tint rc;\n \n-\tmemset(&flow, 0, sizeof(flow));\n+\tflow = sfc_flow_zmalloc(error);\n+\tif (flow == NULL)\n+\t\treturn -rte_errno;\n \n-\treturn sfc_flow_parse(dev, attr, pattern, actions, &flow, error);\n+\trc = sfc_flow_parse(dev, attr, pattern, actions, flow, error);\n+\n+\tsfc_flow_free(sa, flow);\n+\n+\treturn rc;\n }\n \n static struct rte_flow *\n@@ -2334,13 +2363,9 @@ sfc_flow_create(struct rte_eth_dev *dev,\n \tstruct rte_flow *flow = NULL;\n \tint rc;\n \n-\tflow = rte_zmalloc(\"sfc_rte_flow\", sizeof(*flow), 0);\n-\tif (flow == NULL) {\n-\t\trte_flow_error_set(error, ENOMEM,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n-\t\t\t\t \"Failed to allocate memory\");\n+\tflow = sfc_flow_zmalloc(error);\n+\tif (flow == NULL)\n \t\tgoto fail_no_mem;\n-\t}\n \n \trc = sfc_flow_parse(dev, attr, pattern, actions, flow, error);\n \tif (rc != 0)\n@@ -2368,7 +2393,7 @@ sfc_flow_create(struct rte_eth_dev *dev,\n \tTAILQ_REMOVE(&sa->flow_list, flow, entries);\n \n fail_bad_value:\n-\trte_free(flow);\n+\tsfc_flow_free(sa, flow);\n \tsfc_adapter_unlock(sa);\n \n fail_no_mem:\n@@ -2393,7 +2418,7 @@ sfc_flow_remove(struct sfc_adapter *sa,\n \t}\n \n \tTAILQ_REMOVE(&sa->flow_list, flow, entries);\n-\trte_free(flow);\n+\tsfc_flow_free(sa, flow);\n \n \treturn rc;\n }\n@@ -2497,7 +2522,7 @@ sfc_flow_fini(struct sfc_adapter *sa)\n \n \twhile ((flow = TAILQ_FIRST(&sa->flow_list)) != NULL) {\n \t\tTAILQ_REMOVE(&sa->flow_list, flow, entries);\n-\t\trte_free(flow);\n+\t\tsfc_flow_free(sa, flow);\n \t}\n }\n \n", "prefixes": [ "4/7" ] }