Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66293/?format=api
{ "id": 66293, "url": "http://patches.dpdk.org/api/patches/66293/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1583405273-14176-2-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1583405273-14176-2-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1583405273-14176-2-git-send-email-arybchenko@solarflare.com", "date": "2020-03-05T10:47:47", "name": "[1/7] net/sfc: make flow RSS details VNIC-specific", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3bf7b01ebfdf309bfb33789c793bf06dea092a73", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1583405273-14176-2-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 8796, "url": "http://patches.dpdk.org/api/series/8796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8796", "date": "2020-03-05T10:47:46", "name": "net/sfc: prepare rte_flow to have one more backend", "version": 1, "mbox": "http://patches.dpdk.org/series/8796/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66293/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66293/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 209C8A0573;\n\tThu, 5 Mar 2020 11:48:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8FAFA1BFFA;\n\tThu, 5 Mar 2020 11:48:10 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 7BA5D1BFE2\n for <dev@dpdk.org>; Thu, 5 Mar 2020 11:48:07 +0100 (CET)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 25905800056\n for <dev@dpdk.org>; Thu, 5 Mar 2020 10:48:06 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1395.4; Thu, 5 Mar 2020 10:48:00 +0000", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1395.4 via Frontend Transport; Thu, 5 Mar 2020 10:48:00 +0000", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 025Am1pt016210;\n Thu, 5 Mar 2020 10:48:01 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 2BE5F1611DB;\n Thu, 5 Mar 2020 10:48:01 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ivan Malov <ivan.malov@oktetlabs.ru>", "Date": "Thu, 5 Mar 2020 10:47:47 +0000", "Message-ID": "<1583405273-14176-2-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1583405273-14176-1-git-send-email-arybchenko@solarflare.com>", "References": "<1583405273-14176-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1020-25270.003", "X-TM-AS-Result": "No-5.888200-8.000000-10", "X-TMASE-MatchedRID": "PIgnFej44f6RfEAa9TTCniZm6wdY+F8Kpr8UJOYMZDJqrsOvUFEKy88L\n sFcDLWgWJLbE0OI0XCNtw5RFtiqXjfSCkSozt+9huwdUMMznEA8/pOSL72dTfwdkFovAReUo1gg\n lJbmeshO0V6PZx5kBNpf1EF8dUCKBXXhMBXemG5RGjDwRSl8gFBA5wxKjT3bqQW6eCaGxKwLUNu\n /GwgXq7hQEIBfWbs2WuZnpC1DG3WrepncDgUbx3aUjrBFsam6VTdVzLEuviE9DRvNKoirMYNlQt\n UFiiij63YB2wzhQsBSXMgn25/IXtkkjllSXrjtQFEUknJ/kEl7dB/CxWTRRu25FeHtsUoHu63s9\n fHwlQDtOJnempR3MRCnlArFkICrou77ZJxAM1XM2RRIMOrvjaQ==", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--5.888200-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1020-25270.003", "X-MDID": "1583405286-0BFykO2bSqT5", "Subject": "[dpdk-dev] [PATCH 1/7] net/sfc: make flow RSS details VNIC-specific", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nThe flow specification structure will be transformed to a generic one, and\nits current contents will be fenced off to form a VNIC-specific parameters.\nFlow RSS details do not belong to the said specification currently, albeit\nbeing VNIC-specific. This patch addresses this issue as a preparation step.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_flow.c | 12 ++++++------\n drivers/net/sfc/sfc_flow.h | 6 ++++--\n 2 files changed, 10 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c\nindex 8d636f692..f285ba552 100644\n--- a/drivers/net/sfc/sfc_flow.c\n+++ b/drivers/net/sfc/sfc_flow.c\n@@ -1262,7 +1262,7 @@ sfc_flow_parse_rss(struct sfc_adapter *sa,\n \tunsigned int rxq_hw_index_max;\n \tefx_rx_hash_type_t efx_hash_types;\n \tconst uint8_t *rss_key;\n-\tstruct sfc_flow_rss *sfc_rss_conf = &flow->rss_conf;\n+\tstruct sfc_flow_rss *sfc_rss_conf = &flow->spec.rss_conf;\n \tunsigned int i;\n \n \tif (action_rss->queue_num == 0)\n@@ -1334,7 +1334,7 @@ sfc_flow_parse_rss(struct sfc_adapter *sa,\n \t\trss_key = rss->key;\n \t}\n \n-\tflow->rss = B_TRUE;\n+\tflow->spec.rss = B_TRUE;\n \n \tsfc_rss_conf->rxq_hw_index_min = rxq_hw_index_min;\n \tsfc_rss_conf->rxq_hw_index_max = rxq_hw_index_max;\n@@ -1402,12 +1402,12 @@ sfc_flow_filter_insert(struct sfc_adapter *sa,\n {\n \tstruct sfc_adapter_shared * const sas = sfc_sa2shared(sa);\n \tstruct sfc_rss *rss = &sas->rss;\n-\tstruct sfc_flow_rss *flow_rss = &flow->rss_conf;\n+\tstruct sfc_flow_rss *flow_rss = &flow->spec.rss_conf;\n \tuint32_t efs_rss_context = EFX_RSS_CONTEXT_DEFAULT;\n \tunsigned int i;\n \tint rc = 0;\n \n-\tif (flow->rss) {\n+\tif (flow->spec.rss) {\n \t\tunsigned int rss_spread = MIN(flow_rss->rxq_hw_index_max -\n \t\t\t\t\t flow_rss->rxq_hw_index_min + 1,\n \t\t\t\t\t EFX_MAXRSS);\n@@ -1450,7 +1450,7 @@ sfc_flow_filter_insert(struct sfc_adapter *sa,\n \tif (rc != 0)\n \t\tgoto fail_filter_insert;\n \n-\tif (flow->rss) {\n+\tif (flow->spec.rss) {\n \t\t/*\n \t\t * Scale table is set after filter insertion because\n \t\t * the table entries are relative to the base RxQ ID\n@@ -1491,7 +1491,7 @@ sfc_flow_filter_remove(struct sfc_adapter *sa,\n \tif (rc != 0)\n \t\treturn rc;\n \n-\tif (flow->rss) {\n+\tif (flow->spec.rss) {\n \t\t/*\n \t\t * All specifications for a given flow rule have the same RSS\n \t\t * context, so that RSS context value is taken from the first\ndiff --git a/drivers/net/sfc/sfc_flow.h b/drivers/net/sfc/sfc_flow.h\nindex 71ec18cb9..14a6b5d14 100644\n--- a/drivers/net/sfc/sfc_flow.h\n+++ b/drivers/net/sfc/sfc_flow.h\n@@ -43,13 +43,15 @@ struct sfc_flow_spec {\n \tefx_filter_spec_t filters[SF_FLOW_SPEC_NB_FILTERS_MAX];\n \t/* number of complete specifications */\n \tunsigned int count;\n+\t/* RSS toggle */\n+\tboolean_t rss;\n+\t/* RSS configuration */\n+\tstruct sfc_flow_rss rss_conf;\n };\n \n /* PMD-specific definition of the opaque type from rte_flow.h */\n struct rte_flow {\n \tstruct sfc_flow_spec spec;\t/* flow spec for hardware filter(s) */\n-\tboolean_t rss;\t\t\t/* RSS toggle */\n-\tstruct sfc_flow_rss rss_conf;\t/* RSS configuration */\n \tTAILQ_ENTRY(rte_flow) entries;\t/* flow list entries */\n };\n \n", "prefixes": [ "1/7" ] }