Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66229/?format=api
{ "id": 66229, "url": "http://patches.dpdk.org/api/patches/66229/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200303182846.26109-4-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200303182846.26109-4-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200303182846.26109-4-i.dyukov@samsung.com", "date": "2020-03-03T18:27:04", "name": "[v6,3/4] net/virtio-user: fix devargs parsing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "547416f2a9fff7fbae63bbed51480344fdc4c1a3", "submitter": { "id": 783, "url": "http://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200303182846.26109-4-i.dyukov@samsung.com/mbox/", "series": [ { "id": 8768, "url": "http://patches.dpdk.org/api/series/8768/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8768", "date": "2020-03-03T18:27:01", "name": "net/virtio: add link speed devarg", "version": 6, "mbox": "http://patches.dpdk.org/series/8768/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66229/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66229/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E2ACFA056A;\n\tTue, 3 Mar 2020 19:29:30 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9E58E1C02D;\n\tTue, 3 Mar 2020 19:29:11 +0100 (CET)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 8E22A1C021\n for <dev@dpdk.org>; Tue, 3 Mar 2020 19:29:09 +0100 (CET)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200303182908euoutp01374aacb9e0336a99c049f1dc3aa2e99e~43reDE-UE2026920269euoutp01X\n for <dev@dpdk.org>; Tue, 3 Mar 2020 18:29:08 +0000 (GMT)", "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200303182907eucas1p29dab3e1743cf6fc299578fecbc4571f1~43rdCxd6l0069500695eucas1p2H;\n Tue, 3 Mar 2020 18:29:07 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges1new.samsung.com (EUCPMTA) with SMTP id 2D.AC.61286.3F1AE5E5; Tue, 3\n Mar 2020 18:29:07 +0000 (GMT)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200303182906eucas1p2a80e3e02c52746e750c743accda56d34~43rcX3HFT0069500695eucas1p2G;\n Tue, 3 Mar 2020 18:29:06 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200303182906eusmtrp2258e4b5eb017dea2bc5e685d773559f9~43rcXTjj_0347103471eusmtrp2l;\n Tue, 3 Mar 2020 18:29:06 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 3B.A4.07950.2F1AE5E5; Tue, 3\n Mar 2020 18:29:06 +0000 (GMT)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200303182906eusmtip1ec375943a26c44fca2a2f38a46c57cb4~43rb0vQ-H1574315743eusmtip1c;\n Tue, 3 Mar 2020 18:29:06 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200303182908euoutp01374aacb9e0336a99c049f1dc3aa2e99e~43reDE-UE2026920269euoutp01X", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1583260148;\n bh=XZrkyRg2+Pz7PpyRdqYMptfy5QvNeuXSDMV/FIlv+bc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=CjB41ny7M4Z9AelZ7eqo24N4K15KyO3ZApIRi5G+VjVSGcf5Nl8HJWRVNKI//sEGv\n whkc+YEMGcVy7mgyxbeKOw65DJ1yT1iNCj15IAEkPAyely9o7Nz9ljUE2eL2gbS6Il\n G8sf9JlVDwIQcYG1hz/VUtsJLeQcDqlMBo2k+Iio=", "X-AuditID": "cbfec7f2-f0bff7000001ef66-56-5e5ea1f3c4f7", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,\n amorenoz@redhat.com, zhihong.wang@intel.com, xiaolong.ye@intel.com", "Cc": "Ivan Dyukov <i.dyukov@samsung.com>", "Date": "Tue, 3 Mar 2020 21:27:04 +0300", "Message-Id": "<20200303182846.26109-4-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200303182846.26109-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWy7djP87qfF8bFGSzqVLdo3fGAxeLdp+1M\n FrMuNbFbHOvcw2KxteE/k8WfN6YWmy9OYnJg9/i1YCmrx+I9L5k83u+7yubRt2UVYwBLFJdN\n SmpOZllqkb5dAlfGhDfnmQuecVQc2TCTvYFxJnsXIyeHhICJxL95J5i6GLk4hARWMEpM+zWf\n DcL5wihx/E0PI4TzmVHiQ+ciFpiWO0eWQVUtZ5R4PusOO4TzlVHi5dVbbCBVbAIaEqc75oEN\n FhFoZ5RYNaUFrJ1ZQE3iQ897IJuDQ1jARuL+9ywQk0VAVeL+hgIQk1fAUuL9KQ+IXfISqzcc\n YAaxOQWsJE7caWMBmSgh8JxNYsbm+VA/uEj8PbQHyhaWeHV8C5QtI/F/53wmCLta4vum6+wQ\n zR2MEvcWtUIV2UtseX2OHWQxs4CmxPpd+hBhR4mWl0sYQcISAnwSN94KQhzPJzFp23RmiDCv\n REebEES1ksSBk5egwhISf3/zQJgeEou2c0PC5gqjxPtldxgnMMrPQli1gJFxFaN4amlxbnpq\n sWFearlecWJucWleul5yfu4mRmBSOP3v+KcdjF8vJR1iFOBgVOLhlfCMixNiTSwrrsw9xCjB\n wawkwuvLGR0nxJuSWFmVWpQfX1Sak1p8iFGag0VJnNd40ctYIYH0xJLU7NTUgtQimCwTB6dU\n A2NciGblxP//pyetLbKefWKO5I7HJ6f7rIwRrLjOd7D12Wwm/72t53p51t/xXXHKaO1ZlvC+\n BMnL2/5V6bWcYVn+PWKd4fQmoRUSxzOKq2cvun1e9cFclYQ/93cpZVYWZHsV3NjExCj2VV5T\n xXXnfIXbVmGvm1fGXPh/9+XCq9r7ZKX+MOQxPORSYinOSDTUYi4qTgQAQvFHogYDAAA=", "\n H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsVy+t/xu7qfFsbFGXR1WFq07njAYvHu03Ym\n i1mXmtgtjnXuYbHY2vCfyeLPG1OLzRcnMTmwe/xasJTVY/Gel0we7/ddZfPo27KKMYAlSs+m\n KL+0JFUhI7+4xFYp2tDCSM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS9jwpvzzAXP\n OCqObJjJ3sA4k72LkZNDQsBE4s6RZWxdjFwcQgJLGSXWbLnK1MXIAZSQkHj9hBmiRljiz7Uu\n qJrPjBJzZp8GS7AJaEic7pjHBJIQEehnlNj46zdYgllATeJDz3sWkEHCAjYS979ngZgsAqoS\n 9zcUgJi8ApYS7095QIyXl1i94QBYI6eAlcSJO20sEKsaGCU27FrMMoGRbwEjwypGkdTS4tz0\n 3GIjveLE3OLSvHS95PzcTYzAMN127OeWHYxd74IPMQpwMCrx8Ep4xsUJsSaWFVfmHmKU4GBW\n EuH15YyOE+JNSaysSi3Kjy8qzUktPsRoCnTTRGYp0eR8YAzllcQbmhqaW1gamhubG5tZKInz\n dggcjBESSE8sSc1OTS1ILYLpY+LglGpg3Jsh5KM3ba/Vs6M60ryzLx348aAi2tz7m1f1pcu9\n dfzPzHc+fMCp+XLl1RnflPe/v7DdM9aZxWHa8yNN6j4NoW3bDGT0D2zf4Hs4bdrzS9X3BIss\n LeRfCyWWRXpUblxb+9eqR9eqZVluRZjD+hm/PtgFzny9ftrSbbKvnj1/t9ejRIunPXADqxJL\n cUaioRZzUXEiAJeWdahpAgAA" ], "X-CMS-MailID": "20200303182906eucas1p2a80e3e02c52746e750c743accda56d34", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200303182906eucas1p2a80e3e02c52746e750c743accda56d34", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200303182906eucas1p2a80e3e02c52746e750c743accda56d34", "References": "\n <CAJFAV8zQ7=EaQ93H4yMEUsZhnKog8fguoHU1W2WXgCKtefJZLg@mail.gmail.com>\n <20200303182846.26109-1-i.dyukov@samsung.com>\n <CGME20200303182906eucas1p2a80e3e02c52746e750c743accda56d34@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v6 3/4] net/virtio-user: fix devargs parsing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "strtoull returns 0 if it fails to parse input string. It's ignored\nin get_integer_arg.\n\nThis patch handles error cases for strtoull function.\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n drivers/net/virtio/virtio_user_ethdev.c | 13 +++++++++----\n 1 file changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 3fc172573..074527714 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -433,12 +433,17 @@ static int\n get_integer_arg(const char *key __rte_unused,\n \t\tconst char *value, void *extra_args)\n {\n+\tuint64_t integer = 0;\n \tif (!value || !extra_args)\n \t\treturn -EINVAL;\n-\n-\t*(uint64_t *)extra_args = strtoull(value, NULL, 0);\n-\n-\treturn 0;\n+\terrno = 0;\n+\tinteger = strtoull(value, NULL, 0);\n+\t/* extra_args keeps default value, it should be replaced\n+\t * only in case of successful parsing of the 'value' arg\n+\t */\n+\tif (errno == 0)\n+\t\t*(uint64_t *)extra_args = integer;\n+\treturn -errno;\n }\n \n static struct rte_eth_dev *\n", "prefixes": [ "v6", "3/4" ] }