Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66227/?format=api
{ "id": 66227, "url": "http://patches.dpdk.org/api/patches/66227/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200303182846.26109-2-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200303182846.26109-2-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200303182846.26109-2-i.dyukov@samsung.com", "date": "2020-03-03T18:27:02", "name": "[v6,1/4] net/virtio: refactor devargs parsing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b223a7a74cf86c981646bb2e7725ac9500b54586", "submitter": { "id": 783, "url": "http://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200303182846.26109-2-i.dyukov@samsung.com/mbox/", "series": [ { "id": 8768, "url": "http://patches.dpdk.org/api/series/8768/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8768", "date": "2020-03-03T18:27:01", "name": "net/virtio: add link speed devarg", "version": 6, "mbox": "http://patches.dpdk.org/series/8768/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66227/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66227/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E4A78A056A;\n\tTue, 3 Mar 2020 19:29:11 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6933B1C00E;\n\tTue, 3 Mar 2020 19:29:07 +0100 (CET)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id A68041C00D\n for <dev@dpdk.org>; Tue, 3 Mar 2020 19:29:05 +0100 (CET)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200303182904euoutp02f776c83d777ef879d8ef18c8266798dd~43raZ-uIt0662906629euoutp02p\n for <dev@dpdk.org>; Tue, 3 Mar 2020 18:29:04 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20200303182904eucas1p1dd3937c5da1833ea06ce29eb98799a84~43raAONTj0553105531eucas1p1X;\n Tue, 3 Mar 2020 18:29:04 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id 20.A0.60679.0F1AE5E5; Tue, 3\n Mar 2020 18:29:04 +0000 (GMT)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200303182903eucas1p2f46d594c58b9add3aa09fa05a7aa037c~43rZfEtMm0075300753eucas1p2D;\n Tue, 3 Mar 2020 18:29:03 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200303182903eusmtrp215bf7fd880a1f3b4e8ad8878834293a8~43rZefy5y0347103471eusmtrp2h;\n Tue, 3 Mar 2020 18:29:03 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 3A.A4.07950.FE1AE5E5; Tue, 3\n Mar 2020 18:29:03 +0000 (GMT)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200303182903eusmtip18ceb30e660ea699eca2505f6bb230fc9~43rY8yQwp0510805108eusmtip1e;\n Tue, 3 Mar 2020 18:29:03 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200303182904euoutp02f776c83d777ef879d8ef18c8266798dd~43raZ-uIt0662906629euoutp02p", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1583260144;\n bh=uoKcpBlnjKNHps9LwNaAF1miImcsZMlQR8uL91wEOoc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Rp+wS+b/qlr0S4564P0tagAQvNez1GWPQcCKFKvvPr26Dx1z6V4bvQnZaV36MOOG/\n QR8r/SFFK/N7mB5xpZf2jbGL8Wfx0ir2InIr/fl6KSTkNoCcmQJIylo5mt3/UwfmjC\n VNoUG3Uob1nnqhxHBUE0f+o8hdCPhb5ZmutM+oqw=", "X-AuditID": "cbfec7f4-0e5ff7000001ed07-29-5e5ea1f00936", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,\n amorenoz@redhat.com, zhihong.wang@intel.com, xiaolong.ye@intel.com", "Cc": "Ivan Dyukov <i.dyukov@samsung.com>", "Date": "Tue, 3 Mar 2020 21:27:02 +0300", "Message-Id": "<20200303182846.26109-2-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200303182846.26109-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsWy7djPc7ofFsbFGXQ1iVm07njAYvHu03Ym\n i1mXmtgtjnXuYbHY2vCfyeLPG1OLzRcnMTmwe/xasJTVY/Gel0we7/ddZfPo27KKMYAlissm\n JTUnsyy1SN8ugSvj9a9nbAXLBSvOr3NsYGzk62Lk4JAQMJHoee7UxcjFISSwglHi18svzBDO\n F0aJ7XOOQzmfGSXW7D3H2sXICdZxeccvFojEckaJjQcWsoEkhAS+MkocnKsFYrMJaEic7pjH\n BFIkItDOKLFqSgsLSIJZQE3iQ897MFtYwEbi7+OpjCA2i4CqxJN5b8A28ApYSpw58Qlqm7zE\n 6g0HmEFsTgEriRN32sA2Swi8ZpP48uYtM0SRi8TsiTPZIGxhiVfHt7BD2DIS/3fOZ4KwqyW+\n b7rODtHcwShxb1ErVJG9xJbX59hBocEsoCmxfpc+RNhR4uT1h8yQQOKTuPFWEOJ+PolJ26ZD\n hXklOtqEIKqVJA6cvAQVlpD4+5sHIuwhce3nVTZIWF1hlHjbeYltAqP8LIRdCxgZVzGKp5YW\n 56anFhvlpZbrFSfmFpfmpesl5+duYgSmhdP/jn/ZwbjrT9IhRgEORiUeXgnPuDgh1sSy4src\n Q4wSHMxKIry+nNFxQrwpiZVVqUX58UWlOanFhxilOViUxHmNF72MFRJITyxJzU5NLUgtgsky\n cXBKNTAmaoVF/31kbhs9y/KXBW/zROkt8eEtawps23ODln3eNFlpWoOCg+vFdQX8F5ROteuV\n qUvtCX/0Ifn2n+lnCvQzUpnVen0dROczbv9puMDsg/PZ+x8m2IbdWKUsc37nTpOXzSwO+7uu\n 8j242PzwoK75aed9X4riy97E+YnH8Yf8iqopU13f90+JpTgj0VCLuag4EQC/OA1NBwMAAA==", "\n H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xu7rvF8bFGUw/ZmjRuuMBi8W7T9uZ\n LGZdamK3ONa5h8Via8N/Jos/b0wtNl+cxOTA7vFrwVJWj8V7XjJ5vN93lc2jb8sqxgCWKD2b\n ovzSklSFjPziElulaEMLIz1DSws9IxNLPUNj81grI1MlfTublNSczLLUIn27BL2M17+esRUs\n F6w4v86xgbGRr4uRk0NCwETi8o5fLF2MXBxCAksZJf49amDsYuQASkhIvH7CDFEjLPHnWhcb\n RM1nRolf/edZQBJsAhoSpzvmMYEkRAT6GSU2/voN1sEsoCbxoec9WJGwgI3E38dTGUFsFgFV\n iSfz3rCC2LwClhJnTnxihdggL7F6wwGwXk4BK4kTd9qgLmpglNiwazHLBEa+BYwMqxhFUkuL\n c9Nzi430ihNzi0vz0vWS83M3MQJDdduxn1t2MHa9Cz7EKMDBqMTDK+EZFyfEmlhWXJl7iFGC\n g1lJhNeXMzpOiDclsbIqtSg/vqg0J7X4EKMp0FUTmaVEk/OBcZRXEm9oamhuYWlobmxubGah\n JM7bIXAwRkggPbEkNTs1tSC1CKaPiYNTqoFR63Vi4CVOYblM22VrZUxEfrl43QqbvHyG6nI+\n I//Ly72jvs/i1pvq6y3m3z2hPCi+klOr3lDv1/XHppE8Ew6XV+79INVcGLe4lVMwRTWorenw\n tYLYb+kcaxk/nrr5o/dZluz9/3+7I42SJkUFZS7ZeDwk101rv+bZ6wZ3trxdwBEqH38lKUeJ\n pTgj0VCLuag4EQDptKZlawIAAA==" ], "X-CMS-MailID": "20200303182903eucas1p2f46d594c58b9add3aa09fa05a7aa037c", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200303182903eucas1p2f46d594c58b9add3aa09fa05a7aa037c", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200303182903eucas1p2f46d594c58b9add3aa09fa05a7aa037c", "References": "\n <CAJFAV8zQ7=EaQ93H4yMEUsZhnKog8fguoHU1W2WXgCKtefJZLg@mail.gmail.com>\n <20200303182846.26109-1-i.dyukov@samsung.com>\n <CGME20200303182903eucas1p2f46d594c58b9add3aa09fa05a7aa037c@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v6 1/4] net/virtio: refactor devargs parsing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "refactor vdpa specific devargs parsing to more generic way\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 34 +++++++++++++++++++++---------\n 1 file changed, 24 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 044eb10a7..f814aa926 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1955,16 +1955,18 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)\n }\n \n static int vdpa_check_handler(__rte_unused const char *key,\n-\t\tconst char *value, __rte_unused void *opaque)\n+\t\tconst char *value, void *ret_val)\n {\n-\tif (strcmp(value, \"1\"))\n-\t\treturn -1;\n+\tif (strcmp(value, \"1\") == 0)\n+\t\t*(int *)ret_val = 1;\n+\telse\n+\t\t*(int *)ret_val = 0;\n \n \treturn 0;\n }\n \n static int\n-vdpa_mode_selected(struct rte_devargs *devargs)\n+virtio_dev_devargs_parse(struct rte_devargs *devargs, int *vdpa)\n {\n \tstruct rte_kvargs *kvlist;\n \tconst char *key = \"vdpa\";\n@@ -1980,12 +1982,16 @@ vdpa_mode_selected(struct rte_devargs *devargs)\n \tif (!rte_kvargs_count(kvlist, key))\n \t\tgoto exit;\n \n-\t/* vdpa mode selected when there's a key-value pair: vdpa=1 */\n-\tif (rte_kvargs_process(kvlist, key,\n-\t\t\t\tvdpa_check_handler, NULL) < 0) {\n-\t\tgoto exit;\n+\tif (vdpa) {\n+\t\t/* vdpa mode selected when there's a key-value pair:\n+\t\t * vdpa=1\n+\t\t */\n+\t\tret = rte_kvargs_process(kvlist, key,\n+\t\t\t\tvdpa_check_handler, vdpa);\n+\t\tif (ret < 0)\n+\t\t\tgoto exit;\n \t}\n-\tret = 1;\n+\n \n exit:\n \trte_kvargs_free(kvlist);\n@@ -1995,8 +2001,16 @@ vdpa_mode_selected(struct rte_devargs *devargs)\n static int eth_virtio_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tstruct rte_pci_device *pci_dev)\n {\n+\tint vdpa = 0;\n+\tint ret = 0;\n+\n+\tret = virtio_dev_devargs_parse(pci_dev->device.devargs, &vdpa);\n+\tif (ret < 0) {\n+\t\tPMD_INIT_LOG(ERR, \"devargs parsing is failed\");\n+\t\treturn ret;\n+\t}\n \t/* virtio pmd skips probe if device needs to work in vdpa mode */\n-\tif (vdpa_mode_selected(pci_dev->device.devargs))\n+\tif (vdpa == 1)\n \t\treturn 1;\n \n \treturn rte_eth_dev_pci_generic_probe(pci_dev, sizeof(struct virtio_hw),\n", "prefixes": [ "v6", "1/4" ] }