Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66222/?format=api
{ "id": 66222, "url": "http://patches.dpdk.org/api/patches/66222/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200303175938.14292-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200303175938.14292-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200303175938.14292-5-stephen@networkplumber.org", "date": "2020-03-03T17:59:36", "name": "[4/6] net/bnxt: check for integer overflow in buffer sizing", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "eb3f44b5fabec3175eb85e3736323f4115f928fb", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200303175938.14292-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 8766, "url": "http://patches.dpdk.org/api/series/8766/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8766", "date": "2020-03-03T17:59:32", "name": "net/bnxt: bounds checking patches", "version": 1, "mbox": "http://patches.dpdk.org/series/8766/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66222/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66222/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 29D74A0571;\n\tTue, 3 Mar 2020 19:00:19 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AAABA1C037;\n\tTue, 3 Mar 2020 18:59:49 +0100 (CET)", "from mail-pf1-f193.google.com (mail-pf1-f193.google.com\n [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 94BF61C021\n for <dev@dpdk.org>; Tue, 3 Mar 2020 18:59:47 +0100 (CET)", "by mail-pf1-f193.google.com with SMTP id 2so1830099pfg.12\n for <dev@dpdk.org>; Tue, 03 Mar 2020 09:59:47 -0800 (PST)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id w195sm22012158pfd.65.2020.03.03.09.59.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 03 Mar 2020 09:59:45 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=IY9fGot27Lx8SYjW7fmgxyV883jhkPL/rosb+0Y3skg=;\n b=O/EwGFaYtOA/02Wl4df/N02xpptw+tOeHH9uxmeW1oF/m9PuoczLPG9MPMPgvBynt6\n Y3YTFjmJV//QUvDJNhzsHrpwXvpS8jHiiS8YBYVArUkihO5GATr3S3eFaY3WtbHjqixH\n 4DQuPn2aAEo+YErHKhpU9+bWuPRSIlw0DjwAu3x5EGqxhcXxHMCBJX3IpoTTvvC4IkPO\n GFsQYtkFOHk2GWCAKtYtcoga+7XAHLBm+ilAvg89m/7kvjI6Cc3WbnGewT+uKfaRpUt+\n Hb9uy0M71TVav+8d99ayph81dtm5De5Md46P2LqYZUTc+CAqfRb8lsCtggWygkLix65e\n NQKQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=IY9fGot27Lx8SYjW7fmgxyV883jhkPL/rosb+0Y3skg=;\n b=XOn79gSa6y2Tc+JSVexG61Apw6dzt2EOUwVcuWfYS8s2s2zCFk1O6puY/BH6RF0DlI\n siU/ngjhg9K1C+O1At/VWESqwlEslTnGmpgCDJ565WqGdYyB3V85wTPm1U6qYuLLxg9S\n ALb0+E5fOO6gqMaSb34z9SxRqjAt5SbBZ1dlB1buv5UOJOSeJAqyj5xqhFuVqKecqNYZ\n W+EAfsvlIJUlryrtm5ENH5xMqhy5CBsrN2Dwm0t+YTXOE9FLUVkNpjRdxwzGdXp1taBG\n kDvC4H1R7UWwigVNWaxvutGzLF50yWGatenChSh6JTKBvd04LArvLYVvpRbdBDZ2WYKe\n bvAQ==", "X-Gm-Message-State": "ANhLgQ2M6rQq/7S0Q2JR6ZIIp9tDHNk1tO6pvXqod59oFafo2v+rCmlk\n 4Iwm0r+QyaDIZ0eR+7LJVxpFQg==", "X-Google-Smtp-Source": "\n ADFU+vuhLepTsyOlaFPGlxVWYk4ItjcTEbtFKbVulylJ0oD7wK1ABjg7QEhIiY594H2p6ckloc3RdQ==", "X-Received": "by 2002:a62:7b4f:: with SMTP id w76mr5414983pfc.226.1583258386799;\n Tue, 03 Mar 2020 09:59:46 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "ajit.khaparde@broadcom.com,\n\tsomnath.kotur@broadcom.com", "Cc": "dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,\n Christopher Ertl <Christopher.Ertl@microsoft.com>", "Date": "Tue, 3 Mar 2020 09:59:36 -0800", "Message-Id": "<20200303175938.14292-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200303175938.14292-1-stephen@networkplumber.org>", "References": "<20200303175938.14292-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 4/6] net/bnxt: check for integer overflow in\n\tbuffer sizing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If the hardware returns invalid values, the buffer size calculation\ncould overflow. Check for this by using the GCC/Clang builtin\nthat checks.\n\nReported-by: Christopher Ertl <Christopher.Ertl@microsoft.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/bnxt/bnxt_hwrm.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex ad8bdb1c2913..6beb215d604f 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -11,6 +11,7 @@\n #include <rte_malloc.h>\n #include <rte_memzone.h>\n #include <rte_version.h>\n+#include <rte_overflow.h>\n #include <rte_io.h>\n \n #include \"bnxt.h\"\n@@ -3861,7 +3862,9 @@ int bnxt_get_nvram_directory(struct bnxt *bp, uint32_t len, uint8_t *data)\n \tlen -= 2;\n \tmemset(data, 0xff, len);\n \n-\tbuflen = dir_entries * entry_length;\n+\tif (rte_mul_overflow(dir_entries, entry_length, &buflen))\n+\t\treturn -EINVAL;\n+\n \tbuf = rte_malloc(\"nvm_dir\", buflen, 0);\n \tif (buf == NULL)\n \t\treturn -ENOMEM;\n", "prefixes": [ "4/6" ] }