Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66221/?format=api
{ "id": 66221, "url": "http://patches.dpdk.org/api/patches/66221/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200303175938.14292-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200303175938.14292-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200303175938.14292-4-stephen@networkplumber.org", "date": "2020-03-03T17:59:35", "name": "[3/6] net/bnxt: avoid potential out of bounds read", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "ada2258f203c345d7c31047e37bad0a0dc3bbfae", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200303175938.14292-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 8766, "url": "http://patches.dpdk.org/api/series/8766/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8766", "date": "2020-03-03T17:59:32", "name": "net/bnxt: bounds checking patches", "version": 1, "mbox": "http://patches.dpdk.org/series/8766/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66221/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66221/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 68596A0571;\n\tTue, 3 Mar 2020 19:00:11 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 779421C029;\n\tTue, 3 Mar 2020 18:59:48 +0100 (CET)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 469771C01B\n for <dev@dpdk.org>; Tue, 3 Mar 2020 18:59:46 +0100 (CET)", "by mail-pg1-f195.google.com with SMTP id m5so1905359pgg.0\n for <dev@dpdk.org>; Tue, 03 Mar 2020 09:59:46 -0800 (PST)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id w195sm22012158pfd.65.2020.03.03.09.59.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 03 Mar 2020 09:59:44 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=LjZDm1y9Bm3Y9T51ZbQPgdj+mQXmxtrPnw8e2sLhH+w=;\n b=fmGhWcq556D7HSfj15zwWxCJgSgF83+tpCVhYzcOw9xXpHqWtQaVC0jXPPdFDhHb7K\n ZAEh7AJym1AAV1/DWYYizPChNeqau+bRR5mjaFg1xcgGfuC5hcgsC8XEwXzYbte/xe3e\n 7T7Gn9KvljbNYctk1WEFHQ8sJbwAq3dfQQBFR2W60lpRAxkvQhqRGmxT1pFtjecG3CHG\n XK82gg3SuHkzj82Bi4sgpfA4gxyq8KotkMlnHZYmaHiA+cj1d9dgjGRyPuCnwccxPbrT\n l1AO4soGmqfFpI0GAV1RpHKdRJITmfHJ+fDJinUzdcUpIYU+Fbt2J7RneMNRo7w3O6E9\n Nu8A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=LjZDm1y9Bm3Y9T51ZbQPgdj+mQXmxtrPnw8e2sLhH+w=;\n b=o/5ORhmku64r/gPCct2DyWZmwQELk08ZOtUHoGX9+gx8dOpncfw5lgG/Iy/415Go4o\n KOJpwRCDYVjKNlhdBWIiapedLrf1FbNip6PGetHjrttAOsaU7Ap+VfKGrf28rndrUses\n 4wBtDKKu/IRrhNAFP2BCvlJRWas7KkX9ERdL0L7RuiMt8LlnxbuwymwdrylQODbfrxrV\n XEz6mZRM7+boqFR+Lt6NB27NgGFxtvZNQh+RF80GevFdaHd3OyMMyPHnyyS02Jr4mLfW\n ybfq7gytIuaWQl6hz7QKXCSJOJEvOA89LblOgdeS1S0XWao7RHCChTKteFepxCGb2Bnj\n ILwA==", "X-Gm-Message-State": "ANhLgQ2Xt1rR3kIPZLgHyHmCxVZaqdgk4fyN0mtYfX+8FvDTzmLONXRi\n pwes2Tj279HmbkvIWW2oddPqaw==", "X-Google-Smtp-Source": "\n ADFU+vur9sRjPRUABWf9oxQbPwe8YEst+U/h9Nv+CnQEV/lKoLyQxbEa6AqcSIg59mDO+hzjodLwrQ==", "X-Received": "by 2002:a63:2a4e:: with SMTP id q75mr5171280pgq.358.1583258385478;\n Tue, 03 Mar 2020 09:59:45 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "ajit.khaparde@broadcom.com,\n\tsomnath.kotur@broadcom.com", "Cc": "dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,\n Christopher Ertl <Christopher.Ertl@microsoft.com>", "Date": "Tue, 3 Mar 2020 09:59:35 -0800", "Message-Id": "<20200303175938.14292-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200303175938.14292-1-stephen@networkplumber.org>", "References": "<20200303175938.14292-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/6] net/bnxt: avoid potential out of bounds read", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If hardware returned a bogus number of vnic's from the\nquery it could cause an out of bounds read into vnic table.\n\nReported-by: Christopher Ertl <Christopher.Ertl@microsoft.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/bnxt/bnxt_hwrm.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 20e2f6a36713..ad8bdb1c2913 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -4029,6 +4029,12 @@ static int bnxt_hwrm_func_vf_vnic_query(struct bnxt *bp, uint16_t vf,\n \n \tHWRM_UNLOCK();\n \n+\tif (rc > bp->pf.total_vnics) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"Vnic id %d is out of range\\n\", rc);\n+\t\treturn -EINVAL;\n+\t}\n+\n \treturn rc;\n }\n \n", "prefixes": [ "3/6" ] }