Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 66220,
    "url": "http://patches.dpdk.org/api/patches/66220/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200303175938.14292-3-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200303175938.14292-3-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200303175938.14292-3-stephen@networkplumber.org",
    "date": "2020-03-03T17:59:34",
    "name": "[2/6] net/bnxt: fix potential data race",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "2b252e2ae91082aabb3967c0ce5620e0d671bde6",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1766,
        "url": "http://patches.dpdk.org/api/users/1766/?format=api",
        "username": "ajitkhaparde",
        "first_name": "Ajit",
        "last_name": "Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200303175938.14292-3-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 8766,
            "url": "http://patches.dpdk.org/api/series/8766/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8766",
            "date": "2020-03-03T17:59:32",
            "name": "net/bnxt: bounds checking patches",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/8766/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/66220/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/66220/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 92A30A0571;\n\tTue,  3 Mar 2020 19:00:02 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 32F231C01E;\n\tTue,  3 Mar 2020 18:59:47 +0100 (CET)",
            "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 399AE1C012\n for <dev@dpdk.org>; Tue,  3 Mar 2020 18:59:45 +0100 (CET)",
            "by mail-pl1-f194.google.com with SMTP id x17so1650679plm.10\n for <dev@dpdk.org>; Tue, 03 Mar 2020 09:59:44 -0800 (PST)",
            "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id w195sm22012158pfd.65.2020.03.03.09.59.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 03 Mar 2020 09:59:43 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=ap7V2Mf+iyDGYa/E3yDLrfkvs2vTi+qaq5RjdBx02GI=;\n b=nx5yDPYm/pMHc2xS13NUa7EyIccW9H/N1n7Vv4Ud6rn8vIXjItKi4wSgHDQKBv9bJ1\n cdq7G0O1CJrD4U3R2dHEd6fE2ssQkQ7RRcYHzh6GQ/t1rKf9LJXqQutfbsCuXUEhyexQ\n cZeI5g7owkpwxvIS+owyZ1jdqdVyQQ84sXaR8n1c6/yCyf1htMK78p8W6gT6kQH7o4JJ\n MnCVHe9W8chGt8cySi9JSSqK+nGhgq3gEITkHIAqevjAGnN3yrg4rpMy7nyxXRTmvfau\n 6/i/gVXhaLUJhOC/sS7+Xba6C3s/p4v6iNy2G7ZOwosIPmcdEpRW3xL4pZr06l/NfYhi\n 0Eiw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=ap7V2Mf+iyDGYa/E3yDLrfkvs2vTi+qaq5RjdBx02GI=;\n b=mVSrQiDLaVIbLxaKt/x1jhqjKx7OF+SCIM50SVFVaetEm+BzfQkFn7+fCIZdAdZ4Lv\n 5Orqo5Vev9T9DM0x/Z97SP2Iw1sUm52HcUx40WQf6rspEQQASY6h8L1DXlDtuOhBTomu\n iliVHe3p81FlJq50D8W6kxYtGBQVp/rtKXUnjL32b40ACKXl8GiQFtg52I3JP50YP6lK\n 3EbSIy6y3CKulNEUWNw6xVlMtUonylqCtaS5fT7745UseoXLJnZKUCT875u7zvJLGOIx\n DvQ6tCbWaGn9URYZV01iDAoIZMXYOHAXmk9qI8tiB8ECcG1oxtqC91MnbbYeCTrXbsIX\n +4Tg==",
        "X-Gm-Message-State": "ANhLgQ0WGw0der50tkqdz2bEH6P0zicERc61tsSJpvPXpd0cUJ3T6Cc4\n kMifMNOPswxU82Qbv1rjD+3UqQ==",
        "X-Google-Smtp-Source": "\n ADFU+vszG4Tl9g6BK9+TPRqQHfP97LGzXul9b+EVQmtTgioRn8K1uzoPaI8I9SXSPOhC45tineW2iQ==",
        "X-Received": "by 2002:a17:90b:94d:: with SMTP id\n dw13mr5349368pjb.13.1583258384181;\n Tue, 03 Mar 2020 09:59:44 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "ajit.khaparde@broadcom.com,\n\tsomnath.kotur@broadcom.com",
        "Cc": "dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,\n Christopher Ertl <Christopher.Ertl@microsoft.com>",
        "Date": "Tue,  3 Mar 2020 09:59:34 -0800",
        "Message-Id": "<20200303175938.14292-3-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20200303175938.14292-1-stephen@networkplumber.org>",
        "References": "<20200303175938.14292-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 2/6] net/bnxt: fix potential data race",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The response from the firmware is accessed multiple times.\nThis is a potential TOCTOU error.\n\nReported-by: Christopher Ertl <Christopher.Ertl@microsoft.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/bnxt/bnxt_hwrm.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex a9c9c7297cab..20e2f6a36713 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -3746,6 +3746,7 @@ int bnxt_hwrm_port_led_qcaps(struct bnxt *bp)\n {\n \tstruct hwrm_port_led_qcaps_output *resp = bp->hwrm_cmd_resp_addr;\n \tstruct hwrm_port_led_qcaps_input req = {0};\n+\tuint8_t num_leds;\n \tint rc;\n \n \tif (BNXT_VF(bp))\n@@ -3757,10 +3758,11 @@ int bnxt_hwrm_port_led_qcaps(struct bnxt *bp)\n \n \tHWRM_CHECK_RESULT();\n \n-\tif (resp->num_leds > 0 && resp->num_leds < BNXT_MAX_LED) {\n+\tnum_leds = resp->num_leds;\n+\tif (num_leds > 0 && num_leds < BNXT_MAX_LED) {\n \t\tunsigned int i;\n \n-\t\tbp->num_leds = resp->num_leds;\n+\t\tbp->num_leds = num_leds;\n \t\tmemcpy(bp->leds, &resp->led0_id,\n \t\t\tsizeof(bp->leds[0]) * bp->num_leds);\n \t\tfor (i = 0; i < bp->num_leds; i++) {\n",
    "prefixes": [
        "2/6"
    ]
}