Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66165/?format=api
{ "id": 66165, "url": "http://patches.dpdk.org/api/patches/66165/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200302143209.11854-5-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200302143209.11854-5-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200302143209.11854-5-hemant.agrawal@nxp.com", "date": "2020-03-02T14:32:03", "name": "[04/10] net/enetc: erratum wa for Rx lock-up issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c48027228f3bb89a210b6c824f6da00a35db62e4", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200302143209.11854-5-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 8741, "url": "http://patches.dpdk.org/api/series/8741/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8741", "date": "2020-03-02T14:31:59", "name": "net/enetc: optimization and cleanup", "version": 1, "mbox": "http://patches.dpdk.org/series/8741/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66165/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66165/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 14401A0568;\n\tMon, 2 Mar 2020 10:01:01 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4C24C1C067;\n\tMon, 2 Mar 2020 10:00:22 +0100 (CET)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by dpdk.org (Postfix) with ESMTP id BA3431C01B\n for <dev@dpdk.org>; Mon, 2 Mar 2020 10:00:17 +0100 (CET)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 9EFED1A0FBA;\n Mon, 2 Mar 2020 10:00:17 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 1F4311A0FC1;\n Mon, 2 Mar 2020 10:00:15 +0100 (CET)", "from bf-netperf1.ap.com (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 6C60D402F3;\n Mon, 2 Mar 2020 17:00:11 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, g.singh@nxp.com,\n Alex Marginean <alexandru.marginean@nxp.com>", "Date": "Mon, 2 Mar 2020 20:02:03 +0530", "Message-Id": "<20200302143209.11854-5-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200302143209.11854-1-hemant.agrawal@nxp.com>", "References": "<20200302143209.11854-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 04/10] net/enetc: erratum wa for Rx lock-up issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Alex Marginean <alexandru.marginean@nxp.com>\n\nThe default value in hardware for the Rx MAC FIFO (@) is higher than it\nshould be and can lead to Rx lock-up under traffic.\nSet it to the value recommended by hardware team, 1.\n\nSigned-off-by: Alex Marginean <alexandru.marginean@nxp.com>\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/net/enetc/base/enetc_hw.h | 3 ++-\n drivers/net/enetc/enetc_ethdev.c | 5 ++++-\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/enetc/base/enetc_hw.h b/drivers/net/enetc/base/enetc_hw.h\nindex 2fe7ccb5b..00813284e 100644\n--- a/drivers/net/enetc/base/enetc_hw.h\n+++ b/drivers/net/enetc/base/enetc_hw.h\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright 2018-2019 NXP\n+ * Copyright 2018-2020 NXP\n */\n \n #ifndef _ENETC_HW_H_\n@@ -86,6 +86,7 @@ enum enetc_bdr_type {TX, RX};\n #define ENETC_PSIPMAR1(n)\t\t(0x00104 + (n) * 0x20)\n #define ENETC_PCAPR0\t\t\t0x00900\n #define ENETC_PCAPR1\t\t\t0x00904\n+#define ENETC_PM0_RX_FIFO\t\t0x801C\n #define ENETC_PM0_IF_MODE\t\t0x8300\n #define ENETC_PM1_IF_MODE\t\t0x9300\n #define ENETC_PMO_IFM_RG\t\tBIT(2)\ndiff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c\nindex 20b77c006..eb637d030 100644\n--- a/drivers/net/enetc/enetc_ethdev.c\n+++ b/drivers/net/enetc/enetc_ethdev.c\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright 2018-2019 NXP\n+ * Copyright 2018-2020 NXP\n */\n \n #include <stdbool.h>\n@@ -147,6 +147,9 @@ enetc_hardware_init(struct enetc_eth_hw *hw)\n \thw->hw.port = (void *)((size_t)hw->hw.reg + ENETC_PORT_BASE);\n \thw->hw.global = (void *)((size_t)hw->hw.reg + ENETC_GLOBAL_BASE);\n \n+\t/* WA for Rx lock-up HW erratum */\n+\tenetc_port_wr(enetc_hw, ENETC_PM0_RX_FIFO, 1);\n+\n \t/* Enabling Station Interface */\n \tenetc_wr(enetc_hw, ENETC_SIMR, ENETC_SIMR_EN);\n \n", "prefixes": [ "04/10" ] }