Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66098/?format=api
{ "id": 66098, "url": "http://patches.dpdk.org/api/patches/66098/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1582820317-7333-2-git-send-email-lbartosik@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1582820317-7333-2-git-send-email-lbartosik@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1582820317-7333-2-git-send-email-lbartosik@marvell.com", "date": "2020-02-27T16:18:23", "name": "[v5,01/15] examples/ipsec-secgw: add default rte flow for inline Rx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "278b2bc5b19507b411325a50eb07ecd9466f7292", "submitter": { "id": 1305, "url": "http://patches.dpdk.org/api/people/1305/?format=api", "name": "Lukas Bartosik [C]", "email": "lbartosik@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1582820317-7333-2-git-send-email-lbartosik@marvell.com/mbox/", "series": [ { "id": 8713, "url": "http://patches.dpdk.org/api/series/8713/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8713", "date": "2020-02-27T16:18:22", "name": "add eventmode to ipsec-secgw", "version": 5, "mbox": "http://patches.dpdk.org/series/8713/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66098/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66098/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 62536A055F;\n\tThu, 27 Feb 2020 17:18:53 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 29EED1BFCE;\n\tThu, 27 Feb 2020 17:18:51 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id B10611BFCE\n for <dev@dpdk.org>; Thu, 27 Feb 2020 17:18:48 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 01RFsgmk002482; Thu, 27 Feb 2020 08:18:48 -0800", "from sc-exch03.marvell.com ([199.233.58.183])\n by mx0b-0016f401.pphosted.com with ESMTP id 2ydchth8e5-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 27 Feb 2020 08:18:48 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Thu, 27 Feb 2020 08:18:46 -0800", "from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Thu, 27 Feb 2020 08:18:45 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Thu, 27 Feb 2020 08:18:44 -0800", "from luke.marvell.com (unknown [10.95.130.81])\n by maili.marvell.com (Postfix) with ESMTP id 29F5C3F703F;\n Thu, 27 Feb 2020 08:18:41 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0818; bh=YTc4kB5iqRTNjEC2mzHJndWQAkkGMeSuOnsLUAU4zXI=;\n b=ZjIojW56v+zSWeXjkx0ozVeYZS42XCza/+oMtlq4A7INd6RnKhE65nSVi6BXQK+/NZLh\n JtNkvjIDqfd/l5IF65f/+pLISvWnqF6ArZPspPMZNtX2cUB405V6u2fpjnCStNgjqtRo\n 5e0uIA5Cs+rhJo+iIlIc1oQ/dzXNOcBbPOuavJZOOwvaKiNzvfFx4aZ5vddsE+SmFj80\n v3p6rM7aGx2FzCViI8y2WvyxWeuulW04s+LpZzt563ATtNBybSJ+mcRgklsLZGTiqwvH\n Do4h486zSIzAfkaOuDDOh6FJX5qeRRQbe/F/c06d23DwzwP2alPS0PbgAmK5whQ0Y8OO 1w==", "From": "Lukasz Bartosik <lbartosik@marvell.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>, Radu Nicolau <radu.nicolau@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>", "CC": "Ankur Dwivedi <adwivedi@marvell.com>, Jerin Jacob <jerinj@marvell.com>,\n Narayana Prasad <pathreya@marvell.com>, Anoob Joseph <anoobj@marvell.com>,\n Archana Muniganti <marchana@marvell.com>, Tejasree Kondoj\n <ktejasree@marvell.com>, Vamsi Attunuru <vattunuru@marvell.com>,\n \"Konstantin Ananyev\" <konstantin.ananyev@intel.com>, <dev@dpdk.org>", "Date": "Thu, 27 Feb 2020 17:18:23 +0100", "Message-ID": "<1582820317-7333-2-git-send-email-lbartosik@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1582820317-7333-1-git-send-email-lbartosik@marvell.com>", "References": "<1582185727-6749-1-git-send-email-lbartosik@marvell.com>\n <1582820317-7333-1-git-send-email-lbartosik@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572\n definitions=2020-02-27_05:2020-02-26,\n 2020-02-27 signatures=0", "Subject": "[dpdk-dev] [PATCH v5 01/15] examples/ipsec-secgw: add default rte\n\tflow for inline Rx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ankur Dwivedi <adwivedi@marvell.com>\n\nThe default flow created would enable security processing on all ESP\npackets. If the default flow is created, SA based rte_flow creation\nwould be skipped.\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n examples/ipsec-secgw/ipsec-secgw.c | 61 +++++++++++++++++++++++++++++++++-----\n examples/ipsec-secgw/ipsec.c | 5 +++-\n examples/ipsec-secgw/ipsec.h | 6 ++++\n 3 files changed, 63 insertions(+), 9 deletions(-)", "diff": "diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex 4799bc9..e1ee7c3 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -129,6 +129,8 @@ struct ethaddr_info ethaddr_tbl[RTE_MAX_ETHPORTS] = {\n \t{ 0, ETHADDR(0x00, 0x16, 0x3e, 0x49, 0x9e, 0xdd) }\n };\n \n+struct flow_info flow_info_tbl[RTE_MAX_ETHPORTS];\n+\n #define CMD_LINE_OPT_CONFIG\t\t\"config\"\n #define CMD_LINE_OPT_SINGLE_SA\t\t\"single-sa\"\n #define CMD_LINE_OPT_CRYPTODEV_MASK\t\"cryptodev_mask\"\n@@ -2432,6 +2434,48 @@ reassemble_init(void)\n \treturn rc;\n }\n \n+static void\n+create_default_ipsec_flow(uint16_t port_id, uint64_t rx_offloads)\n+{\n+\tstruct rte_flow_action action[2];\n+\tstruct rte_flow_item pattern[2];\n+\tstruct rte_flow_attr attr = {0};\n+\tstruct rte_flow_error err;\n+\tstruct rte_flow *flow;\n+\tint ret;\n+\n+\tif (!(rx_offloads & DEV_RX_OFFLOAD_SECURITY))\n+\t\treturn;\n+\n+\t/* Add the default rte_flow to enable SECURITY for all ESP packets */\n+\n+\tpattern[0].type = RTE_FLOW_ITEM_TYPE_ESP;\n+\tpattern[0].spec = NULL;\n+\tpattern[0].mask = NULL;\n+\tpattern[0].last = NULL;\n+\tpattern[1].type = RTE_FLOW_ITEM_TYPE_END;\n+\n+\taction[0].type = RTE_FLOW_ACTION_TYPE_SECURITY;\n+\taction[0].conf = NULL;\n+\taction[1].type = RTE_FLOW_ACTION_TYPE_END;\n+\taction[1].conf = NULL;\n+\n+\tattr.ingress = 1;\n+\n+\tret = rte_flow_validate(port_id, &attr, pattern, action, &err);\n+\tif (ret)\n+\t\treturn;\n+\n+\tflow = rte_flow_create(port_id, &attr, pattern, action, &err);\n+\tif (flow == NULL)\n+\t\treturn;\n+\n+\tflow_info_tbl[port_id].rx_def_flow = flow;\n+\tRTE_LOG(INFO, IPSEC,\n+\t\t\"Created default flow enabling SECURITY for all ESP traffic on port %d\\n\",\n+\t\tport_id);\n+}\n+\n int32_t\n main(int32_t argc, char **argv)\n {\n@@ -2440,7 +2484,8 @@ main(int32_t argc, char **argv)\n \tuint32_t i;\n \tuint8_t socket_id;\n \tuint16_t portid;\n-\tuint64_t req_rx_offloads, req_tx_offloads;\n+\tuint64_t req_rx_offloads[RTE_MAX_ETHPORTS];\n+\tuint64_t req_tx_offloads[RTE_MAX_ETHPORTS];\n \tsize_t sess_sz;\n \n \t/* init EAL */\n@@ -2502,8 +2547,10 @@ main(int32_t argc, char **argv)\n \t\tif ((enabled_port_mask & (1 << portid)) == 0)\n \t\t\tcontinue;\n \n-\t\tsa_check_offloads(portid, &req_rx_offloads, &req_tx_offloads);\n-\t\tport_init(portid, req_rx_offloads, req_tx_offloads);\n+\t\tsa_check_offloads(portid, &req_rx_offloads[portid],\n+\t\t\t\t&req_tx_offloads[portid]);\n+\t\tport_init(portid, req_rx_offloads[portid],\n+\t\t\t\treq_tx_offloads[portid]);\n \t}\n \n \tcryptodevs_init();\n@@ -2513,11 +2560,9 @@ main(int32_t argc, char **argv)\n \t\tif ((enabled_port_mask & (1 << portid)) == 0)\n \t\t\tcontinue;\n \n-\t\t/*\n-\t\t * Start device\n-\t\t * note: device must be started before a flow rule\n-\t\t * can be installed.\n-\t\t */\n+\t\t/* Create flow before starting the device */\n+\t\tcreate_default_ipsec_flow(portid, req_rx_offloads[portid]);\n+\n \t\tret = rte_eth_dev_start(portid);\n \t\tif (ret < 0)\n \t\t\trte_exit(EXIT_FAILURE, \"rte_eth_dev_start: \"\ndiff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c\nindex 6e81207..d406571 100644\n--- a/examples/ipsec-secgw/ipsec.c\n+++ b/examples/ipsec-secgw/ipsec.c\n@@ -275,6 +275,10 @@ create_inline_session(struct socket_ctx *skt_ctx, struct ipsec_sa *sa,\n \t\t\tunsigned int i;\n \t\t\tunsigned int j;\n \n+\t\t\t/* Don't create flow if default flow is created */\n+\t\t\tif (flow_info_tbl[sa->portid].rx_def_flow)\n+\t\t\t\treturn 0;\n+\n \t\t\tret = rte_eth_dev_info_get(sa->portid, &dev_info);\n \t\t\tif (ret != 0) {\n \t\t\t\tRTE_LOG(ERR, IPSEC,\n@@ -410,7 +414,6 @@ create_inline_session(struct socket_ctx *skt_ctx, struct ipsec_sa *sa,\n \t\tips->security.ol_flags = sec_cap->ol_flags;\n \t\tips->security.ctx = sec_ctx;\n \t}\n-\tsa->cdev_id_qp = 0;\n \n \treturn 0;\n }\ndiff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h\nindex 4f2fd61..8f5d382 100644\n--- a/examples/ipsec-secgw/ipsec.h\n+++ b/examples/ipsec-secgw/ipsec.h\n@@ -87,6 +87,12 @@ struct app_sa_prm {\n \n extern struct app_sa_prm app_sa_prm;\n \n+struct flow_info {\n+\tstruct rte_flow *rx_def_flow;\n+};\n+\n+extern struct flow_info flow_info_tbl[RTE_MAX_ETHPORTS];\n+\n enum {\n \tIPSEC_SESSION_PRIMARY = 0,\n \tIPSEC_SESSION_FALLBACK = 1,\n", "prefixes": [ "v5", "01/15" ] }