Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66092/?format=api
{ "id": 66092, "url": "http://patches.dpdk.org/api/patches/66092/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200227141840.15835-4-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200227141840.15835-4-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200227141840.15835-4-i.dyukov@samsung.com", "date": "2020-02-27T14:16:15", "name": "[v5,3/4] net/virtio-user: fix devargs parsing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "547416f2a9fff7fbae63bbed51480344fdc4c1a3", "submitter": { "id": 783, "url": "http://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200227141840.15835-4-i.dyukov@samsung.com/mbox/", "series": [ { "id": 8709, "url": "http://patches.dpdk.org/api/series/8709/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8709", "date": "2020-02-27T14:16:12", "name": "net/virtio: add link speed devarg", "version": 5, "mbox": "http://patches.dpdk.org/series/8709/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66092/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66092/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5FB4AA055F;\n\tThu, 27 Feb 2020 15:20:44 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 70F961BFE0;\n\tThu, 27 Feb 2020 15:20:29 +0100 (CET)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id AB0A11F1C\n for <dev@dpdk.org>; Thu, 27 Feb 2020 15:20:25 +0100 (CET)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200227142025euoutp0216303342da9b187c5a107565a14ec9ed~3SD4VGG_D2263122631euoutp02G\n for <dev@dpdk.org>; Thu, 27 Feb 2020 14:20:25 +0000 (GMT)", "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200227142025eucas1p297cb80e014d7af0270579b52684d97c3~3SD38sDoR3188831888eucas1p2J;\n Thu, 27 Feb 2020 14:20:25 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges1new.samsung.com (EUCPMTA) with SMTP id 8F.C4.61286.920D75E5; Thu, 27\n Feb 2020 14:20:25 +0000 (GMT)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200227142024eucas1p1e356ee11b8eda65208682b1591e3cc00~3SD3t8CQZ2042620426eucas1p1H;\n Thu, 27 Feb 2020 14:20:24 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200227142024eusmtrp29273c2d3858ed5c96de872daa13c62a3~3SD3tb8h52816928169eusmtrp2J;\n Thu, 27 Feb 2020 14:20:24 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id 2D.89.08375.820D75E5; Thu, 27\n Feb 2020 14:20:24 +0000 (GMT)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n 20200227142024eusmtip2e65d0e25452ec7484951187cd482439b~3SD3Hayax0717507175eusmtip2_;\n Thu, 27 Feb 2020 14:20:24 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200227142025euoutp0216303342da9b187c5a107565a14ec9ed~3SD4VGG_D2263122631euoutp02G", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1582813225;\n bh=XZrkyRg2+Pz7PpyRdqYMptfy5QvNeuXSDMV/FIlv+bc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=g2HWHHnwDOwhc6zupI/wM3MgEqYRWKKceiIw9mDst0fcnXwLqJhD1DRnWf9fL7TnI\n 3gqMOKhFg+k+qMdXW5Inuy2A7udFGx1W0oETAcGb71UJN7GECd2uIOUlKhl/1oTCZn\n t7y0Fjlr9oLKCcoaX6oQXdMPewZ7XsOSjIz2hIpY=", "X-AuditID": "cbfec7f2-ef1ff7000001ef66-ad-5e57d029c4fe", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,\n amorenoz@redhat.com, zhihong.wang@intel.com, xiaolong.ye@intel.com", "Cc": "Ivan Dyukov <i.dyukov@samsung.com>", "Date": "Thu, 27 Feb 2020 17:16:15 +0300", "Message-Id": "<20200227141840.15835-4-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200227141840.15835-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWy7djPc7qaF8LjDNZvYbNo3fGAxeLdp+1M\n FrMuNbFbHOvcw2KxteE/k8WfN6YWmy9OYnJg9/i1YCmrx+I9L5k83u+7yubRt2UVYwBLFJdN\n SmpOZllqkb5dAlfGhDfnmQuecVQc2TCTvYFxJnsXIweHhICJxM7p9l2MnBxCAisYJS6+E4Gw\n vzBKzJ0n1cXIBWR/ZpR48v0KK0gCpL5x92VmiMRyRokFd7qYIJyvjBK3d89mA6liE9CQON0x\n DywhItDOKLFqSgsLSIJZQE3iQ897FpDVwgI2EheXeoCEWQRUJTZMXgG2gVfAUqLtyi4miG3y\n Eqs3HGAGsTkFrCTmt7xjBJkpIfCaTWLN58PsEEUuEgu7PzFC2MISr45vgYrLSPzfOR9qULXE\n 903X2SGaOxgl7i1qhSqyl9jy+hw4LJgFNCXW79KHCDtKbF57gRESRHwSN94KQpzPJzFp23Rm\n iDCvREebEES1ksSBk5egwhISf3/zQIQ9JD6/e8AKCZ7NjBJH/19jncAoPwth1wJGxlWM4qml\n xbnpqcWGeanlesWJucWleel6yfm5mxiBSeH0v+OfdjB+vZR0iFGAg1GJh3fBjvA4IdbEsuLK\n 3EOMEhzMSiK8G7+GxgnxpiRWVqUW5ccXleakFh9ilOZgURLnNV70MlZIID2xJDU7NbUgtQgm\n y8TBKdXA2FjmF1Ij3Nlj8rOWeUnVl3wvF2M+GQe9OblzLO3XXkz/dS1AIjRZtiZcyE8sI0PP\n cIJz3bd5AfmMDpeLa+80GRdtu6mSuGzv8r1Filuj1drmvL4nqa+pfKLhsOoZD1+e/gXxLGaP\n TaUvCHAtX9q7LOqmAss0q0+Jd1QbvJd5N+rvP3IlwVCJpTgj0VCLuag4EQA8dUucBgMAAA==", "\n H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsVy+t/xe7oaF8LjDPbO0rdo3fGAxeLdp+1M\n FrMuNbFbHOvcw2KxteE/k8WfN6YWmy9OYnJg9/i1YCmrx+I9L5k83u+7yubRt2UVYwBLlJ5N\n UX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1NSmpOZllqkb5dgl7GhDfnmQue\n cVQc2TCTvYFxJnsXIyeHhICJROPuy8xdjFwcQgJLGSWmLL8O5HAAJSQkXj9hhqgRlvhzrYsN\n ouYzo8SqhR/AEmwCGhKnO+YxgSREBPoZJTb++g2WYBZQk/jQ854FZJCwgI3ExaUeIGEWAVWJ\n DZNXsILYvAKWEm1XdjFBLJCXWL3hAFgrp4CVxPyWd4wgtpBAvMTH7+fZJzDyLWBkWMUoklpa\n nJueW2yoV5yYW1yal66XnJ+7iREYqNuO/dy8g/HSxuBDjAIcjEo8vAt2hMcJsSaWFVfmHmKU\n 4GBWEuHd+DU0Tog3JbGyKrUoP76oNCe1+BCjKdBRE5mlRJPzgVGUVxJvaGpobmFpaG5sbmxm\n oSTO2yFwMEZIID2xJDU7NbUgtQimj4mDU6qBcdLJe7JdZTNrHT77riwXkVQPLikx2CESY3Rs\n SoXXN4Pp1+VianrvS97nEbgi9iQ/xu/X76JdystLTn/ZKtVWaVv4TIL9ZGqD2As3mbL4xU6T\n 1h89xMh48Hbjrb/Vj/Uv/l7Ee83Ce0rmzMl7D536KHgzSuxNVrNDvq/Fsbs/tq19K8O5/lyB\n qhJLcUaioRZzUXEiAH+OvCBqAgAA" ], "X-CMS-MailID": "20200227142024eucas1p1e356ee11b8eda65208682b1591e3cc00", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200227142024eucas1p1e356ee11b8eda65208682b1591e3cc00", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200227142024eucas1p1e356ee11b8eda65208682b1591e3cc00", "References": "<20200226075503.GA108150@intel.com>\n <20200227141840.15835-1-i.dyukov@samsung.com>\n <CGME20200227142024eucas1p1e356ee11b8eda65208682b1591e3cc00@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v5 3/4] net/virtio-user: fix devargs parsing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "strtoull returns 0 if it fails to parse input string. It's ignored\nin get_integer_arg.\n\nThis patch handles error cases for strtoull function.\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n drivers/net/virtio/virtio_user_ethdev.c | 13 +++++++++----\n 1 file changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 3fc172573..074527714 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -433,12 +433,17 @@ static int\n get_integer_arg(const char *key __rte_unused,\n \t\tconst char *value, void *extra_args)\n {\n+\tuint64_t integer = 0;\n \tif (!value || !extra_args)\n \t\treturn -EINVAL;\n-\n-\t*(uint64_t *)extra_args = strtoull(value, NULL, 0);\n-\n-\treturn 0;\n+\terrno = 0;\n+\tinteger = strtoull(value, NULL, 0);\n+\t/* extra_args keeps default value, it should be replaced\n+\t * only in case of successful parsing of the 'value' arg\n+\t */\n+\tif (errno == 0)\n+\t\t*(uint64_t *)extra_args = integer;\n+\treturn -errno;\n }\n \n static struct rte_eth_dev *\n", "prefixes": [ "v5", "3/4" ] }