Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66090/?format=api
{ "id": 66090, "url": "http://patches.dpdk.org/api/patches/66090/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200227141840.15835-2-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200227141840.15835-2-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200227141840.15835-2-i.dyukov@samsung.com", "date": "2020-02-27T14:16:13", "name": "[v5,1/4] net/virtio: refactor devargs parsing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "38db5802d487f081621b9a37faf98cfe812c1b74", "submitter": { "id": 783, "url": "http://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200227141840.15835-2-i.dyukov@samsung.com/mbox/", "series": [ { "id": 8709, "url": "http://patches.dpdk.org/api/series/8709/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8709", "date": "2020-02-27T14:16:12", "name": "net/virtio: add link speed devarg", "version": 5, "mbox": "http://patches.dpdk.org/series/8709/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66090/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66090/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 76FF5A055F;\n\tThu, 27 Feb 2020 15:20:21 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 51ACD1BFCC;\n\tThu, 27 Feb 2020 15:20:21 +0100 (CET)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 9D7FB1F1C\n for <dev@dpdk.org>; Thu, 27 Feb 2020 15:20:19 +0100 (CET)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200227142019euoutp01c064624e03148adabd545f726937787b~3SDyT8war1458814588euoutp01P\n for <dev@dpdk.org>; Thu, 27 Feb 2020 14:20:19 +0000 (GMT)", "from eusmges3new.samsung.com (unknown [203.254.199.245]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200227142018eucas1p278922e489e4bd5bb14cd77dfac6f3784~3SDyGiSLQ1636516365eucas1p2M;\n Thu, 27 Feb 2020 14:20:18 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges3new.samsung.com (EUCPMTA) with SMTP id 56.2B.60698.220D75E5; Thu, 27\n Feb 2020 14:20:18 +0000 (GMT)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200227142018eucas1p1fd60eac2a28295736ee07a3730cb5a53~3SDxdI2IW1839018390eucas1p1G;\n Thu, 27 Feb 2020 14:20:18 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200227142018eusmtrp25fc6bd582d8db1b3429a86727474812a~3SDxbWuEQ2814228142eusmtrp2N;\n Thu, 27 Feb 2020 14:20:18 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 20.69.07950.220D75E5; Thu, 27\n Feb 2020 14:20:18 +0000 (GMT)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n 20200227142017eusmtip2335c0f8668d76194d1d24c72fec2587f~3SDw8JZGN0759407594eusmtip22;\n Thu, 27 Feb 2020 14:20:17 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200227142019euoutp01c064624e03148adabd545f726937787b~3SDyT8war1458814588euoutp01P", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1582813219;\n bh=RQMv9cuuvP5u8e0+uNl+O6QooxHPW/YCpJsvHBfzTqw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Bc/WmQkuolL1BnOSqT4Vf65AWBSQ61+i/1HG0hAPIxPGPzdMiEqdLpRFmAj0+G/+6\n OEN0Y6fphELAhw1fTwTRAAyxwmPlA11I8DQC//8auDjWyoCK2BMwJii6/A7Jp/P6Pu\n xN2MBy/3JUfP67ReiUzkkG1B/KMmmH6e3RuDovFI=", "X-AuditID": "cbfec7f5-a0fff7000001ed1a-5e-5e57d022aae8", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,\n amorenoz@redhat.com, zhihong.wang@intel.com, xiaolong.ye@intel.com", "Cc": "Ivan Dyukov <i.dyukov@samsung.com>", "Date": "Thu, 27 Feb 2020 17:16:13 +0300", "Message-Id": "<20200227141840.15835-2-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200227141840.15835-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsWy7djP87pKF8LjDL6t0bNo3fGAxeLdp+1M\n FrMuNbFbHOvcw2KxteE/k8WfN6YWmy9OYnJg9/i1YCmrx+I9L5k83u+7yubRt2UVYwBLFJdN\n SmpOZllqkb5dAlfG8k8T2QuWC1Z8n/GMsYGxka+LkZNDQsBE4k7PNLYuRi4OIYEVjBJ9Gyaz\n QzhfGCXedG2Gcj4zSlxc+ZkRpmXLjrlMEInljBKLLy5mgXC+Mkr8O3abCaSKTUBD4nTHPLAq\n EYF2RolVU1pYQBLMAmoSH3reg9nCAjYSh54vALNZBFQllp59wwZi8wpYSrT++csMsU5eYvWG\n A2A2p4CVxPyWd4wgQyUEnrNJPP6yFqiZA8hxkXh/OBSiXlji1fEt7BC2jMT/nfOZIOxqie+b\n rrND9HYwStxb1ApVZC+x5fU5dpA5zAKaEut36UOEHSWmnNjNCDGeT+LGW0GI8/kkJm2bzgwR\n 5pXoaBOCqFaSOHDyElRYQuLvbx6IsIfE8qWN0LDazCjR0fOZfQKj/CyEXQsYGVcxiqeWFuem\n pxYb56WW6xUn5haX5qXrJefnbmIEpobT/45/3cG470/SIUYBDkYlHt4FO8LjhFgTy4orcw8x\n SnAwK4nwbvwaGifEm5JYWZValB9fVJqTWnyIUZqDRUmc13jRy1ghgfTEktTs1NSC1CKYLBMH\n p1QDo51Jk9Q2y9rnn23PLO7wFmHoMWHZ83BJYdeW9fE3eVPzamM/hn0qLAtelfGQL4Ht5nKT\n zCdzLjRN36zerX9f8km1LIvdIdVCi1Ym48myVc5m3RMm9Dmue71h+TPH5dc2FKgrT9jS4ysd\n /c9hzp13pbPFTv5cct/1SX2+4+Teeub7bacfT/ZJUmIpzkg01GIuKk4EAJEAAvsJAwAA", "\n H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsVy+t/xe7pKF8LjDL5tZbNo3fGAxeLdp+1M\n FrMuNbFbHOvcw2KxteE/k8WfN6YWmy9OYnJg9/i1YCmrx+I9L5k83u+7yubRt2UVYwBLlJ5N\n UX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1NSmpOZllqkb5dgl7G8k8T2QuW\n C1Z8n/GMsYGxka+LkZNDQsBEYsuOuUxdjFwcQgJLGSWONF1j7GLkAEpISLx+wgxRIyzx51oX\n G4gtJPCZUaLnuxCIzSagIXG6Yx5Yr4hAP6PExl+/wRqYBdQkPvS8ZwGxhQVsJA49XwBmswio\n Siw9+wZsEK+ApUTrn79QC+QlVm84AGZzClhJzG95xwixLF7i4/fz7BMY+RYwMqxiFEktLc5N\n zy020itOzC0uzUvXS87P3cQIDNRtx35u2cHY9S74EKMAB6MSD6/HtvA4IdbEsuLK3EOMEhzM\n SiK8G7+GxgnxpiRWVqUW5ccXleakFh9iNAU6aiKzlGhyPjCK8kriDU0NzS0sDc2NzY3NLJTE\n eTsEDsYICaQnlqRmp6YWpBbB9DFxcEo1MKqE+rrOStrcXrWJWVleuLr8v/QGzkUPlLnnfZ4T\n /sd+nlbR79oZvhF/c/4v4nu9x/xG4IM3x3sWLWoV2/LtrL/E34WznL1NOybe9hdfGtwx6Vsf\n j67pTAWjHLulec/cXp553uh793CoQr2IHMOH92UrFkn9V7gedGF7o5r8Z0fBQkFHlc5IDiWW\n 4oxEQy3mouJEAI9vofZqAgAA" ], "X-CMS-MailID": "20200227142018eucas1p1fd60eac2a28295736ee07a3730cb5a53", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200227142018eucas1p1fd60eac2a28295736ee07a3730cb5a53", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200227142018eucas1p1fd60eac2a28295736ee07a3730cb5a53", "References": "<20200226075503.GA108150@intel.com>\n <20200227141840.15835-1-i.dyukov@samsung.com>\n <CGME20200227142018eucas1p1fd60eac2a28295736ee07a3730cb5a53@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v5 1/4] net/virtio: refactor devargs parsing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "refactor vdpa specific devargs parsing to more generic way\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 34 +++++++++++++++++++++---------\n 1 file changed, 24 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 044eb10a7..d2c7f8c61 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1955,16 +1955,18 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)\n }\n \n static int vdpa_check_handler(__rte_unused const char *key,\n-\t\tconst char *value, __rte_unused void *opaque)\n+\t\tconst char *value, void *ret_val)\n {\n-\tif (strcmp(value, \"1\"))\n-\t\treturn -1;\n+\tif (strcmp(value, \"1\") == 0)\n+\t\t*(int *)ret_val = 1;\n+\telse\n+\t\t*(int *)ret_val = 0;\n \n \treturn 0;\n }\n \n static int\n-vdpa_mode_selected(struct rte_devargs *devargs)\n+virtio_dev_devargs_parse(struct rte_devargs *devargs, int *vdpa)\n {\n \tstruct rte_kvargs *kvlist;\n \tconst char *key = \"vdpa\";\n@@ -1980,12 +1982,16 @@ vdpa_mode_selected(struct rte_devargs *devargs)\n \tif (!rte_kvargs_count(kvlist, key))\n \t\tgoto exit;\n \n-\t/* vdpa mode selected when there's a key-value pair: vdpa=1 */\n-\tif (rte_kvargs_process(kvlist, key,\n-\t\t\t\tvdpa_check_handler, NULL) < 0) {\n-\t\tgoto exit;\n+\tif (vdpa) {\n+\t\t/* vdpa mode selected when there's a key-value pair:\n+\t\t * vdpa=1\n+\t\t */\n+\t\tret = rte_kvargs_process(kvlist, key,\n+\t\t\t\tvdpa_check_handler, vdpa);\n+\t\tif (ret < 0)\n+\t\t\tgoto exit;\n \t}\n-\tret = 1;\n+\n \n exit:\n \trte_kvargs_free(kvlist);\n@@ -1995,8 +2001,16 @@ vdpa_mode_selected(struct rte_devargs *devargs)\n static int eth_virtio_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tstruct rte_pci_device *pci_dev)\n {\n+\tint vdpa = 0;\n+\tint ret = 0;\n+\n+\tret = virtio_dev_devargs_parse(pci_dev->device.devargs, &vdpa);\n+\tif (ret < 0) {\n+\t\tPMD_INIG_LOG(ERR, \"devargs parsing is failed\");\n+\t\treturn ret;\n+\t}\n \t/* virtio pmd skips probe if device needs to work in vdpa mode */\n-\tif (vdpa_mode_selected(pci_dev->device.devargs))\n+\tif (vdpa == 1)\n \t\treturn 1;\n \n \treturn rte_eth_dev_pci_generic_probe(pci_dev, sizeof(struct virtio_hw),\n", "prefixes": [ "v5", "1/4" ] }