Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66064/?format=api
{ "id": 66064, "url": "http://patches.dpdk.org/api/patches/66064/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200227042537.187459-5-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200227042537.187459-5-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200227042537.187459-5-dmitry.kozliuk@gmail.com", "date": "2020-02-27T04:25:34", "name": "[v4,4/7] build: MinGW-w64 support for Meson", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "412c647f68907f529106e691cfce3265a17edd21", "submitter": { "id": 1581, "url": "http://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200227042537.187459-5-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 8703, "url": "http://patches.dpdk.org/api/series/8703/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8703", "date": "2020-02-27T04:25:30", "name": "MinGW-w64 support", "version": 4, "mbox": "http://patches.dpdk.org/series/8703/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66064/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66064/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C2F8FA055A;\n\tThu, 27 Feb 2020 05:26:23 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4768C1BFE8;\n\tThu, 27 Feb 2020 05:25:58 +0100 (CET)", "from mail-lf1-f66.google.com (mail-lf1-f66.google.com\n [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id 71ADD1BFD6\n for <dev@dpdk.org>; Thu, 27 Feb 2020 05:25:53 +0100 (CET)", "by mail-lf1-f66.google.com with SMTP id c23so999118lfi.7\n for <dev@dpdk.org>; Wed, 26 Feb 2020 20:25:53 -0800 (PST)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.googlemail.com with ESMTPSA id g21sm2224350ljj.53.2020.02.26.20.25.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 26 Feb 2020 20:25:52 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=An531CZfw5v7EAWPyeoYtqp8eSOb3MpKSS0kBWke2Rk=;\n b=bCjTmGTLEv21ekizwOi0ya+jsyhufOzWNNG62m/edgC1BowS/mF2MpF3MGAyfAitxy\n 99erb8m869SFiAUqeG69UtNbXwPNSofIL0mfdN+iG5v+nW1amQD/rp2mKgzZ2cS18xSJ\n ZdFvhIpCIz7b5VyCKxBPy+8tyLbuEUVrpZrDoFjZ5DTYIvZyzL0zBXannvOEnCBoPtyl\n BCekFu5AM5wXv0I0ucpnxmF3T++BU61WjZf5Nky2Z5oHYxQh7qJLTR/WnLBrRf6CEBZh\n sROcMy7WjF0yKpEKBU045V+XBUMlHai1odjtBq00lvEQDLl3a8t/7Tbg5TQyJ+rSO0u6\n GcsA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=An531CZfw5v7EAWPyeoYtqp8eSOb3MpKSS0kBWke2Rk=;\n b=bA15aCzTiB2w58cLGc07Iob+BnMcW9ZrNgrwj0UyxY5QVxu6Ee3GN/SVGBOBf+TtlM\n 3gJnM26ERHBWruH93unvk9K8EOaJRLKUH6Uc2EgFMrYfViA8VZwtGJtmCbyWtZjjYPKo\n xMLo8iQpCcHa/XCRkNZ7/0I+kA0oH1WOuJcrLo4ymyEVrrEmwRCP/nGI8/mSy6rDue1j\n 702/TBNxDPbzLq11cNDjsTEHqNxE1mG5pL1+Hy5kAsxKjQ5QHQg25QQPhTylrWZPQluf\n UImiVYsWnFmsDKPsesbC7BzRSFMAfUPkDSdi19ybfbMU91odT5YobNCOi1r9UmU5GjwK\n dDCg==", "X-Gm-Message-State": "ANhLgQ1XTCAd88sbv0a2qM1Lq1BcLmHUS7ZXum1NBrTXdQnVdWdU5rxW\n V3RA1FrP/DuHffO6K7JpobltkT0Xin8=", "X-Google-Smtp-Source": "\n ADFU+vv1+k3/Zum36Xph7+q7i9kaPfEeGaxApojvKP6eAn0LPLEzREREf7yUKNnBlj8yRj7etjr17A==", "X-Received": "by 2002:a05:6512:104a:: with SMTP id\n c10mr1028198lfb.57.1582777552654;\n Wed, 26 Feb 2020 20:25:52 -0800 (PST)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Thomas Monjalon <thomas@monjalon.net>", "Date": "Thu, 27 Feb 2020 07:25:34 +0300", "Message-Id": "<20200227042537.187459-5-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200227042537.187459-1-dmitry.kozliuk@gmail.com>", "References": "<20200218000229.86621-1-dmitry.kozliuk@gmail.com>\n <20200227042537.187459-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 4/7] build: MinGW-w64 support for Meson", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "MinGW-w64 linker does not mimic MS linker options, so the build system\nmust differentiate between linkers on Windows. Use GNU linker options\nwith GCC and MS linker options with Clang.\n\nMinGW-w64 by default uses MSVCRT stdio, which does not comply to ANSI,\nmost notably its formatting and string handling functions. MinGW-w64\nsupport for the Universal CRT (UCRT) is ongoing, but the toolchain\nprovides its own standard-complying implementation of stdio. The latter\nis used in the patch to support formatting in DPDK.\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n config/meson.build | 14 ++++++++++++++\n lib/meson.build | 8 ++++++--\n 2 files changed, 20 insertions(+), 2 deletions(-)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex d3d2370ce..68aeb8470 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -14,6 +14,10 @@ foreach env:supported_exec_envs\n \tset_variable('is_' + env, exec_env == env)\n endforeach\n \n+# MS linker requires special treatment.\n+# TODO: use cc.get_linker_id() with Meson >= 0.54\n+is_ms_linker = is_windows and (cc.get_id() == 'clang')\n+\n # set the major version, which might be used by drivers and libraries\n # depending on the configuration options\n pver = meson.project_version().split('.')\n@@ -247,6 +251,16 @@ if is_freebsd\n \tadd_project_arguments('-D__BSD_VISIBLE', language: 'c')\n endif\n \n+if is_windows\n+\t# Minimum supported API is Windows 7.\n+\tadd_project_arguments('-D_WIN32_WINNT=0x0601', language: 'c')\n+\n+\t# Use MinGW-w64 stdio, because DPDK assumes ANSI-compliant formatting.\n+\tif cc.get_id() == 'gcc'\n+\t\tadd_project_arguments('-D__USE_MINGW_ANSI_STDIO', language: 'c')\n+\tendif\n+endif\n+\n if get_option('b_lto')\n \tif cc.has_argument('-ffat-lto-objects')\n \t\tadd_project_arguments('-ffat-lto-objects', language: 'c')\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 0af3efab2..9c3cc55d5 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -148,12 +148,16 @@ foreach l:libraries\n \t\t\t\tcommand: [map_to_def_cmd, '@INPUT@', '@OUTPUT@'],\n \t\t\t\tinput: version_map,\n \t\t\t\toutput: 'rte_@0@_exports.def'.format(name))\n-\t\t\tlk_deps = [version_map, def_file]\n-\t\t\tif is_windows\n+\n+\t\t\tif is_ms_linker\n \t\t\t\tlk_args = ['-Wl,/def:' + def_file.full_path(),\n \t\t\t\t\t'-Wl,/implib:lib\\\\' + implib]\n \t\t\telse\n \t\t\t\tlk_args = ['-Wl,--version-script=' + version_map]\n+\t\t\tendif\n+\n+\t\t\tlk_deps = [version_map, def_file]\n+\t\t\tif not is_windows\n \t\t\t\t# on unix systems check the output of the\n \t\t\t\t# experimental syms script, using it as a\n \t\t\t\t# dependency of the .so build\n", "prefixes": [ "v4", "4/7" ] }