Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65934/?format=api
{ "id": 65934, "url": "http://patches.dpdk.org/api/patches/65934/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200220041214.18053-3-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200220041214.18053-3-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200220041214.18053-3-kalesh-anakkur.purayil@broadcom.com", "date": "2020-02-20T04:12:14", "name": "[2/2] net/bnxt: fix race when port is stopped and async events are received", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ffe202988b35a3083535ec7f806f9f6b7ea962a8", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200220041214.18053-3-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 8623, "url": "http://patches.dpdk.org/api/series/8623/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8623", "date": "2020-02-20T04:12:13", "name": "bnxt bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/8623/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65934/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65934/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 05288A0555;\n\tThu, 20 Feb 2020 04:55:41 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 83FA81BF9D;\n\tThu, 20 Feb 2020 04:55:31 +0100 (CET)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 724B71BF7D\n for <dev@dpdk.org>; Thu, 20 Feb 2020 04:55:26 +0100 (CET)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 9C6D3290C93;\n Wed, 19 Feb 2020 19:55:25 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 9C6D3290C93", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1582170925;\n bh=/xsfRnxnhU1R913zslPFpqUm5bFbF6LZMkaFz/vqvtY=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ss6xgbnQuURwzDnFQTNUF2AIvGHWE+HUz4stGe1RQClG+6zu56ZUqCzAAm42tUTgN\n nWCFV5Kh2w7bBY5+70YJtILIS1sASxjNf2e8stIhGWRXARHtrMKmRlIyORtrN5fDR/\n RFFO5+qMYWoelx8ZpluACya8q4yWEHK8XWUI0KSc=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Thu, 20 Feb 2020 09:42:14 +0530", "Message-Id": "<20200220041214.18053-3-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20200220041214.18053-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20200220041214.18053-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 2/2] net/bnxt: fix race when port is stopped and\n\tasync events are received", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nFix a race condition between port stop and error recovery task. When io\nforwarding is not started on Stingray devices, driver will not receive\nthe async event from FW when there is a FW reset. While exiting testpmd,\nas part of port stop driver sees this event and this in turn causes a\nrace between port stop and error recovery task.\n\nFixed this by ignoring the fatal/non-fatal async event from FW while\nstopping port.\n\nFixes: df6cd7c1f73a (\"net/bnxt: handle reset notify async event from FW\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_cpr.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex 0f7b5e9..21565b1 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -76,6 +76,12 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \t\tPMD_DRV_LOG(INFO, \"Port conn async event\\n\");\n \t\tbreak;\n \tcase HWRM_ASYNC_EVENT_CMPL_EVENT_ID_RESET_NOTIFY:\n+\t\t/* Ignore reset notify async events when stopping the port */\n+\t\tif (!bp->eth_dev->data->dev_started) {\n+\t\t\tbp->flags |= BNXT_FLAG_FATAL_ERROR;\n+\t\t\treturn;\n+\t\t}\n+\n \t\tevent_data = rte_le_to_cpu_32(async_cmp->event_data1);\n \t\t/* timestamp_lo/hi values are in units of 100ms */\n \t\tbp->fw_reset_max_msecs = async_cmp->timestamp_hi ?\n", "prefixes": [ "2/2" ] }