Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65932/?format=api
{ "id": 65932, "url": "http://patches.dpdk.org/api/patches/65932/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200220041214.18053-2-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200220041214.18053-2-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200220041214.18053-2-kalesh-anakkur.purayil@broadcom.com", "date": "2020-02-20T04:12:13", "name": "[1/2] net/bnxt: fix segmentation fault handling async events on port stop", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "eca480aa4d554e6b9214c2a8c6405c3b46ec94c9", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200220041214.18053-2-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 8623, "url": "http://patches.dpdk.org/api/series/8623/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8623", "date": "2020-02-20T04:12:13", "name": "bnxt bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/8623/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65932/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65932/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 75ABAA0555;\n\tThu, 20 Feb 2020 04:55:27 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 46F361BF78;\n\tThu, 20 Feb 2020 04:55:27 +0100 (CET)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 2E6463B5\n for <dev@dpdk.org>; Thu, 20 Feb 2020 04:55:26 +0100 (CET)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 48749290C84;\n Wed, 19 Feb 2020 19:55:25 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 48749290C84", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1582170925;\n bh=xDdKSwY7amncvqYYHCKSWAZqeBAbqaORLqcxy/8XFCo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=tI3hHx+joUCg44GX4w2wTlIDM0vm7PpUqHKXUacKtmyWUUQ8kBtzWbtTuJjxddlUQ\n HuKEpvfUERaLHfDrznVUHDHqsCJSTejWEZoMj53xS35Ak4dBIzcRTxEGlz7X05CF1a\n 5VHihdEZtEzY+vr2Ag03yc22i2CXH1Qe2uocTSFo=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Thu, 20 Feb 2020 09:42:13 +0530", "Message-Id": "<20200220041214.18053-2-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20200220041214.18053-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20200220041214.18053-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 1/2] net/bnxt: fix segmentation fault handling\n\tasync events on port stop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nCheck for bp->hwrm_cmd_resp_addr before using it in HWRM_PREP to avoid\nsegmentation fault when stop port and meanwhile receive events from FW.\n\nFixes: df6cd7c1f73a (\"net/bnxt: handle reset notify async event from FW\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_hwrm.c | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex acecf27..a9c9c72 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -184,6 +184,10 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,\n */\n #define HWRM_PREP(req, type, kong) do { \\\n \trte_spinlock_lock(&bp->hwrm_lock); \\\n+\tif (bp->hwrm_cmd_resp_addr == NULL) { \\\n+\t\trte_spinlock_unlock(&bp->hwrm_lock); \\\n+\t\treturn -EACCES; \\\n+\t} \\\n \tmemset(bp->hwrm_cmd_resp_addr, 0, bp->max_resp_len); \\\n \treq.req_type = rte_cpu_to_le_16(HWRM_##type); \\\n \treq.cmpl_ring = rte_cpu_to_le_16(-1); \\\n@@ -3096,9 +3100,9 @@ static void add_random_mac_if_needed(struct bnxt *bp,\n \t}\n }\n \n-static void reserve_resources_from_vf(struct bnxt *bp,\n-\t\t\t\t struct hwrm_func_cfg_input *cfg_req,\n-\t\t\t\t int vf)\n+static int reserve_resources_from_vf(struct bnxt *bp,\n+\t\t\t\t struct hwrm_func_cfg_input *cfg_req,\n+\t\t\t\t int vf)\n {\n \tstruct hwrm_func_qcaps_input req = {0};\n \tstruct hwrm_func_qcaps_output *resp = bp->hwrm_cmd_resp_addr;\n@@ -3132,6 +3136,8 @@ static void reserve_resources_from_vf(struct bnxt *bp,\n \tbp->max_ring_grps -= rte_le_to_cpu_16(resp->max_hw_ring_grps);\n \n \tHWRM_UNLOCK();\n+\n+\treturn 0;\n }\n \n int bnxt_hwrm_func_qcfg_current_vf_vlan(struct bnxt *bp, int vf)\n", "prefixes": [ "1/2" ] }