Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65877/?format=api
{ "id": 65877, "url": "http://patches.dpdk.org/api/patches/65877/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200218172240.558516-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200218172240.558516-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200218172240.558516-3-maxime.coquelin@redhat.com", "date": "2020-02-18T17:22:40", "name": "[2/2] net/vhost: prevent multiple setup on reconfig", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b560f425f76060c0734f532f4b107d91e294cbae", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200218172240.558516-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 8590, "url": "http://patches.dpdk.org/api/series/8590/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8590", "date": "2020-02-18T17:22:38", "name": "Fix Vhost PMD setup", "version": 1, "mbox": "http://patches.dpdk.org/series/8590/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65877/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65877/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7562BA054F;\n\tTue, 18 Feb 2020 18:24:22 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6E3E11C013;\n\tTue, 18 Feb 2020 18:24:12 +0100 (CET)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 505381C012\n for <dev@dpdk.org>; Tue, 18 Feb 2020 18:24:10 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-50-YdhuBYybMd2RwV8IQgMLjw-1; Tue, 18 Feb 2020 12:24:06 -0500", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com\n [10.5.11.15])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E45F5B3DA2;\n Tue, 18 Feb 2020 17:24:04 +0000 (UTC)", "from localhost.localdomain (ovpn-112-45.ams2.redhat.com\n [10.36.112.45])\n by smtp.corp.redhat.com (Postfix) with ESMTP id D2F355C13B;\n Tue, 18 Feb 2020 17:24:02 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1582046649;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=wSG2YArNm9HGkcJLaaZojZt6cvQWopfXkmiEHCqgu1s=;\n b=KnwtfarXzrvGlt06B9LEiziElqUJMeK+x7PIyWuI7dsiZPA/9BjNsZvJju2dKMCZ922C9b\n dnD5z8dmXa9pA4WhRQG/jDdBK0/45pE4eYhHjXuvAons4boZnbbh+bHeTaT4HVaF7VO72r\n C1mpY6xDuTt9USGynwg6/WxJBmZumhs=", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, oda@valinux.co.jp, yinan.wang@intel.com,\n tiwei.bie@intel.com,\n amorenoz@redhat.com, david.marchand@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 18 Feb 2020 18:22:40 +0100", "Message-Id": "<20200218172240.558516-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20200218172240.558516-1-maxime.coquelin@redhat.com>", "References": "<20200218172240.558516-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-MC-Unique": "YdhuBYybMd2RwV8IQgMLjw-1", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH 2/2] net/vhost: prevent multiple setup on reconfig", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Ethdev's .dev_configure callback can be called multiple\ntime during a device life-time, but Vhost makes the\nwrong assumption that it is not the case and try to\nsetup again the device on reconfiguration.\n\nThis patch ensures the device hasn't been already setup\nbefore proceeding.\n\nFixes: 3d01b759d267 (\"net/vhost: delay driver setup\")\n\nReported-by: Yinan Wang <yinan.wang@intel.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nTested-by: Yinan Wang <yinan.wang@intel.com>\nReviewed-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/vhost/rte_eth_vhost.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex 4a7b1b608c..458ed58f5f 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -876,6 +876,11 @@ vhost_driver_setup(struct rte_eth_dev *eth_dev)\n \tunsigned int numa_node = eth_dev->device->numa_node;\n \tconst char *name = eth_dev->device->name;\n \n+\t/* Don't try to setup again if it has already been done. */\n+\tlist = find_internal_resource(internal->iface_name);\n+\tif (list)\n+\t\treturn 0;\n+\n \tlist = rte_zmalloc_socket(name, sizeof(*list), 0, numa_node);\n \tif (list == NULL)\n \t\treturn -1;\n", "prefixes": [ "2/2" ] }