Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65798/?format=api
{ "id": 65798, "url": "http://patches.dpdk.org/api/patches/65798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200213155226.1024939-2-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200213155226.1024939-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200213155226.1024939-2-thomas@monjalon.net", "date": "2020-02-13T15:52:25", "name": "[1/2] app/testpmd: rename function for detaching by devargs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a8525ab2abb74a4dc1ac7eef3eca73dd5b7464d4", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200213155226.1024939-2-thomas@monjalon.net/mbox/", "series": [ { "id": 8529, "url": "http://patches.dpdk.org/api/series/8529/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8529", "date": "2020-02-13T15:52:24", "name": "app/testpmd: fix detach", "version": 1, "mbox": "http://patches.dpdk.org/series/8529/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65798/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65798/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 95E77A0542;\n\tThu, 13 Feb 2020 16:52:44 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DF2DE1C06A;\n\tThu, 13 Feb 2020 16:52:35 +0100 (CET)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D60641C02A\n for <dev@dpdk.org>; Thu, 13 Feb 2020 16:52:33 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id 496CE21FA7;\n Thu, 13 Feb 2020 10:52:33 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute1.internal (MEProxy); Thu, 13 Feb 2020 10:52:33 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 307B13280068;\n Thu, 13 Feb 2020 10:52:32 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=xT8Gh7buxU\n NOhGItzCqaXihZDGiRYwBFPp2uQ6X/wHw=; b=OTulP0yAWVNUkTkL7sy4MRMPOQ\n M7d0n1rHeRBRMMCmprimuoUTm+upvhKaQTFbaiQ1NXkNcaSoWCRrIK6/MAOEUC4I\n S2H449JKoRJcwAS0J56sWq0H1ladwUenmXJq2UPaG2a1D3NEHRKxwIX8+xWEVwSa\n RLJZmleH+mMRkst3E=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=xT8Gh7buxUNOhGItzCqaXihZDGiRYwBFPp2uQ6X/wHw=; b=OBWQrmJw\n LFdEg3VOTKgyG5kHUSzxGsYTt1+fKUEEjt1xXhyfvJQLk7HaLp7Dkdq730PAmPCf\n 73PvsqJHo8TS3GPxT5cdheegvlAge0IHPbyeJ7p7eVUVkWb1oc+/xVHVSi5wHQQo\n LmpnuMT52UD4N9/IfkgdPHM7oTOJtK4yOd67O9zGibLsI1hzLK4vVg0hXgqU5Uxa\n 64kkHnCJzL6GbKfo2gfvgcFL/bvC9jx6wCMsly++TACbSWFjItj0lec+uZ86veaU\n wq7HAiPMb1EfvWghAwIxXysad16PpfDFDKqpzpCl6P+2iZKqzCU1P5YiQheNGdT5\n 9Dkten5+YVAU0A==" ], "X-ME-Sender": "<xms:wHBFXmZe9y13KnCvE4Hp9qRPjGhywEbxQNGsThQJU8-lw71z1q0D-Q>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedugedrieekgdekvdcutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr\n rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:wXBFXtpxJRkds63L2g9m-4WVnxkdnZbbzisYl7cosyDCKboyKXRrbg>\n <xmx:wXBFXkhJhFwvH44z4CppPvLxcH74eAm68xqKk6eS41Ty9tn_xwpG0Q>\n <xmx:wXBFXnz0tZSaGwJeLxXq7x-XyHNoJt9WeXSYD9DIz5npHRyKObFksQ>\n <xmx:wXBFXjpqZh-cWlRjLFpO8MUfxGUlkQ8ipLLzpWcRs3TXAeEPBTLNuA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "matan@mellanox.com, ferruh.yigit@intel.com,\n Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Bernard Iremonger <bernard.iremonger@intel.com>", "Date": "Thu, 13 Feb 2020 16:52:25 +0100", "Message-Id": "<20200213155226.1024939-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200213155226.1024939-1-thomas@monjalon.net>", "References": "<20200213155226.1024939-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] app/testpmd: rename function for detaching\n\tby devargs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is a function detach_port_device() which takes a port_id,\nand a function detach_device() which takes a devargs string.\nIn order to add a third function accepting a rte_device pointer,\nthe function detach_device() is renamed into detach_devargs().\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n app/test-pmd/cmdline.c | 2 +-\n app/test-pmd/testpmd.c | 3 ++-\n app/test-pmd/testpmd.h | 2 +-\n 3 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 99e4168103..38b6d804c6 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -1541,7 +1541,7 @@ static void cmd_operate_detach_device_parsed(void *parsed_result,\n \tstruct cmd_operate_detach_device_result *res = parsed_result;\n \n \tif (!strcmp(res->keyword, \"detach\"))\n-\t\tdetach_device(res->identifier);\n+\t\tdetach_devargs(res->identifier);\n \telse\n \t\tprintf(\"Unknown parameter\\n\");\n }\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex a1dd4043e0..11203cb03d 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2683,7 +2683,8 @@ detach_port_device(portid_t port_id)\n }\n \n void\n-detach_device(char *identifier)\n+void\n+detach_devargs(char *identifier)\n {\n \tstruct rte_dev_iterator iterator;\n \tstruct rte_devargs da;\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 3dd5fc750b..b8eb28f62b 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -810,7 +810,7 @@ void stop_port(portid_t pid);\n void close_port(portid_t pid);\n void reset_port(portid_t pid);\n void attach_port(char *identifier);\n-void detach_device(char *identifier);\n+void detach_devargs(char *identifier);\n void detach_port_device(portid_t port_id);\n int all_ports_stopped(void);\n int port_is_stopped(portid_t port_id);\n", "prefixes": [ "1/2" ] }