Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65792/?format=api
{ "id": 65792, "url": "http://patches.dpdk.org/api/patches/65792/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200213123854.203566-6-gavin.hu@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200213123854.203566-6-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200213123854.203566-6-gavin.hu@arm.com", "date": "2020-02-13T12:38:53", "name": "[RFC,v1,5/6] net/mlx5: non-cacheable mapping defaulted for aarch64", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "40050d69563b1ca0bf2f6c16d6a5c8ef9c2da5c1", "submitter": { "id": 1018, "url": "http://patches.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200213123854.203566-6-gavin.hu@arm.com/mbox/", "series": [ { "id": 8525, "url": "http://patches.dpdk.org/api/series/8525/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8525", "date": "2020-02-13T12:38:48", "name": "barrier fix and optimization for mlx5 on aarch64", "version": 1, "mbox": "http://patches.dpdk.org/series/8525/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65792/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/65792/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1658DA0542;\n\tThu, 13 Feb 2020 13:44:37 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D4DD21BFF3;\n\tThu, 13 Feb 2020 13:44:23 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id F2B161BFE5;\n Thu, 13 Feb 2020 13:44:22 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 83FE41063;\n Thu, 13 Feb 2020 04:44:22 -0800 (PST)", "from net-arm-thunderx2-04.shanghai.arm.com\n (net-arm-thunderx2-04.shanghai.arm.com [10.169.40.184])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 420A43F6CF;\n Thu, 13 Feb 2020 04:44:15 -0800 (PST)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com, david.marchand@redhat.com, thomas@monjalon.net,\n rasland@mellanox.com, drc@linux.vnet.ibm.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, matan@mellanox.com, shahafs@mellanox.com,\n viacheslavo@mellanox.com, jerinj@marvell.com, Honnappa.Nagarahalli@arm.com,\n ruifeng.wang@arm.com, phil.yang@arm.com, joyce.kong@arm.com,\n steve.capper@arm.com, stable@dpdk.org", "Date": "Thu, 13 Feb 2020 20:38:53 +0800", "Message-Id": "<20200213123854.203566-6-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200213123854.203566-1-gavin.hu@arm.com>", "References": "<20200213123854.203566-1-gavin.hu@arm.com>", "Subject": "[dpdk-dev] [PATCH RFC v1 5/6] net/mlx5: non-cacheable mapping\n\tdefaulted for aarch64", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "aarch64 does not map pci resources to 'write-combine' nor\ncacheable. In Linux Kernel arch_can_pci_mmap_wc() equals to 0 on\naarch64[1].\n\n[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/\ntree/drivers/pci/pci-sysfs.c?h=v5.4#n1204\n\nFixes: f078ceb6ae93 (\"net/mlx5: fix Tx doorbell write memory barrier\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\n---\n drivers/net/mlx5/mlx5_txq.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c\nindex bc13abfe6..144bab4a6 100644\n--- a/drivers/net/mlx5/mlx5_txq.c\n+++ b/drivers/net/mlx5/mlx5_txq.c\n@@ -319,7 +319,11 @@ txq_uar_ncattr_init(struct mlx5_txq_ctrl *txq_ctrl, size_t page_size)\n \toff_t cmd;\n \n \ttxq_ctrl->txq.db_heu = priv->config.dbnc == MLX5_TXDB_HEURISTIC;\n+#ifdef RTE_ARCH_ARM64\n+\ttxq_ctrl->txq.db_nc = 1;\n+#else\n \ttxq_ctrl->txq.db_nc = 0;\n+#endif\n \t/* Check the doorbell register mapping type. */\n \tcmd = txq_ctrl->uar_mmap_offset / page_size;\n \tcmd >>= MLX5_UAR_MMAP_CMD_SHIFT;\n", "prefixes": [ "RFC", "v1", "5/6" ] }