Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65790/?format=api
{ "id": 65790, "url": "http://patches.dpdk.org/api/patches/65790/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200213123854.203566-4-gavin.hu@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200213123854.203566-4-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200213123854.203566-4-gavin.hu@arm.com", "date": "2020-02-13T12:38:51", "name": "[RFC,v1,3/6] net/mlx5: add missing barrier", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "18a464e3633f7f3b4c82825292a5d389c762ca8f", "submitter": { "id": 1018, "url": "http://patches.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200213123854.203566-4-gavin.hu@arm.com/mbox/", "series": [ { "id": 8525, "url": "http://patches.dpdk.org/api/series/8525/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8525", "date": "2020-02-13T12:38:48", "name": "barrier fix and optimization for mlx5 on aarch64", "version": 1, "mbox": "http://patches.dpdk.org/series/8525/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65790/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/65790/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A2203A0542;\n\tThu, 13 Feb 2020 13:44:16 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D9E851BFEF;\n\tThu, 13 Feb 2020 13:44:10 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 771D31BFEF;\n Thu, 13 Feb 2020 13:44:09 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 00BCF1045;\n Thu, 13 Feb 2020 04:44:09 -0800 (PST)", "from net-arm-thunderx2-04.shanghai.arm.com\n (net-arm-thunderx2-04.shanghai.arm.com [10.169.40.184])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2A3C33F6CF;\n Thu, 13 Feb 2020 04:44:01 -0800 (PST)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com, david.marchand@redhat.com, thomas@monjalon.net,\n rasland@mellanox.com, drc@linux.vnet.ibm.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, matan@mellanox.com, shahafs@mellanox.com,\n viacheslavo@mellanox.com, jerinj@marvell.com, Honnappa.Nagarahalli@arm.com,\n ruifeng.wang@arm.com, phil.yang@arm.com, joyce.kong@arm.com,\n steve.capper@arm.com, stable@dpdk.org", "Date": "Thu, 13 Feb 2020 20:38:51 +0800", "Message-Id": "<20200213123854.203566-4-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200213123854.203566-1-gavin.hu@arm.com>", "References": "<20200213123854.203566-1-gavin.hu@arm.com>", "Subject": "[dpdk-dev] [PATCH RFC v1 3/6] net/mlx5: add missing barrier", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To keep order of the modification of RX queue descriptor(rxq->cq_db) and\nthe CQ doorbell register, a rte_cio_wmb barrier is required.\n\nThe situation was rescued by the stronger than required barrier in the\nmlx5_uar_write64, it becomes a must when the barrier is relaxed.\n\nFixes: 6bf10ab69be0 (\"net/mlx5: support 32-bit systems\")\nCc: stable@dpdk.org\n\nSuggested-by: Phil Yang <phil.yang@arm.com>\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\n---\n drivers/net/mlx5/mlx5_rxq.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex dc0fd8211..2d1b153a3 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -856,7 +856,8 @@ mlx5_arm_cq(struct mlx5_rxq_data *rxq, int sq_n_rxq)\n \tdoorbell = (uint64_t)doorbell_hi << 32;\n \tdoorbell |= rxq->cqn;\n \trxq->cq_db[MLX5_CQ_ARM_DB] = rte_cpu_to_be_32(doorbell_hi);\n-\tmlx5_uar_write64(rte_cpu_to_be_64(doorbell),\n+\trte_cio_wmb();\n+\tmlx5_uar_write64_relaxed(rte_cpu_to_be_64(doorbell),\n \t\t\t cq_db_reg, rxq->uar_lock_cq);\n }\n \n", "prefixes": [ "RFC", "v1", "3/6" ] }