Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65778/?format=api
{ "id": 65778, "url": "http://patches.dpdk.org/api/patches/65778/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200212230810.2837-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200212230810.2837-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200212230810.2837-5-stephen@networkplumber.org", "date": "2020-02-12T23:08:10", "name": "[RFC,4/4] cfgfile: check flags value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e2f6d04ef67db451d99b7e72c4de3bf415ef0fcb", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200212230810.2837-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 8519, "url": "http://patches.dpdk.org/api/series/8519/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8519", "date": "2020-02-12T23:08:06", "name": "Enforce flag checking in API's", "version": 1, "mbox": "http://patches.dpdk.org/series/8519/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65778/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/65778/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 45DBCA0542;\n\tThu, 13 Feb 2020 00:09:01 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2D7021BFAD;\n\tThu, 13 Feb 2020 00:08:31 +0100 (CET)", "from mail-pj1-f66.google.com (mail-pj1-f66.google.com\n [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id 8FA961BF76\n for <dev@dpdk.org>; Thu, 13 Feb 2020 00:08:26 +0100 (CET)", "by mail-pj1-f66.google.com with SMTP id j17so1531684pjz.3\n for <dev@dpdk.org>; Wed, 12 Feb 2020 15:08:26 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id f18sm198301pgn.2.2020.02.12.15.08.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 12 Feb 2020 15:08:24 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=SPNYYAZx0glh7yrtX1B0LIV4voFt/De2gvQJUOke2a4=;\n b=JvKXHcTW23IV5yPuIJwhHFFFNAanLwvEStI61jVlCWGp5ddVyBnnSHR97Vbo3F3mBW\n DtqKfIXP/rD0wwiRjFqRcFPOAf1pe4q5jOUO9vlNqpfIoT99Snn8RAEACYkUPZAxXNwE\n jMxibwlE+nBbus4ga4gaqsFPGamhh8Fr6ZSJc0LMYxIMfwiXvlzoNPA4cgESs2QuvX8F\n KQyFcSgiA0EW3QPKzQ3auElOZ6pZvdHqlZEXPDgPmU6cPXzxcIqTpwulCBHkKACLySSn\n Puat93N1tFApj+4a5uV3JHCYQsCwnkIi1+eUwEGVVKR1/ffOXadQ1BlEPLNXyF5TS4q2\n fv4A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=SPNYYAZx0glh7yrtX1B0LIV4voFt/De2gvQJUOke2a4=;\n b=RUdXvXCIQ0C5aPaVcIwM7KNiKEiPRM6q+SLk8c4byah6BfD4gzRSoC7YNOf2pFk1Jd\n htHJTU0toNvdJ3HbNYLrnB7eOSYdDm22Drx1Am+9q8P3XTQr+Hmdwp/zZ1TDATln6JD4\n Omtkwx+SgO+V/aImgTijtYUzmDuyn0Jhq6dlV9e09o2mky9pI3LjQTTAJMui4MyHEbiV\n t1womVEjVwZi175CzFXrNGIO3INaTVoNymO3pIaxL0AKiglTznXZkO51xcKaMlrR1E3e\n QUJQWmooBvmOe1p4S3WVYbYxMAi52Pu9WcBad9v7RvGDjp5VHzEPbKaPzt5JBuD8MwnI\n jhEQ==", "X-Gm-Message-State": "APjAAAUTmOja3raQBmOASeMYOULII08xuetZt8pbQwGnBTKICgIY6X7x\n fQ9ycNMjiS9LzmU0IVO76QbvIqpmNq4=", "X-Google-Smtp-Source": "\n APXvYqxwkn7PHA8/cp7BaOqTdxek5S4lDKfUp4eYxxfwK6BuAv0ycyfZ/L//h3q2HHEqwe8JZF3niA==", "X-Received": "by 2002:a17:90b:3c9:: with SMTP id\n go9mr1612174pjb.7.1581548905293;\n Wed, 12 Feb 2020 15:08:25 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 12 Feb 2020 15:08:10 -0800", "Message-Id": "<20200212230810.2837-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200212230810.2837-1-stephen@networkplumber.org>", "References": "<20200212230810.2837-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC 4/4] cfgfile: check flags value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "All API's should check that they support the flag values\npassed. If an application passes an invalid flag it could\ncause problems in later ABI.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_cfgfile/rte_cfgfile.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c\nindex 9049fd9c2319..cec82c82ee20 100644\n--- a/lib/librte_cfgfile/rte_cfgfile.c\n+++ b/lib/librte_cfgfile/rte_cfgfile.c\n@@ -272,6 +272,10 @@ rte_cfgfile_create(int flags)\n \tint i;\n \tstruct rte_cfgfile *cfg;\n \n+\t/* future proof flags usage */\n+\tif (flags & ~(CFG_FLAG_GLOBAL_SECTION | CFG_FLAG_EMPTY_VALUES))\n+\t\treturn NULL;\n+\t\n \tcfg = malloc(sizeof(*cfg));\n \n \tif (cfg == NULL)\n", "prefixes": [ "RFC", "4/4" ] }