Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65777/?format=api
{ "id": 65777, "url": "http://patches.dpdk.org/api/patches/65777/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200212230810.2837-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200212230810.2837-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200212230810.2837-4-stephen@networkplumber.org", "date": "2020-02-12T23:08:09", "name": "[RFC,3/4] stack: check flags on creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cf7dd25dc303ae12c1022661f88c1d739d58e636", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200212230810.2837-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 8519, "url": "http://patches.dpdk.org/api/series/8519/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8519", "date": "2020-02-12T23:08:06", "name": "Enforce flag checking in API's", "version": 1, "mbox": "http://patches.dpdk.org/series/8519/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65777/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/65777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2333CA0542;\n\tThu, 13 Feb 2020 00:08:50 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 456791BFA0;\n\tThu, 13 Feb 2020 00:08:29 +0100 (CET)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 5385F1BE94\n for <dev@dpdk.org>; Thu, 13 Feb 2020 00:08:25 +0100 (CET)", "by mail-pg1-f195.google.com with SMTP id j15so1996941pgm.6\n for <dev@dpdk.org>; Wed, 12 Feb 2020 15:08:25 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id f18sm198301pgn.2.2020.02.12.15.08.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 12 Feb 2020 15:08:22 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=2HjE9Fdln2VqbWx5zdMwbDOEwGuLxlBznt/D/+mv+9U=;\n b=wElqKNNUKsio7pZ8X5OhP9iXIT7WVT+MI13bpz+BcsbFA2a9J7AI1Mb7QsVbmcaduG\n 0E00veLhnC2+rNRTTZkGq7bJMJXZavp14qFcopniHW+2bqnsCVH8Y1uJ0iYLpxygtGZK\n ylD3TF4tmxochgX4WuuPwyxmfSoqf85m6aKo5vPVOQXh+Aamcf5/5jp+AjX6Cchc9hxi\n qWmPk++bJtTlXUipZllG6RZTMTr1T6C6B5qeHjS0Yphhk1wd8zNmPpTWx8P5ZbdPZV/E\n jBqhBtn/5kThbZtz2vEAn6ZFjWZw+lf9gANVS/pfrRw6FOPmvH48C17Xyoy1S2VXdT98\n 3H3A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=2HjE9Fdln2VqbWx5zdMwbDOEwGuLxlBznt/D/+mv+9U=;\n b=s9Ja7q+lTZ5loMvF6DXs7o973ZSpcQZWmrfni0vdlBlyS0tjpwkf66xiTYKjgNCx4g\n aSdPBFZSWAAibbBYb3MiNHEhVnJackC7I2QrNt3QIgodujjcf6I0GS2RQpv4HzxrDF0Y\n EHHeM+q9HF9CdVe91U1C9Ea4/1sqALPiLz9qw8KmQbKxzrKRMR9AIMa4LIWt6q7o8uJM\n JpStrAWsj3k0ShO4MKQnR9bIIPa1UvFsNrnV7EvmH3VdjM6Mpt2ebm95n4dDq/d/vXO3\n jm3Dw9txJUanewUpk5Fcfhm1FOKboBUvhhpPLTPtVq/OPvCb12f8Pvq0HtEpMSvesPFD\n u0tg==", "X-Gm-Message-State": "APjAAAWZp7ypYraBsTf2H5VWi62ImA5PLgBUWWAZBGZgYk65l/GPMEMZ\n zpjDioAExMELvDTciYA0k1iVFeWpKsw=", "X-Google-Smtp-Source": "\n APXvYqymi8eyEthUl0Q0+NiSuy4P6OinDCr768nwl7/ssneB9DnFduEJCFbjiahw0zvDWnOIB9B9Kw==", "X-Received": "by 2002:aa7:8bda:: with SMTP id\n s26mr10964829pfd.194.1581548903971;\n Wed, 12 Feb 2020 15:08:23 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 12 Feb 2020 15:08:09 -0800", "Message-Id": "<20200212230810.2837-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200212230810.2837-1-stephen@networkplumber.org>", "References": "<20200212230810.2837-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC 3/4] stack: check flags on creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "All API's should check that they support the flag values\npassed. If an application passes an invalid flag it could\ncause problems in later ABI.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_stack/rte_stack.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/lib/librte_stack/rte_stack.c b/lib/librte_stack/rte_stack.c\nindex d19824f00439..4b09ff30d6bd 100644\n--- a/lib/librte_stack/rte_stack.c\n+++ b/lib/librte_stack/rte_stack.c\n@@ -59,6 +59,11 @@ rte_stack_create(const char *name, unsigned int count, int socket_id,\n \tunsigned int sz;\n \tint ret;\n \n+\tif (flags & ~(RTE_STACK_F_LF)) {\n+\t\tSTACK_LOG_ERR(\"Unsupported stack flags %#x\\n\", flags);\n+\t\treturn NULL;\n+\t}\n+\t\n #ifdef RTE_ARCH_64\n \tRTE_BUILD_BUG_ON(sizeof(struct rte_stack_lf_head) != 16);\n #else\n", "prefixes": [ "RFC", "3/4" ] }