Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65776/?format=api
{ "id": 65776, "url": "http://patches.dpdk.org/api/patches/65776/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200212230810.2837-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200212230810.2837-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200212230810.2837-3-stephen@networkplumber.org", "date": "2020-02-12T23:08:08", "name": "[RFC,2/4] hash: check flags on creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f97d98600ddd722997e5b03b484f84f4484bd75d", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200212230810.2837-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 8519, "url": "http://patches.dpdk.org/api/series/8519/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8519", "date": "2020-02-12T23:08:06", "name": "Enforce flag checking in API's", "version": 1, "mbox": "http://patches.dpdk.org/series/8519/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65776/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/65776/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 52874A0542;\n\tThu, 13 Feb 2020 00:08:41 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BF0311BF8E;\n\tThu, 13 Feb 2020 00:08:27 +0100 (CET)", "from mail-pg1-f177.google.com (mail-pg1-f177.google.com\n [209.85.215.177]) by dpdk.org (Postfix) with ESMTP id F1E201BE94\n for <dev@dpdk.org>; Thu, 13 Feb 2020 00:08:23 +0100 (CET)", "by mail-pg1-f177.google.com with SMTP id b35so1852577pgm.13\n for <dev@dpdk.org>; Wed, 12 Feb 2020 15:08:23 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id f18sm198301pgn.2.2020.02.12.15.08.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 12 Feb 2020 15:08:21 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=jwFO6sSmu+SCeWP4DmHibzOitYajREV6wKXeSiQbxpQ=;\n b=PJQB60zD512/Vw0ZwGfoCiedGxgfUVAlGAbDGQb2P2lLhURCykhAeRdQqrtuEp09uA\n qJHmsUeQAKxDNgeOlLhwnkSUSInqi9CJncHCbefg1bXafex5czQ/cZOHgZ+Jnh/nBw+s\n 7EDKbB1OBqa7JgVDqGHY6qKETgkgK4cc0vCsRYZC4hiE9pip35yccyb1rJH5P78sia5G\n EFC/Dw9/tDvk73HdTJysMoqiABK8NQRoQKcSUQh+kjJWb5xrnc2j2lT8yxIZVc+BEild\n Kgq5xq5bqwy6J3LstBlpPsxBdA9Nm61a/xPn7tsnisnGIEJYyXHVH8K/lBZi873zko2J\n Ctqg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=jwFO6sSmu+SCeWP4DmHibzOitYajREV6wKXeSiQbxpQ=;\n b=Qx4e0B20PyiUrYPajYzimm5TzwxKaxTpeW2s93VMUFYX1JXHT5fzzecAKHAjYyV7da\n p3dZqw2i6wKYFdkfLsWLB/xsyZaP5F1Swi241ZeJIqX0xX9I2X0P8Y0XVgUAq1BmHQ+F\n OZapaMlIomnsEUQAIHTqyjj2lVcd/OrN2Cm9PW3aVm9OrSJqC6Wx+Ut7hq4zA5WtlljA\n 8H26R11y0LK6zgmI6HpCZNy90ii8+45ZetL4E7+mgKqMXl1a+BzyeUWG5gK6+1EvO5p0\n e+D4Wdr8veuRsI88lfRgOgJOEniBh8X88K3vnbb6+gEDI/W9/taLGKNMFGyW/roZfBRa\n 8LXw==", "X-Gm-Message-State": "APjAAAUj5clI53D7ccTf7BNXoEhbbGw9eQLOm6i3Ck7tZE2l3jSFHH5S\n PRwiIttDlxShqCozIHgpJzOwCqa20cc=", "X-Google-Smtp-Source": "\n APXvYqyo6voklbtVAh84VTFCh/Kx1Wy7eyuyWaBu5OvhhmllcUX+1iIrdwLMhvAjf0SlCBEPkyNTwQ==", "X-Received": "by 2002:a62:15d8:: with SMTP id 207mr3481415pfv.40.1581548902554;\n Wed, 12 Feb 2020 15:08:22 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 12 Feb 2020 15:08:08 -0800", "Message-Id": "<20200212230810.2837-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200212230810.2837-1-stephen@networkplumber.org>", "References": "<20200212230810.2837-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC 2/4] hash: check flags on creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "All API's should check that they support the flag values\npassed. If an application passes an invalid flag it could\ncause problems in later ABI.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_hash/rte_cuckoo_hash.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c\nindex 6af8ca42e94f..ab9cd91b4955 100644\n--- a/lib/librte_hash/rte_cuckoo_hash.c\n+++ b/lib/librte_hash/rte_cuckoo_hash.c\n@@ -32,6 +32,9 @@\n #include \"rte_hash.h\"\n #include \"rte_cuckoo_hash.h\"\n \n+/* Mask of all flags supported by this version */\n+#define RTE_HASH_EXTRA_FLAGS_MASK 0x2f\n+\n #define FOR_EACH_BUCKET(CURRENT_BKT, START_BUCKET) \\\n \tfor (CURRENT_BKT = START_BUCKET; \\\n \t\tCURRENT_BKT != NULL; \\\n@@ -164,6 +167,12 @@ rte_hash_create(const struct rte_hash_parameters *params)\n \t\treturn NULL;\n \t}\n \n+\tif (params->extra_flag & ~RTE_HASH_EXTRA_FLAGS_MASK) {\n+\t\trte_errno = EINVAL;\n+\t\tRTE_LOG(ERR, HASH, \"rte_hash_create: unsupported extra flags\\n\");\n+\t\treturn NULL;\n+\t}\n+\n \t/* Validate correct usage of extra options */\n \tif ((params->extra_flag & RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY) &&\n \t (params->extra_flag & RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF)) {\n", "prefixes": [ "RFC", "2/4" ] }