Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65775/?format=api
{ "id": 65775, "url": "http://patches.dpdk.org/api/patches/65775/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200212230810.2837-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200212230810.2837-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200212230810.2837-2-stephen@networkplumber.org", "date": "2020-02-12T23:08:07", "name": "[RFC,1/4] ring: future proof flag settings", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "63e1f894472c11128290c3c690803d98a34df49d", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200212230810.2837-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 8519, "url": "http://patches.dpdk.org/api/series/8519/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8519", "date": "2020-02-12T23:08:06", "name": "Enforce flag checking in API's", "version": 1, "mbox": "http://patches.dpdk.org/series/8519/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65775/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/65775/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 64F58A0542;\n\tThu, 13 Feb 2020 00:08:32 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 69C951BEE5;\n\tThu, 13 Feb 2020 00:08:26 +0100 (CET)", "from mail-pf1-f180.google.com (mail-pf1-f180.google.com\n [209.85.210.180]) by dpdk.org (Postfix) with ESMTP id 7E4B2DE3\n for <dev@dpdk.org>; Thu, 13 Feb 2020 00:08:22 +0100 (CET)", "by mail-pf1-f180.google.com with SMTP id 2so1967167pfg.12\n for <dev@dpdk.org>; Wed, 12 Feb 2020 15:08:22 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id f18sm198301pgn.2.2020.02.12.15.08.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 12 Feb 2020 15:08:20 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=TQ1foTVxg+p0Z34hPpUt3AbAs5O+/GOEYxwluwUJ5WI=;\n b=m7ApAhTdNMkC5iXzXs0BrexJbKE12mmUY7KpZMg3MW5W+wrMvDM82i/QvZxzcXpjBW\n ZZyxK47O+O731HrHcwDXrL1JVXN7zyJIeTOjYyeOlwH1/KV12/ByODwYhC1AAK6zk4d9\n pB5JN/0ioAchBCFSYc0YZWB0NYmiZbFJ0Awum0NLqt7ycb90XwgFAsvD0LjNJXcq8ISP\n 5ONQOLsiQ0XMHJqwYYTmo0HlU/Q1Jx1Ospz/BLjIlV7Uw3YZOFoB/ChDML/URomwNpKi\n 1NuEclvoUscpTxuYtAqNEdeEhibgDGEjpb16yfIgt/KOxBh8K1ZgEvgH+v2qBknjYl58\n 8xqA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=TQ1foTVxg+p0Z34hPpUt3AbAs5O+/GOEYxwluwUJ5WI=;\n b=NF1L4Q7EXlksMc8ci7piSCCP67i9ukwEeZUYFDxBsXdw7R8QfrwBfpT1kDSeX64lrl\n GnGtuyJdeKbVyavvBSK3oW4wDTmNPJOYJOukYS/7kPjQr3btn4n8gymrm2+yLWZAsWaP\n euDyYvyv8ARhZefRPLRgXxnM1QCgWwh+Ep4fmjDiDs0Dl+szd4zOLgF5DYpp4oKM430e\n CyPvhDQyCbl/Nxt1ucEcVcivrL3em4qP4MMYmQbDo7l/cneRMfuQ6JDZLFrS1rbNffKy\n R47vcUgV5vCcqXiB5xJYKqErk+R+DuDbaVzUAtaIASUUCFbZgsr5QXoPiwzTXPwfATor\n MzOA==", "X-Gm-Message-State": "APjAAAWe2dTL+U0b54pu6A3ok44UJRnV7FMJR3vHv9TGOt1zBJW/9fm2\n GlUcsMAvWSDF9N+6pyr5dF/uWfRu7T4=", "X-Google-Smtp-Source": "\n APXvYqxaD/TdUM4RZtI9Q0hlLDT+BLOYl7RIgebHP3PMnNqxBWSIytqbTYgFGsY6GLLzy3Tq/GMp7A==", "X-Received": "by 2002:a63:4385:: with SMTP id\n q127mr13973929pga.404.1581548901028;\n Wed, 12 Feb 2020 15:08:21 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 12 Feb 2020 15:08:07 -0800", "Message-Id": "<20200212230810.2837-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200212230810.2837-1-stephen@networkplumber.org>", "References": "<20200212230810.2837-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC 1/4] ring: future proof flag settings", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "All API's should check that they support the flag values\npassed. If an application passes an invalid flag it could\ncause problems in later ABI.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_ring/rte_ring.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c\nindex 77e5de099b81..6cd8831649ea 100644\n--- a/lib/librte_ring/rte_ring.c\n+++ b/lib/librte_ring/rte_ring.c\n@@ -100,6 +100,13 @@ rte_ring_init(struct rte_ring *r, const char *name, unsigned count,\n \tRTE_BUILD_BUG_ON((offsetof(struct rte_ring, prod) &\n \t\t\t RTE_CACHE_LINE_MASK) != 0);\n \n+\t/* future proof flags, only allow supported values */\n+\tif (flags & ~(RING_F_SP_ENQ | RING_F_SC_DEQ)) {\n+\t\tRTE_LOG(ERR, RING,\n+\t\t\t\"Unsupported flags requested %d\\n\", flags);\n+\t\treturn -EINVAL;\n+\t}\n+\t\t\n \t/* init the ring structure */\n \tmemset(r, 0, sizeof(*r));\n \tret = strlcpy(r->name, name, sizeof(r->name));\n", "prefixes": [ "RFC", "1/4" ] }