Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65772/?format=api
{ "id": 65772, "url": "http://patches.dpdk.org/api/patches/65772/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200212220708.492297-6-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200212220708.492297-6-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200212220708.492297-6-thomas@monjalon.net", "date": "2020-02-12T22:07:07", "name": "[v5,5/6] net/mlx: rename meson variable for dlopen option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c91e9e8aea8b2296b846d9efd06b79ebf1197c61", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200212220708.492297-6-thomas@monjalon.net/mbox/", "series": [ { "id": 8518, "url": "http://patches.dpdk.org/api/series/8518/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8518", "date": "2020-02-12T22:07:02", "name": "mlx ibverbs linking in meson", "version": 5, "mbox": "http://patches.dpdk.org/series/8518/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65772/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65772/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4E6F5A0534;\n\tWed, 12 Feb 2020 23:08:03 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 35FD31BFC8;\n\tWed, 12 Feb 2020 23:07:24 +0100 (CET)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 505E11BFA4\n for <dev@dpdk.org>; Wed, 12 Feb 2020 23:07:20 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id F2E9B22056;\n Wed, 12 Feb 2020 17:07:19 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute1.internal (MEProxy); Wed, 12 Feb 2020 17:07:19 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 431A030600DC;\n Wed, 12 Feb 2020 17:07:19 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=kzWGDJIUeu\n hnqZpQLEy1ybOZvp26ycWbUpsCicLig/w=; b=Tvqf87DlEMLV25Ps44fJ3XYpTz\n akmOqz3tU55qn164qmr5UY0vAfhGvm/qK+YbmR0eZjp6ZIuKxFEo6mSHG/cKbAUm\n pq58Uk+9NSJVOKGAs+Dj65lfCCoS9iPBExPvgiHiCH4AwSvZrn6RAxe8hM5FiOGm\n YCGCu6n2CfGWtF0jM=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=kzWGDJIUeuhnqZpQLEy1ybOZvp26ycWbUpsCicLig/w=; b=dlRRbPXq\n rvu26I525Hyh2oz0b7aLSqNaW4jxZ+I+9jdjtlFOaWEV5uHCfqQ67Vs3lUURD3NU\n 2e1zNpD4+epDryEw9VmgZJssIwY4gOyqTG8+BpPc/iZao2O9D4ApmvejIN714BfL\n MESiOw2Hp2k2KF3MsXbQ1xo6IjtWyiaWDsjL3D1BTwGYVW+GZClhloacv6psXkAA\n RBPRBYAzCWo+skrywlpJtyXBVBDvGiFOC0ckEZoq72uPKkGW27tD20TsUV+cHnDQ\n cRcE8dM0u+JXAyN+I3G0hVjDKUyxYifOgEnb74NL/VZW9I/vi3iQFHZNB+O9q5g/\n 2WU9S4J3iu3S+Q==" ], "X-ME-Sender": "<xms:F3dEXiwh3oomZ6zl4CIS_CPff5V6HmO2GOummZP3ozgWPve1pOvFrQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedugedrieeigddvvdcutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepgeenucfrrghr\n rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:F3dEXjeq9UpqrgNSokaDXl09QjU35eFldyZ6I2F1oB8bsL8R8XiIvw>\n <xmx:F3dEXktuAoFaDe9OeifOKxgv0C29UAEYvFGox5HCrXwluR8Lq-LkMQ>\n <xmx:F3dEXhmnZjcFtD6BQ0KphzH3QwSDO3jrOhS5y0y980kB7sfP-CLOgQ>\n <xmx:F3dEXqdv18LyUbdj12vT1l8Tw6U5x1q2SRUXlTbNI7axSuVvz6llCA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, Matan Azrad <matan@mellanox.com>,\n Shahaf Shuler <shahafs@mellanox.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "Date": "Wed, 12 Feb 2020 23:07:07 +0100", "Message-Id": "<20200212220708.492297-6-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200212220708.492297-1-thomas@monjalon.net>", "References": "<20200116071656.1663967-1-thomas@monjalon.net>\n <20200212220708.492297-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 5/6] net/mlx: rename meson variable for dlopen\n\toption", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The name of the variable pmd_dlopen is confusing because\nit can be understood as true if the PMD is dlopen,\nwhereas it means the ibverbs glue layer is a dlopen library.\nThat's why it is renamed dlopen_ibverbs.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/common/mlx5/meson.build | 8 ++++----\n drivers/net/mlx4/meson.build | 8 ++++----\n 2 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build\nindex 4e987ed277..0fe086136a 100644\n--- a/drivers/common/mlx5/meson.build\n+++ b/drivers/common/mlx5/meson.build\n@@ -8,11 +8,11 @@ if not is_linux\n endif\n \n static_ibverbs = (get_option('ibverbs_link') == 'static')\n-pmd_dlopen = (get_option('ibverbs_link') == 'dlopen')\n+dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')\n LIB_GLUE_BASE = 'librte_pmd_mlx5_glue.so'\n LIB_GLUE_VERSION = '20.02.0'\n LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION\n-if pmd_dlopen\n+if dlopen_ibverbs\n \tdpdk_conf.set('RTE_IBVERBS_LINK_DLOPEN', 1)\n \tcflags += [\n \t\t'-DMLX5_GLUE=\"@0@\"'.format(LIB_GLUE),\n@@ -54,7 +54,7 @@ sources = files(\n \t'mlx5_common.c',\n \t'mlx5_nl.c',\n )\n-if not pmd_dlopen\n+if not dlopen_ibverbs\n \tsources += files('mlx5_glue.c')\n endif\n cflags_options = [\n@@ -193,7 +193,7 @@ endforeach\n configure_file(output : 'mlx5_autoconf.h', configuration : config)\n \n # Build Glue Library\n-if pmd_dlopen\n+if dlopen_ibverbs\n \tdlopen_name = 'mlx5_glue'\n \tdlopen_lib_name = driver_name_fmt.format(dlopen_name)\n \tdlopen_so_version = LIB_GLUE_VERSION\ndiff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build\nindex 290bd1e268..f66e70f4d1 100644\n--- a/drivers/net/mlx4/meson.build\n+++ b/drivers/net/mlx4/meson.build\n@@ -9,11 +9,11 @@ if not is_linux\n endif\n \n static_ibverbs = (get_option('ibverbs_link') == 'static')\n-pmd_dlopen = (get_option('ibverbs_link') == 'dlopen')\n+dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')\n LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'\n LIB_GLUE_VERSION = '18.02.0'\n LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION\n-if pmd_dlopen\n+if dlopen_ibverbs\n \tdpdk_conf.set('RTE_IBVERBS_LINK_DLOPEN', 1)\n \tcflags += [\n \t\t'-DMLX4_GLUE=\"@0@\"'.format(LIB_GLUE),\n@@ -61,7 +61,7 @@ sources = files(\n \t'mlx4_txq.c',\n \t'mlx4_utils.c',\n )\n-if not pmd_dlopen\n+if not dlopen_ibverbs\n \tsources += files('mlx4_glue.c')\n endif\n cflags_options = [\n@@ -113,7 +113,7 @@ endforeach\n configure_file(output : 'mlx4_autoconf.h', configuration : config)\n \n # Build Glue Library\n-if pmd_dlopen\n+if dlopen_ibverbs\n \tdlopen_name = 'mlx4_glue'\n \tdlopen_lib_name = driver_name_fmt.format(dlopen_name)\n \tdlopen_so_version = LIB_GLUE_VERSION\n", "prefixes": [ "v5", "5/6" ] }