Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65771/?format=api
{ "id": 65771, "url": "http://patches.dpdk.org/api/patches/65771/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200212220708.492297-5-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200212220708.492297-5-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200212220708.492297-5-thomas@monjalon.net", "date": "2020-02-12T22:07:06", "name": "[v5,4/6] net/mlx: workaround static linkage with meson", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "be4d48132ec19b132a18e902aa3c6d97aa074f8e", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200212220708.492297-5-thomas@monjalon.net/mbox/", "series": [ { "id": 8518, "url": "http://patches.dpdk.org/api/series/8518/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8518", "date": "2020-02-12T22:07:02", "name": "mlx ibverbs linking in meson", "version": 5, "mbox": "http://patches.dpdk.org/series/8518/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65771/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65771/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D075DA0534;\n\tWed, 12 Feb 2020 23:07:55 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B85661BFBE;\n\tWed, 12 Feb 2020 23:07:22 +0100 (CET)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id EE32F1BF7C\n for <dev@dpdk.org>; Wed, 12 Feb 2020 23:07:18 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id 91F1F21443;\n Wed, 12 Feb 2020 17:07:18 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute1.internal (MEProxy); Wed, 12 Feb 2020 17:07:18 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id C365630600DC;\n Wed, 12 Feb 2020 17:07:17 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=k0OvKrzm0n\n md8OMi52dW8IYWS4xKath9B3M/MyofQME=; b=LF8nVjUNRTLoTGEevTOZk90H/g\n aBBEI86eI1J1GnnYoPeub78aQMj8ezcB6bbzpaOCN0IrXkytrahqOsYbzGrrNm0A\n VJtDeowmJnZxUPV0QhMjR/Br/fSkAhbFr/ChfJabo4G/7MuMe37TmqEFUujZqJ6w\n ePxhaO2glHeETTHrY=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=k0OvKrzm0nmd8OMi52dW8IYWS4xKath9B3M/MyofQME=; b=buBsa1uM\n 8+T3FMg2ytuFz4lCMD3WI5S6Kj92I804b3rgG15U/637Y5S/Jk8sjCULnONaPImp\n rTntHDEX7Snj2a5tlylgTWABb8JRx+NA/gzFqbsA4w0WIjmzIKf/oRkaiq04b0ze\n sdc3VHY7rke7SdIZRWp35iGiezpe3h11VGIluzkaHs2RKBVARBRLVAk8JAyLc7pt\n VgcmIc4VJ1g+sC7HhVlepMqSnM+0hfgg8NBr/lFB6bw2447EZP+9AYWQKSvzlYLI\n Px52cY72m65/S0NM7yqC5PWvHgWt9EYCg34L3DW9wn0B0l2V8rkc5DtuXaQD1EG1\n qNotYBHxkBo39Q==" ], "X-ME-Sender": "<xms:FndEXuImVsiKgGfnf69PmlGpJ-HfjJnFT2aRFk8RSXRrH40ecQq2fw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedugedrieeigddvvdcutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh\n hmrghinhepghhithhhuhgsrdgtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeen\n ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomh\n grshesmhhonhhjrghlohhnrdhnvght", "X-ME-Proxy": "<xmx:FndEXmTpF-td09wg1YnwREVhXVG-PljUnHVRxWyAC9tK3Z0Mv0mzMw>\n <xmx:FndEXi0EoPYvK-YFwM15LsLIqqEKf2ruBaNWINnDaR1uxCCtbg5egg>\n <xmx:FndEXr19k_SDCvpbef7a9Tcwro7evnJ4sPr3mtndw-MINTejr2wuoQ>\n <xmx:FndEXiv-SXlZ7OC9pIGwmASHmtNqoovRO5khll3euQiFa-i5xl2N8g>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, Matan Azrad <matan@mellanox.com>,\n Shahaf Shuler <shahafs@mellanox.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "Date": "Wed, 12 Feb 2020 23:07:06 +0100", "Message-Id": "<20200212220708.492297-5-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200212220708.492297-1-thomas@monjalon.net>", "References": "<20200116071656.1663967-1-thomas@monjalon.net>\n <20200212220708.492297-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 4/6] net/mlx: workaround static linkage with\n\tmeson", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If ibverbs_link is static and the application choose to link DPDK\nas static libraries, both PMD and ibverbs libraries must be linked\nas static libraries. And the dependencies of ibverbs (netlink) must\nstill be linked as shared libraries.\n\nUnfortunately, meson forget about the static requirement for ibverbs\nwhen generating the .pc file.\nAs a result, libibverbs, libmlx4, libmlx5 are listed in Requires.private\nsection (allowing to be linked as shared libraries) and libnl is missing.\n\nA fix is in progress for meson, but anyway we will have to live without\nsuch a fix until a better version of meson is widely available:\n\thttps://github.com/mesonbuild/meson/pull/6393\n\nIn order to avoid meson suggesting shared libraries in the section\nRequires.private of the .pc file, the dependency object is recreated\nwith declare_dependency():\n\t- cflags are extracted the libibverbs.pc\n\t- ldflags, from libibverbs.pc, are processed to force\n\tstatic flavor of ibverbs libraries, thanks to this syntax:\n\t\t\t-l:libfoo.a\n\nFixes: 83fff714bd27 (\"net/mlx: add static ibverbs linkage with meson\")\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n buildtools/meson.build | 2 ++\n drivers/common/mlx5/meson.build | 12 +++++++++++-\n drivers/net/mlx4/meson.build | 14 ++++++++++++--\n 3 files changed, 25 insertions(+), 3 deletions(-)", "diff": "diff --git a/buildtools/meson.build b/buildtools/meson.build\nindex 0f563d89a3..9812917e50 100644\n--- a/buildtools/meson.build\n+++ b/buildtools/meson.build\n@@ -3,9 +3,11 @@\n \n subdir('pmdinfogen')\n \n+pkgconf = find_program('pkg-config', 'pkgconf', required: false)\n pmdinfo = find_program('gen-pmdinfo-cfile.sh')\n list_dir_globs = find_program('list-dir-globs.py')\n check_experimental_syms = find_program('check-experimental-syms.sh')\n+ldflags_ibverbs_static = find_program('options-ibverbs-static.sh')\n \n # set up map-to-def script using python, either built-in or external\n python3 = import('python').find_installation(required: false)\ndiff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build\nindex 47ae1b65c2..4e987ed277 100644\n--- a/drivers/common/mlx5/meson.build\n+++ b/drivers/common/mlx5/meson.build\n@@ -29,16 +29,26 @@ foreach libname:libnames\n \tendif\n \tif lib.found()\n \t\tlibs += lib\n+\t\tif not static_ibverbs\n+\t\t\text_deps += lib\n+\t\tendif\n \telse\n \t\tbuild = false\n \t\treason = 'missing dependency, \"' + libname + '\"'\n \t\tsubdir_done()\n \tendif\n endforeach\n+if static_ibverbs\n+\t# Build without adding shared libs to Requires.private\n+\tibv_cflags = run_command(pkgconf, '--cflags', 'libibverbs').stdout()\n+\text_deps += declare_dependency(compile_args: ibv_cflags.split())\n+\t# Add static deps ldflags to internal apps and Libs.private\n+\tibv_ldflags = run_command(ldflags_ibverbs_static, check:true).stdout()\n+\text_deps += declare_dependency(link_args:ibv_ldflags.split())\n+endif\n \n allow_experimental_apis = true\n deps += ['hash', 'pci', 'net', 'eal', 'kvargs']\n-ext_deps += libs\n sources = files(\n \t'mlx5_devx_cmds.c',\n \t'mlx5_common.c',\ndiff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build\nindex 7513516764..290bd1e268 100644\n--- a/drivers/net/mlx4/meson.build\n+++ b/drivers/net/mlx4/meson.build\n@@ -29,16 +29,26 @@ foreach libname:libnames\n \t\tlib = cc.find_library(libname, required:false)\n \tendif\n \tif lib.found()\n-\t\tlibs += [ lib ]\n+\t\tlibs += lib\n+\t\tif not static_ibverbs\n+\t\t\text_deps += lib\n+\t\tendif\n \telse\n \t\tbuild = false\n \t\treason = 'missing dependency, \"' + libname + '\"'\n \t\tsubdir_done()\n \tendif\n endforeach\n+if static_ibverbs\n+\t# Build without adding shared libs to Requires.private\n+\tibv_cflags = run_command(pkgconf, '--cflags', 'libibverbs').stdout()\n+\text_deps += declare_dependency(compile_args: ibv_cflags.split())\n+\t# Add static deps ldflags to internal apps and Libs.private\n+\tibv_ldflags = run_command(ldflags_ibverbs_static, check:true).stdout()\n+\text_deps += declare_dependency(link_args:ibv_ldflags.split())\n+endif\n \n allow_experimental_apis = true\n-ext_deps += libs\n sources = files(\n \t'mlx4.c',\n \t'mlx4_ethdev.c',\n", "prefixes": [ "v5", "4/6" ] }