Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65750/?format=api
{ "id": 65750, "url": "http://patches.dpdk.org/api/patches/65750/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200212015944.3037000-6-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200212015944.3037000-6-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200212015944.3037000-6-thomas@monjalon.net", "date": "2020-02-12T01:59:43", "name": "[v4,5/6] net/mlx: rename meson variable for dlopen option", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c91e9e8aea8b2296b846d9efd06b79ebf1197c61", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200212015944.3037000-6-thomas@monjalon.net/mbox/", "series": [ { "id": 8506, "url": "http://patches.dpdk.org/api/series/8506/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8506", "date": "2020-02-12T01:59:38", "name": "mlx ibverbs linking in meson", "version": 4, "mbox": "http://patches.dpdk.org/series/8506/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65750/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65750/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 656D7A0530;\n\tWed, 12 Feb 2020 03:00:47 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DEB831BE9E;\n\tWed, 12 Feb 2020 03:00:06 +0100 (CET)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 22BB31BE94\n for <dev@dpdk.org>; Wed, 12 Feb 2020 03:00:05 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id B1F1821DAF;\n Tue, 11 Feb 2020 21:00:04 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute1.internal (MEProxy); Tue, 11 Feb 2020 21:00:04 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 85F113280065;\n Tue, 11 Feb 2020 21:00:03 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=Y5VzPty2G7\n lt+wa/hiXr6gdXBDLMVGhSWHdjxjsbLrM=; b=jqus1TQ1jX4WLlrYtqSVRCp9vS\n N2HJ0NL8kK1MTR8a6ddXap794LFA0Fy/5kip2bO5499erxkzZaFx2mkYtKfQtVTL\n aB4bv8tkjewXPEcDZR/HzHx3ep5PJ1r5o1o6aleQhlL0zdfhjo05oZ8jaVCr+aLq\n i3TnE8omwqyh+Bd44=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=Y5VzPty2G7lt+wa/hiXr6gdXBDLMVGhSWHdjxjsbLrM=; b=23cV4TAY\n yt0nZUjFaIgjyEFqLXpn1DJV8CztvQv5samWcAeLpAY9zue8BhNV/SsaGZtQcdmr\n XLUI2t7nqwfMay4Wb8cy/HURScN44xBAPzB+PVcD877Rc9hOPWKYYXwaJqjJUO4H\n esjbKhtxusWQny0v+BgO7aaKSHM26XO7tuC4Dgqnan40zYzxhJudGaCeJiKq7mjs\n 3PXeSk/RPjLnFCAqGuy4A3+KsbIoGVcxS6djQ/HMM1Wd9BoRpHK2lBO+i/2sgB5o\n 983wz6P6EO8m/GTe3012ftqz0+cBRNSrcdIkspQUSobMRrYwUiruZs8UJ/3iuVtr\n ZVskIOTUwqBn4g==" ], "X-ME-Sender": "<xms:JFxDXuAFahOKV4HqFy12-LssSMA8LrRzXPtWNZs_guu_SQppX0KDoA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedugedrieeggdefgecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepgeenucfrrghr\n rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:JFxDXmsu4SiEIPIc-b7u8GG3mrwJ57PVck4edTivsumzZkk5w2EMNQ>\n <xmx:JFxDXsfF2DGVhL-c69ECaMV9w5wzjjB8EaRicd-OVHR_juWsr_OxlQ>\n <xmx:JFxDXlOM7vgcUZXA2We_TOe7m0eCRCRFpy1ebOB8S1x9-wlA3_hs2Q>\n <xmx:JFxDXuw7MwrJUKJpGz-klT_l0rzwiHv2cFCs78D_tehxKKLLhs4_uw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, Matan Azrad <matan@mellanox.com>,\n Shahaf Shuler <shahafs@mellanox.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "Date": "Wed, 12 Feb 2020 02:59:43 +0100", "Message-Id": "<20200212015944.3037000-6-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200212015944.3037000-1-thomas@monjalon.net>", "References": "<20200116071656.1663967-1-thomas@monjalon.net>\n <20200212015944.3037000-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 5/6] net/mlx: rename meson variable for dlopen\n\toption", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The name of the variable pmd_dlopen is confusing because\nit can be understood as true if the PMD is dlopen,\nwhereas it means the ibverbs glue layer is a dlopen library.\nThat's why it is renamed dlopen_ibverbs.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/common/mlx5/meson.build | 8 ++++----\n drivers/net/mlx4/meson.build | 8 ++++----\n 2 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build\nindex 4e987ed277..0fe086136a 100644\n--- a/drivers/common/mlx5/meson.build\n+++ b/drivers/common/mlx5/meson.build\n@@ -8,11 +8,11 @@ if not is_linux\n endif\n \n static_ibverbs = (get_option('ibverbs_link') == 'static')\n-pmd_dlopen = (get_option('ibverbs_link') == 'dlopen')\n+dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')\n LIB_GLUE_BASE = 'librte_pmd_mlx5_glue.so'\n LIB_GLUE_VERSION = '20.02.0'\n LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION\n-if pmd_dlopen\n+if dlopen_ibverbs\n \tdpdk_conf.set('RTE_IBVERBS_LINK_DLOPEN', 1)\n \tcflags += [\n \t\t'-DMLX5_GLUE=\"@0@\"'.format(LIB_GLUE),\n@@ -54,7 +54,7 @@ sources = files(\n \t'mlx5_common.c',\n \t'mlx5_nl.c',\n )\n-if not pmd_dlopen\n+if not dlopen_ibverbs\n \tsources += files('mlx5_glue.c')\n endif\n cflags_options = [\n@@ -193,7 +193,7 @@ endforeach\n configure_file(output : 'mlx5_autoconf.h', configuration : config)\n \n # Build Glue Library\n-if pmd_dlopen\n+if dlopen_ibverbs\n \tdlopen_name = 'mlx5_glue'\n \tdlopen_lib_name = driver_name_fmt.format(dlopen_name)\n \tdlopen_so_version = LIB_GLUE_VERSION\ndiff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build\nindex 290bd1e268..f66e70f4d1 100644\n--- a/drivers/net/mlx4/meson.build\n+++ b/drivers/net/mlx4/meson.build\n@@ -9,11 +9,11 @@ if not is_linux\n endif\n \n static_ibverbs = (get_option('ibverbs_link') == 'static')\n-pmd_dlopen = (get_option('ibverbs_link') == 'dlopen')\n+dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')\n LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'\n LIB_GLUE_VERSION = '18.02.0'\n LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION\n-if pmd_dlopen\n+if dlopen_ibverbs\n \tdpdk_conf.set('RTE_IBVERBS_LINK_DLOPEN', 1)\n \tcflags += [\n \t\t'-DMLX4_GLUE=\"@0@\"'.format(LIB_GLUE),\n@@ -61,7 +61,7 @@ sources = files(\n \t'mlx4_txq.c',\n \t'mlx4_utils.c',\n )\n-if not pmd_dlopen\n+if not dlopen_ibverbs\n \tsources += files('mlx4_glue.c')\n endif\n cflags_options = [\n@@ -113,7 +113,7 @@ endforeach\n configure_file(output : 'mlx4_autoconf.h', configuration : config)\n \n # Build Glue Library\n-if pmd_dlopen\n+if dlopen_ibverbs\n \tdlopen_name = 'mlx4_glue'\n \tdlopen_lib_name = driver_name_fmt.format(dlopen_name)\n \tdlopen_so_version = LIB_GLUE_VERSION\n", "prefixes": [ "v4", "5/6" ] }