Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65747/?format=api
{ "id": 65747, "url": "http://patches.dpdk.org/api/patches/65747/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200212015944.3037000-3-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200212015944.3037000-3-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200212015944.3037000-3-thomas@monjalon.net", "date": "2020-02-12T01:59:40", "name": "[v4,2/6] net/mlx: add static ibverbs linkage with meson", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "54cb0cbb5999d1e0ef0209bac098a910d48d09d2", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200212015944.3037000-3-thomas@monjalon.net/mbox/", "series": [ { "id": 8506, "url": "http://patches.dpdk.org/api/series/8506/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8506", "date": "2020-02-12T01:59:38", "name": "mlx ibverbs linking in meson", "version": 4, "mbox": "http://patches.dpdk.org/series/8506/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65747/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65747/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4E049A0530;\n\tWed, 12 Feb 2020 03:00:17 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 39C902C18;\n\tWed, 12 Feb 2020 02:59:57 +0100 (CET)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 06EB62BC7\n for <dev@dpdk.org>; Wed, 12 Feb 2020 02:59:56 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id C319621F15;\n Tue, 11 Feb 2020 20:59:54 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute1.internal (MEProxy); Tue, 11 Feb 2020 20:59:54 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id C96A9328005A;\n Tue, 11 Feb 2020 20:59:53 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=T1TutPdoGE\n cvjSFuGN6E78WTLHg1ZBoAsJzEvleBY34=; b=Lzs7hUaLHH/WsY9ockM6jheg88\n BpiPNL5Msp1GujeuQ7MnfGshGnxjiV+ofw3r45ZLxso9YDh8LOqYVLsX8dK7yX47\n cmui6PnX73TwZ0CzSCT7m7g9/KnV3k5M8L+4K7Nuyx9wIPxAcPCslpSBDfvavQmQ\n VPXd2GB7i+3qwoRAU=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=T1TutPdoGEcvjSFuGN6E78WTLHg1ZBoAsJzEvleBY34=; b=FdRSySiW\n FQV0exBc4vKBP18EwaoaOIs7nxiKF/k17f4K37f5rEqYgKmDj/Sg8QmLQkoRtIK/\n PaHTdx2jKl1qZ7W6KGcglLS/Jp+fwb0z1nXmJfGFn4KPNk/8RAE8i4+bdTwsUdDN\n xf14WaNhl9gCHANDQye1SUm/eaw5k2xjUgru0tIY5scPxMPeOrXkegBZQG73aea0\n /zJ/z7Rtg/ksHU3ceo40nmWHqc4ulSG1yO184KHlEuLDAuiQbYZ3/NWQdTlKSvhN\n hBJYeibX2yzTqWNelMcGVuYCFHOMUEzKdwkSSiTgJNhT7tMaaVWlknVwGh3b/D0p\n gMeDGaCpbCmCnw==" ], "X-ME-Sender": "<xms:GlxDXsAEbLGKKq5PX2r_8G9YIwX68xCnUMgPe4KeUyvCB-L8TySZpQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedugedrieeggdefgecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepvdenucfrrghr\n rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:GlxDXliHJhbs4h67ihUwUaZtaF0b8zr3W2JhC4PrZHUa2XnAV3iNtQ>\n <xmx:GlxDXrHRgxLeHw08LxpfgZJU7j58sMCCaGaAZUd6_y7_l3EuEdebMw>\n <xmx:GlxDXslrdY_1VP0XC1NwxfTheUat6SZjovFlTtEOuiF__oXmygOWWQ>\n <xmx:GlxDXjT31Dwrtm_2BnSgI8onNsr0UuLstPjBeZNBgTfVhOfxdkXZ0A>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, Matan Azrad <matan@mellanox.com>,\n Shahaf Shuler <shahafs@mellanox.com>,\n John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "Date": "Wed, 12 Feb 2020 02:59:40 +0100", "Message-Id": "<20200212015944.3037000-3-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200212015944.3037000-1-thomas@monjalon.net>", "References": "<20200116071656.1663967-1-thomas@monjalon.net>\n <20200212015944.3037000-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 2/6] net/mlx: add static ibverbs linkage with\n\tmeson", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The libibverbs (and libmlx4/5) can be statically embedded\nin the shared PMD library, or in the application with the static PMD.\nIt was supported with make build system in\ncommit 2c0dd7b69fb0 (\"config: add static linkage of mlx dependency\").\n\nThe same feature is enabled with meson when using pkg-config\n(i.e. only if the call to dependency() is successful).\nThe fallback method for searching library with cc.find_library()\nis not supported because the dependencies of the found library\nwould not be linked (no such info in .a file unlike .so).\n\nThe main difference, in meson build system, is the generated .pc file\ngiving arguments to link DPDK with the application.\nUnfortunately the .pc file will not keep memory of the static linkage\noption for libibverbs.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n doc/guides/nics/mlx4.rst | 4 ++++\n doc/guides/nics/mlx5.rst | 4 ++++\n drivers/common/mlx5/meson.build | 5 +++--\n drivers/net/mlx4/meson.build | 5 +++--\n meson_options.txt | 4 ++--\n 5 files changed, 16 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst\nindex d0e8a8b2ff..4b1d1aceb2 100644\n--- a/doc/guides/nics/mlx4.rst\n+++ b/doc/guides/nics/mlx4.rst\n@@ -92,6 +92,10 @@ These options can be modified in the ``.config`` file.\n adds additional run-time checks and debugging messages at the cost of\n lower performance.\n \n+This option is available in meson:\n+\n+- ``ibverbs_link`` can be ``static``, ``shared``, or ``dlopen``.\n+\n Environment variables\n ~~~~~~~~~~~~~~~~~~~~~\n \ndiff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex 2411fb3461..ffab34d281 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -278,6 +278,10 @@ These options can be modified in the ``.config`` file.\n 64. Default armv8a configuration of make build and meson build set it to 128\n then brings performance degradation.\n \n+This option is available in meson:\n+\n+- ``ibverbs_link`` can be ``static``, ``shared``, or ``dlopen``.\n+\n Environment variables\n ~~~~~~~~~~~~~~~~~~~~~\n \ndiff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build\nindex be57558267..47ae1b65c2 100644\n--- a/drivers/common/mlx5/meson.build\n+++ b/drivers/common/mlx5/meson.build\n@@ -7,6 +7,7 @@ if not is_linux\n \tsubdir_done()\n endif\n \n+static_ibverbs = (get_option('ibverbs_link') == 'static')\n pmd_dlopen = (get_option('ibverbs_link') == 'dlopen')\n LIB_GLUE_BASE = 'librte_pmd_mlx5_glue.so'\n LIB_GLUE_VERSION = '20.02.0'\n@@ -22,8 +23,8 @@ endif\n libnames = [ 'mlx5', 'ibverbs' ]\n libs = []\n foreach libname:libnames\n-\tlib = dependency('lib' + libname, required:false)\n-\tif not lib.found()\n+\tlib = dependency('lib' + libname, static:static_ibverbs, required:false)\n+\tif not lib.found() and not static_ibverbs\n \t\tlib = cc.find_library(libname, required:false)\n \tendif\n \tif lib.found()\ndiff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build\nindex 6d2397b3cc..7513516764 100644\n--- a/drivers/net/mlx4/meson.build\n+++ b/drivers/net/mlx4/meson.build\n@@ -8,6 +8,7 @@ if not is_linux\n \tsubdir_done()\n endif\n \n+static_ibverbs = (get_option('ibverbs_link') == 'static')\n pmd_dlopen = (get_option('ibverbs_link') == 'dlopen')\n LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'\n LIB_GLUE_VERSION = '18.02.0'\n@@ -23,8 +24,8 @@ endif\n libnames = [ 'mlx4', 'ibverbs' ]\n libs = []\n foreach libname:libnames\n-\tlib = dependency('lib' + libname, required:false)\n-\tif not lib.found()\n+\tlib = dependency('lib' + libname, static:static_ibverbs, required:false)\n+\tif not lib.found() and not static_ibverbs\n \t\tlib = cc.find_library(libname, required:false)\n \tendif\n \tif lib.found()\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 20be15fe6b..9e4923a4f1 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -14,8 +14,8 @@ option('examples', type: 'string', value: '',\n \tdescription: 'Comma-separated list of examples to build by default')\n option('flexran_sdk', type: 'string', value: '',\n \tdescription: 'Path to FlexRAN SDK optional Libraries for BBDEV device')\n-option('ibverbs_link', type: 'combo', choices : ['shared', 'dlopen'], value: 'shared',\n-\tdescription: 'Linkage method (shared/dlopen) for Mellanox PMDs with ibverbs dependencies.')\n+option('ibverbs_link', type: 'combo', choices : ['static', 'shared', 'dlopen'], value: 'shared',\n+\tdescription: 'Linkage method (static/shared/dlopen) for Mellanox PMDs with ibverbs dependencies.')\n option('include_subdir_arch', type: 'string', value: '',\n \tdescription: 'subdirectory where to install arch-dependent headers')\n option('kernel_dir', type: 'string', value: '',\n", "prefixes": [ "v4", "2/6" ] }