Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 65741,
    "url": "http://patches.dpdk.org/api/patches/65741/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/158146237704.16827.13577826727613048764.stgit@gimli.home/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<158146237704.16827.13577826727613048764.stgit@gimli.home>",
    "list_archive_url": "https://inbox.dpdk.org/dev/158146237704.16827.13577826727613048764.stgit@gimli.home",
    "date": "2020-02-11T23:06:17",
    "name": "[7/7] vfio/pci: Cleanup .probe() exit paths",
    "commit_ref": null,
    "pull_url": null,
    "state": "not-applicable",
    "archived": true,
    "hash": "b71471adae19cf5beb0e7720eadb23dc0e50283e",
    "submitter": {
        "id": 391,
        "url": "http://patches.dpdk.org/api/people/391/?format=api",
        "name": "Alex Williamson",
        "email": "alex.williamson@redhat.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/158146237704.16827.13577826727613048764.stgit@gimli.home/mbox/",
    "series": [
        {
            "id": 8504,
            "url": "http://patches.dpdk.org/api/series/8504/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8504",
            "date": "2020-02-11T23:05:16",
            "name": "vfio/pci: SR-IOV support",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/8504/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/65741/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/65741/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BF185A0530;\n\tWed, 12 Feb 2020 00:06:39 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8B01D2A66;\n\tWed, 12 Feb 2020 00:06:28 +0100 (CET)",
            "from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com\n [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 8D08A2BC7\n for <dev@dpdk.org>; Wed, 12 Feb 2020 00:06:26 +0100 (CET)",
            "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-386-63tPqKG0PkeYD-iktDgy0w-1; Tue, 11 Feb 2020 18:06:22 -0500",
            "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D812800D4C;\n Tue, 11 Feb 2020 23:06:20 +0000 (UTC)",
            "from gimli.home (ovpn-116-28.phx2.redhat.com [10.3.116.28])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 6ED146E40A;\n Tue, 11 Feb 2020 23:06:17 +0000 (UTC)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1581462386;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Zl42YFae7shP7qDZsLmjotiywH2QivsM2n43EHp8HXI=;\n b=Y8t01xnvEEK4qO2oFYdqYX9AH2GbFaaW9rGGLkUhwwiE4iqJ72yoMbHQN1k1uNzRPwmpnq\n GTRqTCcXUrxVdy9qE7JvojFc9P+0Z2jCiZG3+QlBKTYjD/pzHwAa550Y2b8hN58Cpb63bH\n kVe2reOhQsQAx3e7xOIh9+Cp03ye60g=",
        "X-MC-Unique": "63tPqKG0PkeYD-iktDgy0w-1",
        "From": "Alex Williamson <alex.williamson@redhat.com>",
        "To": "kvm@vger.kernel.org",
        "Cc": "linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, dev@dpdk.org,\n mtosatti@redhat.com, thomas@monjalon.net, bluca@debian.org,\n jerinjacobk@gmail.com, bruce.richardson@intel.com, cohuck@redhat.com",
        "Date": "Tue, 11 Feb 2020 16:06:17 -0700",
        "Message-ID": "<158146237704.16827.13577826727613048764.stgit@gimli.home>",
        "In-Reply-To": "<158145472604.16827.15751375540102298130.stgit@gimli.home>",
        "References": "<158145472604.16827.15751375540102298130.stgit@gimli.home>",
        "User-Agent": "StGit/0.19-dirty",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "7bit",
        "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13",
        "Subject": "[dpdk-dev] [PATCH 7/7] vfio/pci: Cleanup .probe() exit paths",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The cleanup is getting a tad long.\n\nSigned-off-by: Alex Williamson <alex.williamson@redhat.com>\n---\n drivers/vfio/pci/vfio_pci.c |   54 ++++++++++++++++++++-----------------------\n 1 file changed, 25 insertions(+), 29 deletions(-)",
    "diff": "diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c\nindex a88b45ce1cc7..fff49dfc742a 100644\n--- a/drivers/vfio/pci/vfio_pci.c\n+++ b/drivers/vfio/pci/vfio_pci.c\n@@ -1520,8 +1520,8 @@ static int vfio_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)\n \n \tvdev = kzalloc(sizeof(*vdev), GFP_KERNEL);\n \tif (!vdev) {\n-\t\tvfio_iommu_group_put(group, &pdev->dev);\n-\t\treturn -ENOMEM;\n+\t\tret = -ENOMEM;\n+\t\tgoto out_group_put;\n \t}\n \n \tvdev->pdev = pdev;\n@@ -1532,43 +1532,27 @@ static int vfio_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)\n \tINIT_LIST_HEAD(&vdev->ioeventfds_list);\n \n \tret = vfio_add_group_dev(&pdev->dev, &vfio_pci_ops, vdev);\n-\tif (ret) {\n-\t\tvfio_iommu_group_put(group, &pdev->dev);\n-\t\tkfree(vdev);\n-\t\treturn ret;\n-\t}\n+\tif (ret)\n+\t\tgoto out_free;\n \n \tret = vfio_pci_reflck_attach(vdev);\n-\tif (ret) {\n-\t\tvfio_del_group_dev(&pdev->dev);\n-\t\tvfio_iommu_group_put(group, &pdev->dev);\n-\t\tkfree(vdev);\n-\t\treturn ret;\n-\t}\n+\tif (ret)\n+\t\tgoto out_del_group_dev;\n \n \tif (pdev->is_physfn) {\n \t\tvdev->vf_token = kzalloc(sizeof(*vdev->vf_token), GFP_KERNEL);\n \t\tif (!vdev->vf_token) {\n-\t\t\tvfio_pci_reflck_put(vdev->reflck);\n-\t\t\tvfio_del_group_dev(&pdev->dev);\n-\t\t\tvfio_iommu_group_put(group, &pdev->dev);\n-\t\t\tkfree(vdev);\n-\t\t\treturn -ENOMEM;\n-\t\t}\n-\n-\t\tvdev->nb.notifier_call = vfio_pci_bus_notifier;\n-\t\tret = bus_register_notifier(&pci_bus_type, &vdev->nb);\n-\t\tif (ret) {\n-\t\t\tkfree(vdev->vf_token);\n-\t\t\tvfio_pci_reflck_put(vdev->reflck);\n-\t\t\tvfio_del_group_dev(&pdev->dev);\n-\t\t\tvfio_iommu_group_put(group, &pdev->dev);\n-\t\t\tkfree(vdev);\n-\t\t\treturn ret;\n+\t\t\tret = -ENOMEM;\n+\t\t\tgoto out_reflck;\n \t\t}\n \n \t\tmutex_init(&vdev->vf_token->lock);\n \t\tuuid_gen(&vdev->vf_token->uuid);\n+\n+\t\tvdev->nb.notifier_call = vfio_pci_bus_notifier;\n+\t\tret = bus_register_notifier(&pci_bus_type, &vdev->nb);\n+\t\tif (ret)\n+\t\t\tgoto out_vf_token;\n \t}\n \n \tif (vfio_pci_is_vga(pdev)) {\n@@ -1594,6 +1578,18 @@ static int vfio_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)\n \t}\n \n \treturn ret;\n+\n+out_vf_token:\n+\tkfree(vdev->vf_token);\n+out_reflck:\n+\tvfio_pci_reflck_put(vdev->reflck);\n+out_del_group_dev:\n+\tvfio_del_group_dev(&pdev->dev);\n+out_free:\n+\tkfree(vdev);\n+out_group_put:\n+\tvfio_iommu_group_put(group, &pdev->dev);\n+\treturn ret;\n }\n \n static void vfio_pci_remove(struct pci_dev *pdev)\n",
    "prefixes": [
        "7/7"
    ]
}