Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65718/?format=api
{ "id": 65718, "url": "http://patches.dpdk.org/api/patches/65718/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200211011942.1569573-6-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200211011942.1569573-6-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200211011942.1569573-6-thomas@monjalon.net", "date": "2020-02-11T01:19:42", "name": "[v3,5/5] net/mlx: fix overlinking with meson and glue dlopen", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "92992fbd06f98d312d44cd719618bf350e3e8730", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200211011942.1569573-6-thomas@monjalon.net/mbox/", "series": [ { "id": 8489, "url": "http://patches.dpdk.org/api/series/8489/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8489", "date": "2020-02-11T01:19:38", "name": "mlx ibverbs linking in meson", "version": 3, "mbox": "http://patches.dpdk.org/series/8489/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65718/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65718/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CE76CA051C;\n\tTue, 11 Feb 2020 02:20:49 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3214A1BFAD;\n\tTue, 11 Feb 2020 02:20:09 +0100 (CET)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7E3F71BFAD;\n Tue, 11 Feb 2020 02:20:08 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id 23C2321A97;\n Mon, 10 Feb 2020 20:20:08 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute1.internal (MEProxy); Mon, 10 Feb 2020 20:20:08 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 0CED2328005D;\n Mon, 10 Feb 2020 20:20:06 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=1qLPOwisO/\n FCB+O0hqC7JvtnYcaJ+LWUemuQao5m/4A=; b=S9vDjBogIyLx+L62nTe/7hz+GY\n QwVZwR+MlYu5UsZ03n+lLhoAywXS/suZJOYRkMMqM+yBMLm0TbT+kaWyUSEfzTsv\n AZksN83ETyGqMv+Gf3ACiXH9u9AVOMp53FufdMufhtijphykSLRMGfbkTLkqyAS6\n 8FouWMl7z0jRb6Jqk=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=1qLPOwisO/FCB+O0hqC7JvtnYcaJ+LWUemuQao5m/4A=; b=r7kkuz/n\n dipcGxFWyoi1czak9GjxlWceBMvWkxT0ACLAKu5PTLyW7Lm1DO4x6RV2V1i75iI4\n 37019OQAtZkRW8PB+D8WeV8zSFAMv4xRDtQYdK7+uB8fYvGDCPBiLC9+5FnSk5qe\n 5vmx29E7igznoni2E6rSen6oxVW8pTRD3iLR1wdGH1aFX32EHvYrul+nLVarBIGU\n zokpmIDdf/+a33P5hPGvnJlpSUWW/UrC7H/pXGl2WG2yBKr/LzdM2fkU5B0z3vS2\n olfCPSHAFWloSwjufROCaugoR0c7W4sPiXyca4hKT9UfO/eNAJhJ8Ie7maaWGW4w\n 6FnVxaUUGRZMiA==" ], "X-ME-Sender": "<xms:RwFCXtmfMie6gJcGunyv5Iq5hs6SRA3qyZhieQDroy_ID3mts-r13w>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedugedriedvgdefvdcutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepgeenucfrrghr\n rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:RwFCXr8HW4nNgJbwNx_nfp_eNyRl-8BdnjaMqdg_Bsg15C-FSHQ95A>\n <xmx:RwFCXhF4DC-nwWsj5f5qas5DlgjBOBCDc1lVJnxh67snIFN1ptAQNA>\n <xmx:RwFCXiLk_LjUYdFKf0KFhbjvXpIw3865s1gmcBZ5T-SbKsfpW9A5iw>\n <xmx:SAFCXiZXPHTB1Z1g_bjkfluADiNdX4FCqMiBeEhWBFcuUY4vOJyfEg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, stable@dpdk.org,\n Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>, =?utf-8?q?N=C3=A9lio_Laran?=\n\t=?utf-8?q?jeiro?= <nelio.laranjeiro@6wind.com>", "Date": "Tue, 11 Feb 2020 02:19:42 +0100", "Message-Id": "<20200211011942.1569573-6-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200211011942.1569573-1-thomas@monjalon.net>", "References": "<20200127154402.4008069-1-thomas@monjalon.net>\n <20200211011942.1569573-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 5/5] net/mlx: fix overlinking with meson and\n\tglue dlopen", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If ibverbs_link is dlopen, the PMD and application should not\nbe linked with ibverbs, but the glue library is.\nUnfortunately the ibverbs dependency was exported in the\nvariable ext_deps, so there were overlinking.\n\nIt is fixed by not exporting the dependency in ext_deps,\nand recreating a limited dependency object for cflags only.\n\nFixes: 1dd7c7e38c19 (\"net/mlx4: support meson build\")\nFixes: 96d7c62a70c7 (\"net/mlx5: support meson build\")\nCc: stable@dpdk.org\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/common/mlx5/meson.build | 6 ++++--\n drivers/net/mlx4/meson.build | 6 ++++--\n 2 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build\nindex 2bb2a83c45..2956fc20e2 100644\n--- a/drivers/common/mlx5/meson.build\n+++ b/drivers/common/mlx5/meson.build\n@@ -30,7 +30,7 @@ foreach libname:libnames\n \tendif\n \tif lib.found()\n \t\tlibs += lib\n-\t\tif not static_ibverbs\n+\t\tif not static_ibverbs and not dlopen_ibverbs\n \t\t\text_deps += lib\n \t\tendif\n \telse\n@@ -38,10 +38,12 @@ foreach libname:libnames\n \t\treason = 'missing dependency, \"' + libname + '\"'\n \tendif\n endforeach\n-if build and static_ibverbs\n+if build and (static_ibverbs or dlopen_ibverbs)\n \t# Build without adding shared libs to Requires.private\n \tibv_cflags = run_command(pkgconf, '--cflags', 'libibverbs').stdout()\n \text_deps += declare_dependency(compile_args: ibv_cflags.split())\n+endif\n+if build and static_ibverbs\n \t# Add static deps ldflags to internal apps and Libs.private\n \tibv_ldflags = run_command(ldflags_ibverbs_static, check:true).stdout()\n \text_deps += declare_dependency(link_args:ibv_ldflags.split())\ndiff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build\nindex 2970f395c1..bcfe5b0890 100644\n--- a/drivers/net/mlx4/meson.build\n+++ b/drivers/net/mlx4/meson.build\n@@ -31,7 +31,7 @@ foreach libname:libnames\n \tendif\n \tif lib.found()\n \t\tlibs += lib\n-\t\tif not static_ibverbs\n+\t\tif not static_ibverbs and not dlopen_ibverbs\n \t\t\text_deps += lib\n \t\tendif\n \telse\n@@ -39,10 +39,12 @@ foreach libname:libnames\n \t\treason = 'missing dependency, \"' + libname + '\"'\n \tendif\n endforeach\n-if build and static_ibverbs\n+if build and (static_ibverbs or dlopen_ibverbs)\n \t# Build without adding shared libs to Requires.private\n \tibv_cflags = run_command(pkgconf, '--cflags', 'libibverbs').stdout()\n \text_deps += declare_dependency(compile_args: ibv_cflags.split())\n+endif\n+if build and static_ibverbs\n \t# Add static deps ldflags to internal apps and Libs.private\n \tibv_ldflags = run_command(ldflags_ibverbs_static, check:true).stdout()\n \text_deps += declare_dependency(link_args:ibv_ldflags.split())\n", "prefixes": [ "v3", "5/5" ] }