Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65689/?format=api
{ "id": 65689, "url": "http://patches.dpdk.org/api/patches/65689/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200210103216.1168439-4-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200210103216.1168439-4-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200210103216.1168439-4-thomas@monjalon.net", "date": "2020-02-10T10:32:16", "name": "[3/3] net/mlx4: fix build with -fno-common", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c8683dafd55f03f2ebb637d3e0bdf921136ba9ef", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200210103216.1168439-4-thomas@monjalon.net/mbox/", "series": [ { "id": 8483, "url": "http://patches.dpdk.org/api/series/8483/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8483", "date": "2020-02-10T10:32:13", "name": "mlx: fix build with -fno-common (gcc 10)", "version": 1, "mbox": "http://patches.dpdk.org/series/8483/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65689/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/65689/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86FBFA052F;\n\tMon, 10 Feb 2020 11:32:51 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 042CC1BF9E;\n\tMon, 10 Feb 2020 11:32:35 +0100 (CET)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 245832BD5\n for <dev@dpdk.org>; Mon, 10 Feb 2020 11:32:33 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id C57E621C4E;\n Mon, 10 Feb 2020 05:32:32 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute1.internal (MEProxy); Mon, 10 Feb 2020 05:32:32 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 29FDA328005D;\n Mon, 10 Feb 2020 05:32:32 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=6O7TbM4LSu\n fHGgME1DtddBi28yoK1IJKU+ZTORYGufQ=; b=kGmK8q6zi09LOZzqHu6jHbo7Ae\n wOmnodshhrWZwQvPnkJeLeej3Db4Gf2xJ0WNwiRKInxiQfy5SHfYzOI0R/b9xvm5\n wxSTV+6Jto1VXiCQCvcQbqzPqQ4exAt6lWfci6nmQf5c6Tif36fc6JIHBapC5de5\n W9GBVCAOsFsEZ9LgM=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=6O7TbM4LSufHGgME1DtddBi28yoK1IJKU+ZTORYGufQ=; b=E1HGAB4O\n KzCdCqLjQv1YuJA/O26PzfErj8ZTnU2gFgbLBkNkgW1c2uvdqHPyOvp1NpzcOSev\n 9OPLTTROMBQC9sW+R+T4v+SPoc5stevD3cDcn8OCOg6vNqCPoo7kcdEEqgO94ITV\n 6vWzAgcDIFNj46xlDun7Gl1IdF6Y4YyekFhwzm+6N+XFf8XfN4LvVFDU8z4T/ewk\n kQMREadzqZOvBHKXmXpA68lr6agUBcDGmF4zfzkL33b0RgFYLMg2CzuBSFqU0qGK\n ZfghiQn/D7T5T2i3S7B77OSBRRGz/w7eN/Jj8qD0K/QryJSQXOGaUR5fvpDQvTPc\n WA6z2WtVubyiRg==" ], "X-ME-Sender": "<xms:QDFBXroVyb74Qr9siOhWqF0J3sfiBWPJlRWKrTmZkI5D3LIf_SGuzQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedugedriedugdduiecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepudenucfrrghr\n rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:QDFBXiYG5tXB4RwBPcJkdcjliTr5Dv74Rb0fIKs3oNr8ph0NO7Do2Q>\n <xmx:QDFBXixCE7aQCupiiUk61Yk4P3viOxZ0sQfGq42HJH9RHj1bqMmjVw>\n <xmx:QDFBXiJvNAhQqQkRj1Dd7r1rf8V0ZOFZ1CEIGZxdqYYumZ3mojwopg>\n <xmx:QDFBXoejuh21ItXhp8XDHVSbbIfrlOgu7e2W63BWacMeuS4K_tkPQw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "Matan Azrad <matan@mellanox.com>,\n\tShahaf Shuler <shahafs@mellanox.com>", "Date": "Mon, 10 Feb 2020 11:32:16 +0100", "Message-Id": "<20200210103216.1168439-4-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200210103216.1168439-1-thomas@monjalon.net>", "References": "<20200210103216.1168439-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/3] net/mlx4: fix build with -fno-common", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The variable storages of the same name are merged together\nif compiled with -fcommon. This is the default.\nThis default behaviour allows to declare a variable in a header file\nand share the variable in every .o binaries thanks to merge at link-time.\n\nIn the case of dlopen linking of the glue library, the pointer mlx4_glue\nis referencing the glue functions struct and is set after calling dlopen.\n\nIf compiling with -fno-common (default in GCC 10), the variables\nmust be declared as extern to avoid multiple re-definitions.\nIn case the glue layer is split in glue library, the variable mlx4_glue\nneeds to have its own storage for the rest of the PMD.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/mlx4/mlx4.c | 4 ++++\n drivers/net/mlx4/mlx4_glue.h | 2 +-\n drivers/net/mlx4/mlx4_rxtx.h | 2 +-\n 3 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex a1dd658176..49e721df5f 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -47,6 +47,10 @@\n #include \"mlx4_rxtx.h\"\n #include \"mlx4_utils.h\"\n \n+#ifdef MLX4_GLUE\n+const struct mlx4_glue *mlx4_glue = NULL;\n+#endif\n+\n static const char *MZ_MLX4_PMD_SHARED_DATA = \"mlx4_pmd_shared_data\";\n \n /* Shared memory between primary and secondary processes. */\ndiff --git a/drivers/net/mlx4/mlx4_glue.h b/drivers/net/mlx4/mlx4_glue.h\nindex 668ca86700..5d9e985495 100644\n--- a/drivers/net/mlx4/mlx4_glue.h\n+++ b/drivers/net/mlx4/mlx4_glue.h\n@@ -84,6 +84,6 @@ struct mlx4_glue {\n \t\t\t\t void *attr);\n };\n \n-const struct mlx4_glue *mlx4_glue;\n+extern const struct mlx4_glue *mlx4_glue;\n \n #endif /* MLX4_GLUE_H_ */\ndiff --git a/drivers/net/mlx4/mlx4_rxtx.h b/drivers/net/mlx4/mlx4_rxtx.h\nindex 8baf33fa94..9de6c59411 100644\n--- a/drivers/net/mlx4/mlx4_rxtx.h\n+++ b/drivers/net/mlx4/mlx4_rxtx.h\n@@ -124,7 +124,7 @@ struct txq {\n \n /* mlx4_rxq.c */\n \n-uint8_t mlx4_rss_hash_key_default[MLX4_RSS_HASH_KEY_SIZE];\n+extern uint8_t mlx4_rss_hash_key_default[MLX4_RSS_HASH_KEY_SIZE];\n int mlx4_rss_init(struct mlx4_priv *priv);\n void mlx4_rss_deinit(struct mlx4_priv *priv);\n struct mlx4_rss *mlx4_rss_get(struct mlx4_priv *priv, uint64_t fields,\n", "prefixes": [ "3/3" ] }