Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65651/?format=api
{ "id": 65651, "url": "http://patches.dpdk.org/api/patches/65651/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200207031437.9124-8-pallavi.kadam@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200207031437.9124-8-pallavi.kadam@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200207031437.9124-8-pallavi.kadam@intel.com", "date": "2020-02-07T03:14:35", "name": "[v8,7/9] eal: remove syslog and dlfcn support for windows", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "96488a72701419813f114041428fa6b93d917b30", "submitter": { "id": 1177, "url": "http://patches.dpdk.org/api/people/1177/?format=api", "name": "Kadam, Pallavi", "email": "pallavi.kadam@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200207031437.9124-8-pallavi.kadam@intel.com/mbox/", "series": [ { "id": 8457, "url": "http://patches.dpdk.org/api/series/8457/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8457", "date": "2020-02-07T03:14:28", "name": "Windows patchset with additional EAL functionalities", "version": 8, "mbox": "http://patches.dpdk.org/series/8457/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65651/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65651/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 496E1A0541;\n\tFri, 7 Feb 2020 04:17:08 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 60BDC1C121;\n\tFri, 7 Feb 2020 04:16:11 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 273971C06A\n for <dev@dpdk.org>; Fri, 7 Feb 2020 04:15:54 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 06 Feb 2020 19:15:54 -0800", "from win-dpdk-pallavi.jf.intel.com (HELO localhost.localdomain)\n ([10.166.188.75])\n by orsmga005.jf.intel.com with ESMTP; 06 Feb 2020 19:15:53 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,411,1574150400\"; d=\"scan'208\";a=\"404693011\"", "From": "Pallavi Kadam <pallavi.kadam@intel.com>", "To": "dev@dpdk.org,\n\tthomas@monjalon.net", "Cc": "Harini.Ramakrishnan@microsoft.com, keith.wiles@intel.com,\n bruce.richardson@intel.com, david.marchand@redhat.com,\n jerinjacobk@gmail.com, ranjit.menon@intel.com,\n antara.ganesh.kolar@intel.com, pallavi.kadam@intel.com", "Date": "Thu, 6 Feb 2020 19:14:35 -0800", "Message-Id": "<20200207031437.9124-8-pallavi.kadam@intel.com>", "X-Mailer": "git-send-email 2.18.0.windows.1", "In-Reply-To": "<20200207031437.9124-1-pallavi.kadam@intel.com>", "References": "<20200201000406.11060-1-pallavi.kadam@intel.com>\n <20200207031437.9124-1-pallavi.kadam@intel.com>", "Subject": "[dpdk-dev] [PATCH v8 7/9] eal: remove syslog and dlfcn support for\n\twindows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Excluding syslog/ dlfcn definitions and parameters\nfrom Windows by adding #ifndef RTE_EXEC_ENV_WINDOWS.\n\nNote: This is a temporary change. In future, separate\n'unix' directory will be created for unix specific functions.\n\nSigned-off-by: Pallavi Kadam <pallavi.kadam@intel.com>\nReviewed-by: Ranjit Menon <ranjit.menon@intel.com>\n---\n lib/librte_eal/common/eal_common_options.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 5920233bc..75974dd5b 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -6,12 +6,16 @@\n #include <stdlib.h>\n #include <unistd.h>\n #include <string.h>\n+#ifndef RTE_EXEC_ENV_WINDOWS\n #include <syslog.h>\n+#endif\n #include <ctype.h>\n #include <limits.h>\n #include <errno.h>\n #include <getopt.h>\n+#ifndef RTE_EXEC_ENV_WINDOWS\n #include <dlfcn.h>\n+#endif\n #include <sys/types.h>\n #include <sys/stat.h>\n #include <dirent.h>\n@@ -205,7 +209,9 @@ eal_reset_internal_config(struct internal_config *internal_cfg)\n \t}\n \tinternal_cfg->base_virtaddr = 0;\n \n+#ifdef LOG_DAEMON\n \tinternal_cfg->syslog_facility = LOG_DAEMON;\n+#endif\n \n \t/* if set to NONE, interrupt mode is determined automatically */\n \tinternal_cfg->vfio_intr_mode = RTE_INTR_MODE_NONE;\n@@ -278,6 +284,7 @@ eal_plugindir_init(const char *path)\n int\n eal_plugins_init(void)\n {\n+#ifndef RTE_EXEC_ENV_WINDOWS\n \tstruct shared_driver *solib = NULL;\n \tstruct stat sb;\n \n@@ -306,6 +313,7 @@ eal_plugins_init(void)\n \n \t}\n \treturn 0;\n+#endif\n }\n \n /*\n@@ -927,6 +935,7 @@ eal_parse_lcores(const char *lcores)\n \treturn ret;\n }\n \n+#ifndef RTE_EXEC_ENV_WINDOWS\n static int\n eal_parse_syslog(const char *facility, struct internal_config *conf)\n {\n@@ -965,6 +974,7 @@ eal_parse_syslog(const char *facility, struct internal_config *conf)\n \t}\n \treturn -1;\n }\n+#endif\n \n static int\n eal_parse_log_priority(const char *level)\n@@ -1389,6 +1399,7 @@ eal_parse_common_option(int opt, const char *optarg,\n \t\t}\n \t\tbreak;\n \n+#ifndef RTE_EXEC_ENV_WINDOWS\n \tcase OPT_SYSLOG_NUM:\n \t\tif (eal_parse_syslog(optarg, conf) < 0) {\n \t\t\tRTE_LOG(ERR, EAL, \"invalid parameters for --\"\n@@ -1396,6 +1407,7 @@ eal_parse_common_option(int opt, const char *optarg,\n \t\t\treturn -1;\n \t\t}\n \t\tbreak;\n+#endif\n \n \tcase OPT_LOG_LEVEL_NUM: {\n \t\tif (eal_parse_log_level(optarg) < 0) {\n@@ -1675,7 +1687,9 @@ eal_common_usage(void)\n \t \" (can be used multiple times)\\n\"\n \t \" --\"OPT_VMWARE_TSC_MAP\" Use VMware TSC map instead of native RDTSC\\n\"\n \t \" --\"OPT_PROC_TYPE\" Type of this process (primary|secondary|auto)\\n\"\n+#ifndef RTE_EXEC_ENV_WINDOWS\n \t \" --\"OPT_SYSLOG\" Set syslog facility\\n\"\n+#endif\n \t \" --\"OPT_LOG_LEVEL\"=<int> Set global log level\\n\"\n \t \" --\"OPT_LOG_LEVEL\"=<type-match>:<int>\\n\"\n \t \" Set specific log level\\n\"\n", "prefixes": [ "v8", "7/9" ] }