Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65647/?format=api
{ "id": 65647, "url": "http://patches.dpdk.org/api/patches/65647/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200207031437.9124-4-pallavi.kadam@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200207031437.9124-4-pallavi.kadam@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200207031437.9124-4-pallavi.kadam@intel.com", "date": "2020-02-07T03:14:31", "name": "[v8,3/9] eal: add additional function overrides in windows header files", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "af6df79deed399002249e5c7f621698ba141e877", "submitter": { "id": 1177, "url": "http://patches.dpdk.org/api/people/1177/?format=api", "name": "Kadam, Pallavi", "email": "pallavi.kadam@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200207031437.9124-4-pallavi.kadam@intel.com/mbox/", "series": [ { "id": 8457, "url": "http://patches.dpdk.org/api/series/8457/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8457", "date": "2020-02-07T03:14:28", "name": "Windows patchset with additional EAL functionalities", "version": 8, "mbox": "http://patches.dpdk.org/series/8457/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65647/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65647/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B2835A0541;\n\tFri, 7 Feb 2020 04:16:27 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 220891C0C6;\n\tFri, 7 Feb 2020 04:16:05 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 4853E1C069\n for <dev@dpdk.org>; Fri, 7 Feb 2020 04:15:56 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 06 Feb 2020 19:15:53 -0800", "from win-dpdk-pallavi.jf.intel.com (HELO localhost.localdomain)\n ([10.166.188.75])\n by orsmga005.jf.intel.com with ESMTP; 06 Feb 2020 19:15:53 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,411,1574150400\"; d=\"scan'208\";a=\"404692998\"", "From": "Pallavi Kadam <pallavi.kadam@intel.com>", "To": "dev@dpdk.org,\n\tthomas@monjalon.net", "Cc": "Harini.Ramakrishnan@microsoft.com, keith.wiles@intel.com,\n bruce.richardson@intel.com, david.marchand@redhat.com,\n jerinjacobk@gmail.com, ranjit.menon@intel.com,\n antara.ganesh.kolar@intel.com, pallavi.kadam@intel.com", "Date": "Thu, 6 Feb 2020 19:14:31 -0800", "Message-Id": "<20200207031437.9124-4-pallavi.kadam@intel.com>", "X-Mailer": "git-send-email 2.18.0.windows.1", "In-Reply-To": "<20200207031437.9124-1-pallavi.kadam@intel.com>", "References": "<20200201000406.11060-1-pallavi.kadam@intel.com>\n <20200207031437.9124-1-pallavi.kadam@intel.com>", "Subject": "[dpdk-dev] [PATCH v8 3/9] eal: add additional function overrides in\n\twindows header files", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adding additional function definitions for pthread, cpuset\nimplementation, asprintf implementation, in order to support\ncommon code.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Pallavi Kadam <pallavi.kadam@intel.com>\nReviewed-by: Ranjit Menon <ranjit.menon@intel.com>\nReviewed-by: Keith Wiles <keith.wiles@intel.com>\n---\n lib/librte_eal/windows/eal/include/pthread.h | 66 +++++++++++++++++++\n lib/librte_eal/windows/eal/include/rte_os.h | 42 ++++++++++++\n lib/librte_eal/windows/eal/include/sched.h | 46 +++++++++++++\n .../windows/eal/include/sys/queue.h | 8 +++\n 4 files changed, 162 insertions(+)", "diff": "diff --git a/lib/librte_eal/windows/eal/include/pthread.h b/lib/librte_eal/windows/eal/include/pthread.h\nindex 503329266..4ac24de0a 100644\n--- a/lib/librte_eal/windows/eal/include/pthread.h\n+++ b/lib/librte_eal/windows/eal/include/pthread.h\n@@ -14,12 +14,78 @@\n extern \"C\" {\n #endif\n \n+#include <Windows.h>\n+\n+#define PTHREAD_BARRIER_SERIAL_THREAD TRUE\n+\n /* defining pthread_t type on Windows since there is no in Microsoft libc*/\n typedef uintptr_t pthread_t;\n \n /* defining pthread_attr_t type on Windows since there is no in Microsoft libc*/\n typedef void *pthread_attr_t;\n \n+typedef SYNCHRONIZATION_BARRIER pthread_barrier_t;\n+\n+#define pthread_barrier_init(barrier, attr, count) \\\n+\tInitializeSynchronizationBarrier(barrier, count, -1)\n+#define pthread_barrier_wait(barrier) EnterSynchronizationBarrier(barrier, \\\n+\tSYNCHRONIZATION_BARRIER_FLAGS_BLOCK_ONLY)\n+#define pthread_barrier_destroy(barrier) \\\n+\tDeleteSynchronizationBarrier(barrier)\n+#define pthread_cancel(thread) TerminateThread((HANDLE) thread, 0)\n+\n+/* pthread function overrides */\n+#define pthread_self() \\\n+\t((pthread_t)GetCurrentThreadId())\n+#define pthread_setaffinity_np(thread, size, cpuset) \\\n+\teal_set_thread_affinity_mask(thread, (unsigned long *) cpuset)\n+#define pthread_getaffinity_np(thread, size, cpuset) \\\n+\teal_get_thread_affinity_mask(thread, (unsigned long *) cpuset)\n+#define pthread_create(threadid, threadattr, threadfunc, args) \\\n+\teal_create_thread(threadid, threadfunc, args)\n+\n+static inline int\n+eal_set_thread_affinity_mask(pthread_t threadid, unsigned long *cpuset)\n+{\n+\tSetThreadAffinityMask((HANDLE) threadid, *cpuset);\n+\treturn 0;\n+}\n+\n+static inline int\n+eal_get_thread_affinity_mask(pthread_t threadid, unsigned long *cpuset)\n+{\n+\t/* Workaround for the lack of a GetThreadAffinityMask()\n+\t *API in Windows\n+\t */\n+\t\t/* obtain previous mask by setting dummy mask */\n+\tDWORD dwprevaffinitymask =\n+\t\tSetThreadAffinityMask((HANDLE) threadid, 0x1);\n+\t/* set it back! */\n+\tSetThreadAffinityMask((HANDLE) threadid, dwprevaffinitymask);\n+\t*cpuset = dwprevaffinitymask;\n+\treturn 0;\n+}\n+\n+static inline int\n+eal_create_thread(void *threadid, void *threadfunc, void *args)\n+{\n+\tHANDLE hThread;\n+\thThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)threadfunc,\n+\t\targs, 0, (LPDWORD)threadid);\n+\tif (hThread) {\n+\t\tSetPriorityClass(GetCurrentProcess(), REALTIME_PRIORITY_CLASS);\n+\t\tSetThreadPriority(hThread, THREAD_PRIORITY_TIME_CRITICAL);\n+\t}\n+\treturn ((hThread != NULL) ? 0 : E_FAIL);\n+}\n+\n+static inline int\n+pthread_join(pthread_t thread __attribute__((__unused__)),\n+\tvoid **value_ptr __attribute__((__unused__)))\n+{\n+\treturn 0;\n+}\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_eal/windows/eal/include/rte_os.h b/lib/librte_eal/windows/eal/include/rte_os.h\nindex fdeae0c8f..9e762617b 100644\n--- a/lib/librte_eal/windows/eal/include/rte_os.h\n+++ b/lib/librte_eal/windows/eal/include/rte_os.h\n@@ -18,6 +18,13 @@ extern \"C\" {\n #include <Windows.h>\n #include <BaseTsd.h>\n #include <pthread.h>\n+#include <stdio.h>\n+\n+/* limits.h replacement */\n+#include <stdlib.h>\n+#ifndef PATH_MAX\n+#define PATH_MAX _MAX_PATH\n+#endif\n \n #define strerror_r(a, b, c) strerror_s(b, c, a)\n \n@@ -28,6 +35,11 @@ typedef SSIZE_T ssize_t;\n \n #define strtok_r(str, delim, saveptr) strtok_s(str, delim, saveptr)\n \n+#define index(a, b) strchr(a, b)\n+#define rindex(a, b) strrchr(a, b)\n+\n+#define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count)\n+\n /**\n * Create a thread.\n * This function is private to EAL.\n@@ -45,6 +57,36 @@ int eal_thread_create(pthread_t *thread);\n */\n void eal_create_cpu_map(void);\n \n+static inline int\n+asprintf(char **buffer, const char *format, ...)\n+{\n+\tint size, ret;\n+\tva_list arg;\n+\n+\tva_start(arg, format);\n+\tsize = vsnprintf(NULL, 0, format, arg) + 1;\n+\tva_end(arg);\n+\n+\t*buffer = malloc(size);\n+\tif (buffer == NULL)\n+\t\tprintf(\"Cannot allocate memory\");\n+\n+\tva_start(arg, format);\n+\tret = vsnprintf(*buffer, size, format, arg);\n+\tva_end(arg);\n+\tif (ret != size - 1) {\n+\t\tfree(*buffer);\n+\t\treturn -1;\n+\t}\n+\treturn ret;\n+}\n+\n+/* cpu_set macros implementation */\n+#define RTE_CPU_AND(dst, src1, src2) CPU_AND(dst, src1, src2)\n+#define RTE_CPU_OR(dst, src1, src2) CPU_OR(dst, src1, src2)\n+#define RTE_CPU_FILL(set) CPU_FILL(set)\n+#define RTE_CPU_NOT(dst, src) CPU_NOT(dst, src)\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_eal/windows/eal/include/sched.h b/lib/librte_eal/windows/eal/include/sched.h\nindex 29868c93d..fbe07f742 100644\n--- a/lib/librte_eal/windows/eal/include/sched.h\n+++ b/lib/librte_eal/windows/eal/include/sched.h\n@@ -39,6 +39,52 @@ typedef struct _rte_cpuset_s {\n \t\t\t(s)->_bits[_i] = 0LL;\t\t\t\t\\\n \t} while (0)\n \n+#define CPU_ISSET(b, s) (((s)->_bits[_WHICH_SET(b)] & \\\n+\t(1LL << _WHICH_BIT(b))) != 0LL)\n+\n+static inline int\n+count_cpu(rte_cpuset_t *s)\n+{\n+\tunsigned int _i;\n+\tint count = 0;\n+\n+\tfor (_i = 0; _i < _NUM_SETS(CPU_SETSIZE); _i++)\n+\t\tif (CPU_ISSET(_i, s) != 0LL)\n+\t\t\tcount++;\n+\treturn count;\n+}\n+#define CPU_COUNT(s) count_cpu(s)\n+\n+#define CPU_AND(dst, src1, src2) \\\n+do { \\\n+\tunsigned int _i; \\\n+\t\\\n+\tfor (_i = 0; _i < _NUM_SETS(CPU_SETSIZE); _i++) \\\n+\t\t(dst)->_bits[_i] = (src1)->_bits[_i] & (src2)->_bits[_i]; \\\n+} while (0)\n+\n+#define CPU_OR(dst, src1, src2) \\\n+do { \\\n+\tunsigned int _i; \\\n+\t\\\n+\tfor (_i = 0; _i < _NUM_SETS(CPU_SETSIZE); _i++) \\\n+\t\t(dst)->_bits[_i] = (src1)->_bits[_i] | (src2)->_bits[_i]; \\\n+} while (0)\n+\n+#define CPU_FILL(s) \\\n+do { \\\n+\tunsigned int _i; \\\n+\tfor (_i = 0; _i < _NUM_SETS(CPU_SETSIZE); _i++) \\\n+\t\t(s)->_bits[_i] = -1LL; \\\n+} while (0)\n+\n+#define CPU_NOT(dst, src) \\\n+do { \\\n+\tunsigned int _i; \\\n+\tfor (_i = 0; _i < _NUM_SETS(CPU_SETSIZE); _i++) \\\n+\t\t(dst)->_bits[_i] = (src)->_bits[_i] ^ -1LL; \\\n+} while (0)\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_eal/windows/eal/include/sys/queue.h b/lib/librte_eal/windows/eal/include/sys/queue.h\nindex 6b9446a17..a65949a78 100644\n--- a/lib/librte_eal/windows/eal/include/sys/queue.h\n+++ b/lib/librte_eal/windows/eal/include/sys/queue.h\n@@ -59,6 +59,14 @@\n extern \"C\" {\n #endif\n \n+/*\n+ * List definitions.\n+ */\n+#define\tLIST_HEAD(name, type)\t\t\t\t\t\t\\\n+struct name {\t\t\t\t\t\t\t\t\\\n+\tstruct type *lh_first;\t/* first element */\t\t\t\\\n+}\n+\n #define\tQMD_TRACE_ELEM(elem)\n #define\tQMD_TRACE_HEAD(head)\n #define\tTRACEBUF\n", "prefixes": [ "v8", "3/9" ] }