Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65639/?format=api
{ "id": 65639, "url": "http://patches.dpdk.org/api/patches/65639/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200206184432.34360-7-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200206184432.34360-7-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200206184432.34360-7-ajit.khaparde@broadcom.com", "date": "2020-02-06T18:44:31", "name": "[v2,6/7] net/bnxt: move locally used functions to static", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "16303bfb2e705bcec78e52b9b86de2826422705d", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200206184432.34360-7-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 8453, "url": "http://patches.dpdk.org/api/series/8453/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8453", "date": "2020-02-06T18:44:25", "name": "bnxt patchset with bug fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/8453/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65639/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65639/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B40ECA0541;\n\tThu, 6 Feb 2020 19:45:44 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7830B1C21E;\n\tThu, 6 Feb 2020 19:44:51 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 417801C1CC\n for <dev@dpdk.org>; Thu, 6 Feb 2020 19:44:39 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id D016830C0C5;\n Thu, 6 Feb 2020 10:37:16 -0800 (PST)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n [10.69.74.102])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 5E4AA14008C;\n Thu, 6 Feb 2020 10:44:36 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com D016830C0C5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1581014236;\n bh=M0kd+aOyABr/Swb7I/oDe1o05y2h20O6Nvzb4s8zmIU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=EOT/HdcfPLpkI+mjtn+hz+eeFoYJqXvLPR0S4YXuys1pyGr2ysBgMWslotRMZKGt7\n 4+9A0uTWy8xsY+wglWJL6lx58rCxgZ+b+isNkoMddrI+SLP+8jAbFepreTlbRwnPxJ\n Y9yvYtv3E6+011mXXdo2zTN6XtYtQbSsLYL5/W6M=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tKalesh AP <kalesh-anakkur.purayil@broadcom.com>", "Date": "Thu, 6 Feb 2020 10:44:31 -0800", "Message-Id": "<20200206184432.34360-7-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200206184432.34360-1-ajit.khaparde@broadcom.com>", "References": "<20200206163314.12755-1-kalesh-anakkur.purayil@broadcom.com>\n <20200206184432.34360-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 6/7] net/bnxt: move locally used functions to\n\tstatic", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nbnxt_rss_ctxts() function is declared in header file bnxt.h,\nimplemented in bnxt_ethdev.c, and called only in bnxt_ethdev.c.\n\nAlso many functions are declared in header file bnxt_hwrm.h,\nimplemented in bnxt_hwrm.c, and called only in bnxt_hwrm.c.\n\nThis patch moves these function declarations into bnxt_ethdev.c\nand bnxt_hwrm.c, as static functions.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 -\n drivers/net/bnxt/bnxt_ethdev.c | 2 +-\n drivers/net/bnxt/bnxt_hwrm.c | 15 ++++++++++-----\n drivers/net/bnxt/bnxt_hwrm.h | 5 -----\n 4 files changed, 11 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex e8a30fa31..3ae08a2ed 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -686,7 +686,6 @@ int bnxt_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete,\n \t\t bool exp_link_status);\n int bnxt_rcv_msg_from_vf(struct bnxt *bp, uint16_t vf_id, void *msg);\n int is_bnxt_in_error(struct bnxt *bp);\n-uint16_t bnxt_rss_ctxts(const struct bnxt *bp);\n \n int bnxt_map_fw_health_status_regs(struct bnxt *bp);\n uint32_t bnxt_read_fw_status_reg(struct bnxt *bp, uint32_t index);\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 3c40f4b59..18aa313fd 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -150,7 +150,7 @@ int is_bnxt_in_error(struct bnxt *bp)\n * High level utility functions\n */\n \n-uint16_t bnxt_rss_ctxts(const struct bnxt *bp)\n+static uint16_t bnxt_rss_ctxts(const struct bnxt *bp)\n {\n \tif (!BNXT_CHIP_THOR(bp))\n \t\treturn 1;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 4d99d824e..acecf2784 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -2254,7 +2254,8 @@ int bnxt_clear_all_hwrm_stat_ctxs(struct bnxt *bp)\n \treturn 0;\n }\n \n-int bnxt_free_all_hwrm_stat_ctxs(struct bnxt *bp)\n+static int\n+bnxt_free_all_hwrm_stat_ctxs(struct bnxt *bp)\n {\n \tint rc;\n \tunsigned int i;\n@@ -2305,7 +2306,8 @@ int bnxt_alloc_all_hwrm_stat_ctxs(struct bnxt *bp)\n \treturn rc;\n }\n \n-int bnxt_free_all_hwrm_ring_grps(struct bnxt *bp)\n+static int\n+bnxt_free_all_hwrm_ring_grps(struct bnxt *bp)\n {\n \tuint16_t idx;\n \tuint32_t rc = 0;\n@@ -2396,7 +2398,8 @@ void bnxt_free_hwrm_rx_ring(struct bnxt *bp, int queue_index)\n \t\tbp->grp_info[queue_index].cp_fw_ring_id = INVALID_HW_RING_ID;\n }\n \n-int bnxt_free_all_hwrm_rings(struct bnxt *bp)\n+static int\n+bnxt_free_all_hwrm_rings(struct bnxt *bp)\n {\n \tunsigned int i;\n \n@@ -2485,7 +2488,8 @@ int bnxt_alloc_hwrm_resources(struct bnxt *bp)\n \treturn 0;\n }\n \n-int bnxt_clear_hwrm_vnic_filters(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n+static int\n+bnxt_clear_hwrm_vnic_filters(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n {\n \tstruct bnxt_filter_info *filter;\n \tint rc = 0;\n@@ -2546,7 +2550,8 @@ int bnxt_set_hwrm_vnic_filters(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n \treturn rc;\n }\n \n-void bnxt_free_tunnel_ports(struct bnxt *bp)\n+static void\n+bnxt_free_tunnel_ports(struct bnxt *bp)\n {\n \tif (bp->vxlan_port_cnt)\n \t\tbnxt_hwrm_tunnel_dst_port_free(bp, bp->vxlan_fw_dst_port_id,\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h\nindex 56a851b8a..5eb2ee883 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.h\n+++ b/drivers/net/bnxt/bnxt_hwrm.h\n@@ -142,14 +142,10 @@ int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp,\n \n int bnxt_alloc_all_hwrm_stat_ctxs(struct bnxt *bp);\n int bnxt_clear_all_hwrm_stat_ctxs(struct bnxt *bp);\n-int bnxt_free_all_hwrm_stat_ctxs(struct bnxt *bp);\n-int bnxt_free_all_hwrm_rings(struct bnxt *bp);\n-int bnxt_free_all_hwrm_ring_grps(struct bnxt *bp);\n int bnxt_alloc_all_hwrm_ring_grps(struct bnxt *bp);\n void bnxt_free_cp_ring(struct bnxt *bp, struct bnxt_cp_ring_info *cpr);\n void bnxt_free_nq_ring(struct bnxt *bp, struct bnxt_cp_ring_info *cpr);\n int bnxt_set_hwrm_vnic_filters(struct bnxt *bp, struct bnxt_vnic_info *vnic);\n-int bnxt_clear_hwrm_vnic_filters(struct bnxt *bp, struct bnxt_vnic_info *vnic);\n void bnxt_free_all_hwrm_resources(struct bnxt *bp);\n void bnxt_free_hwrm_resources(struct bnxt *bp);\n void bnxt_free_hwrm_rx_ring(struct bnxt *bp, int queue_index);\n@@ -174,7 +170,6 @@ int bnxt_hwrm_tunnel_dst_port_alloc(struct bnxt *bp, uint16_t port,\n \t\t\t\tuint8_t tunnel_type);\n int bnxt_hwrm_tunnel_dst_port_free(struct bnxt *bp, uint16_t port,\n \t\t\t\tuint8_t tunnel_type);\n-void bnxt_free_tunnel_ports(struct bnxt *bp);\n int bnxt_hwrm_set_default_vlan(struct bnxt *bp, int vf, uint8_t is_vf);\n int bnxt_hwrm_port_qstats(struct bnxt *bp);\n int bnxt_hwrm_port_clr_stats(struct bnxt *bp);\n", "prefixes": [ "v2", "6/7" ] }