Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65637/?format=api
http://patches.dpdk.org/api/patches/65637/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200206184432.34360-6-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200206184432.34360-6-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200206184432.34360-6-ajit.khaparde@broadcom.com", "date": "2020-02-06T18:44:30", "name": "[v2,5/7] net/bnxt: fix to call port stop when error recovery fails", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a1d13cd658e190f2050cdcfdad8060903ddf7302", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200206184432.34360-6-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 8453, "url": "http://patches.dpdk.org/api/series/8453/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8453", "date": "2020-02-06T18:44:25", "name": "bnxt patchset with bug fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/8453/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65637/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65637/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E284A0541;\n\tThu, 6 Feb 2020 19:45:26 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 87A741C20A;\n\tThu, 6 Feb 2020 19:44:48 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 412F31C1C7;\n Thu, 6 Feb 2020 19:44:39 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id B917630C114;\n Thu, 6 Feb 2020 10:37:16 -0800 (PST)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n [10.69.74.102])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 3C19414008B;\n Thu, 6 Feb 2020 10:44:36 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com B917630C114", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1581014236;\n bh=VGRNYEp0XdbQD+uHRN2tu3G8neHjAa6W/N9RV0b+Y9M=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=NBFNMnXVArRpiMRE9+nqRcump+nPTbk3pOc8O9SuFs5gYHOAIy4x1xLCT0H4lso6+\n rzI6XeAXeLGuytwqcTmU0EGqJpFUJ6gRX6yuZOIzlSvasEtVK2CTPEiKENcveWvlN3\n FnJhUSl/JQbOfsiAvMU4os6YmQor2FyadGG17oqk=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,\n stable@dpdk.org, Somnath Kotur <somnath.kotur@broadcom.com>,\n Rahul Gupta <rahul.gupta@broadcom.com>", "Date": "Thu, 6 Feb 2020 10:44:30 -0800", "Message-Id": "<20200206184432.34360-6-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200206184432.34360-1-ajit.khaparde@broadcom.com>", "References": "<20200206163314.12755-1-kalesh-anakkur.purayil@broadcom.com>\n <20200206184432.34360-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 5/7] net/bnxt: fix to call port stop when\n\terror recovery fails", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nDuring live FW upgrade or error recovery, if restoring the filter\nsettings fail after port start, driver invokes bnxt_uninit_resources()\nonly. Fix it to invoke bnxt_dev_stop_op() first before calling\nbnxt_uninit_resources().\n\nFixes: df6cd7c1f73a (\"net/bnxt: handle reset notify async event from FW\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 7147cc8fe..3c40f4b59 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -4022,15 +4022,17 @@ static void bnxt_dev_recover(void *arg)\n \trc = bnxt_dev_start_op(bp->eth_dev);\n \tif (rc) {\n \t\tPMD_DRV_LOG(ERR, \"Failed to start port after reset\\n\");\n-\t\tgoto err;\n+\t\tgoto err_start;\n \t}\n \n \trc = bnxt_restore_filters(bp);\n \tif (rc)\n-\t\tgoto err;\n+\t\tgoto err_start;\n \n \tPMD_DRV_LOG(INFO, \"Recovered from FW reset\\n\");\n \treturn;\n+err_start:\n+\tbnxt_dev_stop_op(bp->eth_dev);\n err:\n \tbp->flags |= BNXT_FLAG_FATAL_ERROR;\n \tbnxt_uninit_resources(bp, false);\n", "prefixes": [ "v2", "5/7" ] }{ "id": 65637, "url": "