Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65636/?format=api
{ "id": 65636, "url": "http://patches.dpdk.org/api/patches/65636/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200206184432.34360-3-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200206184432.34360-3-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200206184432.34360-3-ajit.khaparde@broadcom.com", "date": "2020-02-06T18:44:27", "name": "[v2,2/7] net/bnxt: fix default timeout for command to get FW version", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9146e604e60364f02b01a63a5a63f67e044affe5", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200206184432.34360-3-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 8453, "url": "http://patches.dpdk.org/api/series/8453/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8453", "date": "2020-02-06T18:44:25", "name": "bnxt patchset with bug fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/8453/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65636/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65636/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 715D8A0541;\n\tThu, 6 Feb 2020 19:45:17 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4466F1C203;\n\tThu, 6 Feb 2020 19:44:47 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 2E9C91C1C0;\n Thu, 6 Feb 2020 19:44:38 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 5AC8630C0FB;\n Thu, 6 Feb 2020 10:37:16 -0800 (PST)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n [10.69.74.102])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id D449814008D;\n Thu, 6 Feb 2020 10:44:35 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 5AC8630C0FB", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1581014236;\n bh=0iILt7RwW9gyq8U/a5h8M+j0s3TqqJ+MjBb+SXfxdGw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=GNA2Um/MhUrpWS4qlz244RtcZfSounSN2YT9Yh0tj2we+jxz4qIcqVUpqFQekBMmo\n n7Lfa/RoTKI7DXVrfA6DXqkn03jrRXlu5kq06qaYiZHlyPJVBrYUp89zKFjuKdJe3O\n IVYYz9mUlOx7BAgQQQpgNkd8sRx2OItEk+7CaDuY=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Rahul Gupta <rahul.gupta@broadcom.com>,\n stable@dpdk.org,\n Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Thu, 6 Feb 2020 10:44:27 -0800", "Message-Id": "<20200206184432.34360-3-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200206184432.34360-1-ajit.khaparde@broadcom.com>", "References": "<20200206163314.12755-1-kalesh-anakkur.purayil@broadcom.com>\n <20200206184432.34360-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 2/7] net/bnxt: fix default timeout for command\n\tto get FW version", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Rahul Gupta <rahul.gupta@broadcom.com>\n\nInitially when driver is loading, there is no HWRM timeout configured\nby FW, the VER_GET command needs use default timeout as 500ms and\nwhile recovering from fatal/non-fatal FW error, it should use timeout\nas 50ms.\n\nFixes: 458f0360e8dc (\"net/bnxt: get default HWRM command timeout from FW\")\nCc: stable@dpdk.org\n\nSigned-off-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 6 ++++--\n drivers/net/bnxt/bnxt_ethdev.c | 4 ++--\n drivers/net/bnxt/bnxt_hwrm.c | 11 ++++-------\n drivers/net/bnxt/bnxt_hwrm.h | 2 +-\n 4 files changed, 11 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 68786a89b..e8a30fa31 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -606,8 +606,10 @@ struct bnxt {\n \tuint16_t\t\t\tmax_resp_len;\n \tuint16_t hwrm_max_ext_req_len;\n \n-\t /* default command timeout value of 50ms */\n-#define HWRM_CMD_TIMEOUT\t\t50000\n+\t /* default command timeout value of 500ms */\n+#define DFLT_HWRM_CMD_TIMEOUT\t\t500000\n+\t /* short command timeout value of 50ms */\n+#define SHORT_HWRM_CMD_TIMEOUT\t\t50000\n \t/* default HWRM request timeout value */\n \tuint32_t\t\t\thwrm_cmd_timeout;\n \ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 537820960..7147cc8fe 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -3998,7 +3998,7 @@ static void bnxt_dev_recover(void *arg)\n \tbp->flags &= ~BNXT_FLAG_FATAL_ERROR;\n \n \tdo {\n-\t\trc = bnxt_hwrm_ver_get(bp);\n+\t\trc = bnxt_hwrm_ver_get(bp, SHORT_HWRM_CMD_TIMEOUT);\n \t\tif (rc == 0)\n \t\t\tbreak;\n \t\trte_delay_ms(BNXT_FW_READY_WAIT_INTERVAL);\n@@ -4688,7 +4688,7 @@ static int bnxt_init_fw(struct bnxt *bp)\n \n \tbp->fw_cap = 0;\n \n-\trc = bnxt_hwrm_ver_get(bp);\n+\trc = bnxt_hwrm_ver_get(bp, DFLT_HWRM_CMD_TIMEOUT);\n \tif (rc)\n \t\treturn rc;\n \ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex f325aff82..96b34317b 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -100,11 +100,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,\n \tif (bp->flags & BNXT_FLAG_FATAL_ERROR)\n \t\treturn 0;\n \n-\t/* For VER_GET command, set timeout as 50ms */\n-\tif (rte_cpu_to_le_16(req->req_type) == HWRM_VER_GET)\n-\t\ttimeout = HWRM_CMD_TIMEOUT;\n-\telse\n-\t\ttimeout = bp->hwrm_cmd_timeout;\n+\ttimeout = bp->hwrm_cmd_timeout;\n \n \tif (bp->flags & BNXT_FLAG_SHORT_CMD ||\n \t msg_len > bp->max_req_len) {\n@@ -949,7 +945,7 @@ int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp)\n \treturn rc;\n }\n \n-int bnxt_hwrm_ver_get(struct bnxt *bp)\n+int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout)\n {\n \tint rc = 0;\n \tstruct hwrm_ver_get_input req = {.req_type = 0 };\n@@ -960,6 +956,7 @@ int bnxt_hwrm_ver_get(struct bnxt *bp)\n \tuint32_t dev_caps_cfg;\n \n \tbp->max_req_len = HWRM_MAX_REQ_LEN;\n+\tbp->hwrm_cmd_timeout = timeout;\n \tHWRM_PREP(req, VER_GET, BNXT_USE_CHIMP_MB);\n \n \treq.hwrm_intf_maj = HWRM_VERSION_MAJOR;\n@@ -994,7 +991,7 @@ int bnxt_hwrm_ver_get(struct bnxt *bp)\n \t/* convert timeout to usec */\n \tbp->hwrm_cmd_timeout *= 1000;\n \tif (!bp->hwrm_cmd_timeout)\n-\t\tbp->hwrm_cmd_timeout = HWRM_CMD_TIMEOUT;\n+\t\tbp->hwrm_cmd_timeout = DFLT_HWRM_CMD_TIMEOUT;\n \n \tif (resp->hwrm_intf_maj_8b != HWRM_VERSION_MAJOR) {\n \t\tPMD_DRV_LOG(ERR, \"Unsupported firmware API version\\n\");\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h\nindex d8d1360f9..2753720ae 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.h\n+++ b/drivers/net/bnxt/bnxt_hwrm.h\n@@ -120,7 +120,7 @@ int bnxt_hwrm_stat_ctx_free(struct bnxt *bp,\n int bnxt_hwrm_ctx_qstats(struct bnxt *bp, uint32_t cid, int idx,\n \t\t\t struct rte_eth_stats *stats, uint8_t rx);\n \n-int bnxt_hwrm_ver_get(struct bnxt *bp);\n+int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout);\n \n int bnxt_hwrm_vnic_alloc(struct bnxt *bp, struct bnxt_vnic_info *vnic);\n int bnxt_hwrm_vnic_cfg(struct bnxt *bp, struct bnxt_vnic_info *vnic);\n", "prefixes": [ "v2", "2/7" ] }