Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65612/?format=api
{ "id": 65612, "url": "http://patches.dpdk.org/api/patches/65612/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200206064426.45697-6-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200206064426.45697-6-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200206064426.45697-6-dmitry.kozliuk@gmail.com", "date": "2020-02-06T06:44:24", "name": "[v2,5/7] build: MinGW-w64 support for Meson", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "751e9e24cf5456e9ac9001df678d272a8969431e", "submitter": { "id": 1581, "url": "http://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200206064426.45697-6-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 8442, "url": "http://patches.dpdk.org/api/series/8442/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8442", "date": "2020-02-06T06:44:19", "name": "MinGW-w64 support", "version": 2, "mbox": "http://patches.dpdk.org/series/8442/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65612/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/65612/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 48EA9A04FA;\n\tThu, 6 Feb 2020 07:45:40 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C69DD1C0D4;\n\tThu, 6 Feb 2020 07:44:47 +0100 (CET)", "from mail-lf1-f68.google.com (mail-lf1-f68.google.com\n [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id C5F091C067\n for <dev@dpdk.org>; Thu, 6 Feb 2020 07:44:43 +0100 (CET)", "by mail-lf1-f68.google.com with SMTP id m30so3271592lfp.8\n for <dev@dpdk.org>; Wed, 05 Feb 2020 22:44:43 -0800 (PST)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.googlemail.com with ESMTPSA id o19sm939669lji.54.2020.02.05.22.44.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 05 Feb 2020 22:44:42 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=UGPlklvbxfQM/xywUPxBECj7HLiMr26lS5tb8VRhzNc=;\n b=ORQjUnBCrG6lVCOl3MYgSCP6HT3jUflTYmfvYgH5YgncPOwHEn7mvwnvfCA3cPROs7\n ioOqFVdGY8AULDnODmxv/ihHf70oh5KwpplVXwZ/UOTNfNV7r+Jv4tA3PTCp8dvsdksK\n a2YBqLgHkkRdXPUek4uzzuHpceYB7lM+YiOP5JpmiQg30kGljSvAPx27ZwfcdeXd9QrT\n vvo8+z9U9froOtnkztGO55eTDG5KBakPCdQlYbV5G3Q8UqEg9aBYdVLTaGcGF2CGi+mk\n hfsaMLdL9mlr+VFmzplbyxMM2pXvalk8AnzMQY2CvjqSI2wv6sw+U4xzAx8YTUVenW0V\n kvWQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=UGPlklvbxfQM/xywUPxBECj7HLiMr26lS5tb8VRhzNc=;\n b=UxJm4GXTYhGMyf9CM+qf5Suku2WEtuamy/wu51X+owf/GyDCnSPcSogyOqxuAd4EQc\n i9Bn4yWlc9m0DtSUmRDZe1HvQRlXgwCs2xiFtESBTWBQEVPvl5drL4UssD9nXmdVN86S\n yS+YN8xkdjHtWTShcKkVf7YnB0AuONIy3KN+808cprYmKhJADa4L54pXxwWFWjNCLQho\n NsYXrZUTCeKTAPveKu8YVfdb9yNzp+Id6/ujk6xgxAAaw44LgO2egogUQpE+5Ww8hSTr\n nesSQ0hve/cOWfC5Bz2p7WN6/tzOz/ur3nMCFzyw48PS68lzsH3njSoXqoJBtorffmZ4\n Zrtw==", "X-Gm-Message-State": "APjAAAXWLwfht/ompzU+iW7/QKXWuljoAVDbUv4IblO70wlqu7sR5T8g\n 8Zw6JRRU08nj3nRH9K9LnyTYlI/7NJw=", "X-Google-Smtp-Source": "\n APXvYqxXORt4YUQ1pDqe7O7izuWKy64YlSPVop2EdMssbL6a6wEQr3lhYdi2aNpxacjR4JFUnkgKEg==", "X-Received": "by 2002:ac2:52a5:: with SMTP id r5mr916663lfm.19.1580971483031;\n Wed, 05 Feb 2020 22:44:43 -0800 (PST)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>", "Date": "Thu, 6 Feb 2020 09:44:24 +0300", "Message-Id": "<20200206064426.45697-6-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200206064426.45697-1-dmitry.kozliuk@gmail.com>", "References": "<20200206064426.45697-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 5/7] build: MinGW-w64 support for Meson", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "MinGW-w64 linker does not mimic MS linker options, so the build system\nmust differentiate between linkers on Windows. Use GNU linker options\nwith GCC and MS linker options with Clang.\n\nMinGW-w64 by default uses MSVCRT stdio, which does not comply to ANSI,\nmost notably its formatting and string handling functions. MinGW-w64\nsupport for the Universal CRT (UCRT) is ongoing, but the toolchain\nprovides its own standard-complying implementation of stdio. The latter\nis used in the patch to support formatting in DPDK.\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n config/meson.build | 14 ++++++++++++++\n lib/librte_eal/meson.build | 3 +++\n lib/meson.build | 8 ++++++--\n 3 files changed, 23 insertions(+), 2 deletions(-)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 28a57f56f..9b955f9ef 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -14,6 +14,10 @@ foreach env:supported_exec_envs\n \tset_variable('is_' + env, exec_env == env)\n endforeach\n \n+# MS linker requires special treatment.\n+# FIXME: use cc.get_linker_id() with Meson >= 0.54\n+is_ms_linker = is_windows and (cc.get_id() == 'clang')\n+\n # set the major version, which might be used by drivers and libraries\n # depending on the configuration options\n pver = meson.project_version().split('.')\n@@ -241,6 +245,16 @@ if is_freebsd\n \tadd_project_arguments('-D__BSD_VISIBLE', language: 'c')\n endif\n \n+if is_windows\n+\t# Minimum supported API is Windows 7.\n+\tadd_project_arguments('-D_WIN32_WINNT=0x0601', language: 'c')\n+\n+\t# Use MinGW-w64 stdio, because DPDK assumes ANSI-compliant formatting.\n+\tif cc.get_id() == 'gcc'\n+\t\tadd_project_arguments('-D__USE_MINGW_ANSI_STDIO', language: 'c')\n+\tendif\n+endif\n+\n if get_option('b_lto')\n \tif cc.has_argument('-ffat-lto-objects')\n \t\tadd_project_arguments('-ffat-lto-objects', language: 'c')\ndiff --git a/lib/librte_eal/meson.build b/lib/librte_eal/meson.build\nindex 4be5118ce..eae8c2ba8 100644\n--- a/lib/librte_eal/meson.build\n+++ b/lib/librte_eal/meson.build\n@@ -20,6 +20,9 @@ endif\n if cc.has_function('getentropy', prefix : '#include <unistd.h>')\n \tcflags += '-DRTE_LIBEAL_USE_GETENTROPY'\n endif\n+if cc.get_id() == 'gcc'\n+\tcflags += '-D__USE_MINGW_ANSI_STDIO'\n+endif\n sources = common_sources + env_sources\n objs = common_objs + env_objs\n headers = common_headers + env_headers\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 0af3efab2..9c3cc55d5 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -148,12 +148,16 @@ foreach l:libraries\n \t\t\t\tcommand: [map_to_def_cmd, '@INPUT@', '@OUTPUT@'],\n \t\t\t\tinput: version_map,\n \t\t\t\toutput: 'rte_@0@_exports.def'.format(name))\n-\t\t\tlk_deps = [version_map, def_file]\n-\t\t\tif is_windows\n+\n+\t\t\tif is_ms_linker\n \t\t\t\tlk_args = ['-Wl,/def:' + def_file.full_path(),\n \t\t\t\t\t'-Wl,/implib:lib\\\\' + implib]\n \t\t\telse\n \t\t\t\tlk_args = ['-Wl,--version-script=' + version_map]\n+\t\t\tendif\n+\n+\t\t\tlk_deps = [version_map, def_file]\n+\t\t\tif not is_windows\n \t\t\t\t# on unix systems check the output of the\n \t\t\t\t# experimental syms script, using it as a\n \t\t\t\t# dependency of the .so build\n", "prefixes": [ "v2", "5/7" ] }