Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65602/?format=api
{ "id": 65602, "url": "http://patches.dpdk.org/api/patches/65602/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200206013936.11119-5-oda@valinux.co.jp/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200206013936.11119-5-oda@valinux.co.jp>", "list_archive_url": "https://inbox.dpdk.org/dev/20200206013936.11119-5-oda@valinux.co.jp", "date": "2020-02-06T01:39:36", "name": "[v3,4/4] net/vhost: remove an unused member", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8e98754a189a6ff4115e98106321446a2dcac708", "submitter": { "id": 1558, "url": "http://patches.dpdk.org/api/people/1558/?format=api", "name": "Itsuro Oda", "email": "oda@valinux.co.jp" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200206013936.11119-5-oda@valinux.co.jp/mbox/", "series": [ { "id": 8439, "url": "http://patches.dpdk.org/api/series/8439/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8439", "date": "2020-02-06T01:39:32", "name": "make vhost PMD available for secondary processes", "version": 3, "mbox": "http://patches.dpdk.org/series/8439/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65602/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65602/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 21F95A04FA;\n\tThu, 6 Feb 2020 02:39:58 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9A23B1C243;\n\tThu, 6 Feb 2020 02:39:41 +0100 (CET)", "from valinux.co.jp (vagw.valinux.co.jp [210.128.90.14])\n by dpdk.org (Postfix) with ESMTP id ED92B1C1FF;\n Thu, 6 Feb 2020 02:39:37 +0100 (CET)", "by valinux.co.jp (Postfix, from userid 1000)\n id DEAA62409CF; Thu, 6 Feb 2020 10:39:36 +0900 (JST)" ], "From": "Itsuro Oda <oda@valinux.co.jp>", "To": "dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,\n zhihong.wang@intel.com, anatoly.burakov@intel.com", "Cc": "stable@dpdk.org", "Date": "Thu, 6 Feb 2020 10:39:36 +0900", "Message-Id": "<20200206013936.11119-5-oda@valinux.co.jp>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200206013936.11119-1-oda@valinux.co.jp>", "References": "<20200108062510.3478-1-oda@valinux.co.jp>\n <20200206013936.11119-1-oda@valinux.co.jp>", "Subject": "[dpdk-dev] [PATCH v3 4/4] net/vhost: remove an unused member", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch removes an unused member from pmd_internal.\n\nSigned-off-by: Itsuro Oda <oda@valinux.co.jp>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/vhost/rte_eth_vhost.c | 9 +--------\n 1 file changed, 1 insertion(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex 307de2c68..90263ae77 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -95,7 +95,6 @@ struct vhost_queue {\n \n struct pmd_internal {\n \trte_atomic32_t dev_attached;\n-\tchar *dev_name;\n \tchar *iface_name;\n \tuint64_t flags;\n \tuint64_t disable_flags;\n@@ -1073,7 +1072,6 @@ eth_dev_close(struct rte_eth_dev *dev)\n \t\tfor (i = 0; i < dev->data->nb_tx_queues; i++)\n \t\t\trte_free(dev->data->tx_queues[i]);\n \n-\tfree(internal->dev_name);\n \trte_free(internal->iface_name);\n \trte_free(internal);\n \n@@ -1307,9 +1305,6 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,\n \t * - and point eth_dev structure to new eth_dev_data structure\n \t */\n \tinternal = eth_dev->data->dev_private;\n-\tinternal->dev_name = strdup(name);\n-\tif (internal->dev_name == NULL)\n-\t\tgoto error;\n \tinternal->iface_name = rte_malloc_socket(name, strlen(iface_name) + 1,\n \t\t\t\t\t\t 0, numa_node);\n \tif (internal->iface_name == NULL)\n@@ -1335,10 +1330,8 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,\n \treturn 0;\n \n error:\n-\tif (internal) {\n+\tif (internal)\n \t\trte_free(internal->iface_name);\n-\t\tfree(internal->dev_name);\n-\t}\n \trte_eth_dev_release_port(eth_dev);\n \n \treturn -1;\n", "prefixes": [ "v3", "4/4" ] }