Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65586/?format=api
{ "id": 65586, "url": "http://patches.dpdk.org/api/patches/65586/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1580908578-3384-6-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1580908578-3384-6-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1580908578-3384-6-git-send-email-anoobj@marvell.com", "date": "2020-02-05T13:16:17", "name": "[5/6] common/cpt: fix fill_sg_comp api for zero datalen", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "14f21092f382a77a39112cfb2865212dfd75c535", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1580908578-3384-6-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 8429, "url": "http://patches.dpdk.org/api/series/8429/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8429", "date": "2020-02-05T13:16:12", "name": "code improvements for OCTEON TX crypto PMDs", "version": 1, "mbox": "http://patches.dpdk.org/series/8429/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65586/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65586/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E3AE2A04FA;\n\tWed, 5 Feb 2020 14:17:27 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2E0A01C1E8;\n\tWed, 5 Feb 2020 14:16:58 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 8D7571C1D8\n for <dev@dpdk.org>; Wed, 5 Feb 2020 14:16:56 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 015DDuuh025994; Wed, 5 Feb 2020 05:16:56 -0800", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 2xyhn12wwh-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 05 Feb 2020 05:16:55 -0800", "from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 Feb\n 2020 05:16:53 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 5 Feb 2020 05:16:53 -0800", "from ajoseph83.caveonetworks.com (unknown [10.29.45.60])\n by maili.marvell.com (Postfix) with ESMTP id 6A7463F72F1;\n Wed, 5 Feb 2020 05:16:52 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=exZ7qWfV5GZ8BPS/K4WXD8jjnDuARG9mS9olguLkZ98=;\n b=OHyYYjoSrI/QamgZ1gi/Nfpaz0y0RM5RNkfU0tY0DIU/IAvVsbsyeK9EKBn8TAa3Wvg1\n 34N0LkS39qL0cptZD6R2v+wWX8cX+IHyNExo7DmXr/5kGFlHneqDOUpt/QKUCwb9Tm0M\n xctfXr4pjuiqgE+L2ekkDNuWuBu/3E1OzmV60J3i7Vz82U1YNWFUnu/Sj/pORHxmhUyH\n 98c6OkHEDsNvv4NAzPXKnb1rhk9z6M657okWemC9kemAIMkQRVCT0WSZsGWLKLQrHtqk\n +gXWUrIWP9Q2bJIw+cEwvg92n9vIGNYR0IwVckLnBI2ycK5duIGssIy968ECjxADmCOi Ng==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>", "CC": "Archana Muniganti <marchana@marvell.com>, <dev@dpdk.org>, Anoob Joseph\n <anoobj@marvell.com>", "Date": "Wed, 5 Feb 2020 18:46:17 +0530", "Message-ID": "<1580908578-3384-6-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1580908578-3384-1-git-send-email-anoobj@marvell.com>", "References": "<1580908578-3384-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572\n definitions=2020-02-05_03:2020-02-04,\n 2020-02-05 signatures=0", "Subject": "[dpdk-dev] [PATCH 5/6] common/cpt: fix fill_sg_comp api for zero\n\tdatalen", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Archana Muniganti <marchana@marvell.com>\n\nfill_sg_comp_from_iov() prepares gather components for i/p IOV\nbuffers and extra buf. This API is failing to create a gather component\nfor extra_buf when IOV buf len is zero. Though there is enough space\nto accommodate extra_buf, because of pre-decrementing of extra_buf\nlength from aggregate size, this issue is seen.\n\nFixes: b74652f3a91f (\"common/cpt: add microcode interface for encryption\")\n\nSigned-off-by: Archana Muniganti <marchana@marvell.com>\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n drivers/common/cpt/cpt_ucode.h | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/common/cpt/cpt_ucode.h b/drivers/common/cpt/cpt_ucode.h\nindex 081249c..c310ea7 100644\n--- a/drivers/common/cpt/cpt_ucode.h\n+++ b/drivers/common/cpt/cpt_ucode.h\n@@ -373,7 +373,7 @@ fill_sg_comp_from_iov(sg_comp_t *list,\n {\n \tint32_t j;\n \tuint32_t extra_len = extra_buf ? extra_buf->size : 0;\n-\tuint32_t size = *psize - extra_len;\n+\tuint32_t size = *psize;\n \tbuf_ptr_t *bufs;\n \n \tbufs = from->bufs;\n@@ -382,9 +382,6 @@ fill_sg_comp_from_iov(sg_comp_t *list,\n \t\tuint32_t e_len;\n \t\tsg_comp_t *to = &list[i >> 2];\n \n-\t\tif (!bufs[j].size)\n-\t\t\tcontinue;\n-\n \t\tif (unlikely(from_offset)) {\n \t\t\tif (from_offset >= bufs[j].size) {\n \t\t\t\tfrom_offset -= bufs[j].size;\n@@ -416,18 +413,19 @@ fill_sg_comp_from_iov(sg_comp_t *list,\n \t\t\t\tto->u.s.len[i % 4] = rte_cpu_to_be_16(e_len);\n \t\t\t}\n \n+\t\t\textra_len = RTE_MIN(extra_len, size);\n \t\t\t/* Insert extra data ptr */\n \t\t\tif (extra_len) {\n \t\t\t\ti++;\n \t\t\t\tto = &list[i >> 2];\n \t\t\t\tto->u.s.len[i % 4] =\n-\t\t\t\t\trte_cpu_to_be_16(extra_buf->size);\n+\t\t\t\t\trte_cpu_to_be_16(extra_len);\n \t\t\t\tto->ptr[i % 4] =\n \t\t\t\t\trte_cpu_to_be_64(extra_buf->dma_addr);\n-\n-\t\t\t\t/* size already decremented by extra len */\n+\t\t\t\tsize -= extra_len;\n \t\t\t}\n \n+\t\t\tnext_len = RTE_MIN(next_len, size);\n \t\t\t/* insert the rest of the data */\n \t\t\tif (next_len) {\n \t\t\t\ti++;\n", "prefixes": [ "5/6" ] }