Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65487/?format=api
{ "id": 65487, "url": "http://patches.dpdk.org/api/patches/65487/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1580736735-19472-3-git-send-email-bingz@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1580736735-19472-3-git-send-email-bingz@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1580736735-19472-3-git-send-email-bingz@mellanox.com", "date": "2020-02-03T13:32:11", "name": "[2/6] net/mlx5: change operations of non-cached flows", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "06da29660fd84cd43b99049373120e414d57c946", "submitter": { "id": 1357, "url": "http://patches.dpdk.org/api/people/1357/?format=api", "name": "Bing Zhao", "email": "bingz@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1580736735-19472-3-git-send-email-bingz@mellanox.com/mbox/", "series": [ { "id": 8396, "url": "http://patches.dpdk.org/api/series/8396/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8396", "date": "2020-02-03T13:32:09", "name": "net/mlx5: move to non-cached mode for flow rules", "version": 1, "mbox": "http://patches.dpdk.org/series/8396/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65487/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65487/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2A82AA052E;\n\tMon, 3 Feb 2020 14:32:48 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 739F01BFF1;\n\tMon, 3 Feb 2020 14:32:37 +0100 (CET)", "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n by dpdk.org (Postfix) with ESMTP id ECB661BFD6\n for <dev@dpdk.org>; Mon, 3 Feb 2020 14:32:35 +0100 (CET)" ], "From": "Bing Zhao <bingz@mellanox.com>", "To": "orika@mellanox.com, viacheslavo@mellanox.com, rasland@mellanox.com,\n matan@mellanox.com", "Cc": "dev@dpdk.org", "Date": "Mon, 3 Feb 2020 15:32:11 +0200", "Message-Id": "<1580736735-19472-3-git-send-email-bingz@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1580736735-19472-1-git-send-email-bingz@mellanox.com>", "References": "<1580736735-19472-1-git-send-email-bingz@mellanox.com>", "Subject": "[dpdk-dev] [PATCH 2/6] net/mlx5: change operations of non-cached\n\tflows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When stopping a mlx5 device, the flows with non-cached mode will be\nflushed. So no operation will be done for these flows in the device\nclosing stage.\nIf the device restarts after stopped, no flow with non-cached mode\nwill be reinserted.\nOperations of flows with cached mode remain the same. And when the\nflushing is called from user, all the flows will be flushed.\n\nSigned-off-by: Bing Zhao <bingz@mellanox.com>\n---\n drivers/net/mlx5/mlx5.c | 1 +\n drivers/net/mlx5/mlx5.h | 2 ++\n drivers/net/mlx5/mlx5_flow.c | 36 +++++++++++++++++++++++++++++++++---\n drivers/net/mlx5/mlx5_trigger.c | 11 ++++++++---\n 4 files changed, 44 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex dc4fbbc..5114b23 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -1236,6 +1236,7 @@ struct mlx5_flow_id_pool *\n \tmlx5_dev_interrupt_handler_uninstall(dev);\n \tmlx5_dev_interrupt_handler_devx_uninstall(dev);\n \tmlx5_traffic_disable(dev);\n+\t/* Only cached flows will be flushed in this stage, if any. */\n \tmlx5_flow_flush(dev, NULL);\n \tmlx5_flow_meter_flush(dev, NULL);\n \t/* Prevent crashes when queues are still in use. */\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 65bdb3b..d749b29 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -715,6 +715,8 @@ int mlx5_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,\n \t\t struct rte_flow_error *error);\n void mlx5_flow_list_flush(struct rte_eth_dev *dev, struct mlx5_flows *list);\n int mlx5_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error);\n+int mlx5_flow_flush_noncached(struct rte_eth_dev *dev,\n+\t\t\t struct rte_flow_error *error);\n int mlx5_flow_query(struct rte_eth_dev *dev, struct rte_flow *flow,\n \t\t const struct rte_flow_action *action, void *data,\n \t\t struct rte_flow_error *error);\ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex d7fb094..0560874 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -4453,11 +4453,14 @@ struct rte_flow *\n \tstruct rte_flow_error error;\n \tint ret = 0;\n \n-\t/* Make sure default copy action (reg_c[0] -> reg_b) is created. */\n+\t/*\n+\t * Make sure default copy action (reg_c[0] -> reg_b) is created.\n+\t * This should always be executed no matter the driver type.\n+\t */\n \tret = flow_mreg_add_default_copy_action(dev, &error);\n \tif (ret < 0)\n \t\treturn -rte_errno;\n-\t/* Apply Flows created by application. */\n+\t/* Apply Flows created by application, only for cached flows. */\n \tTAILQ_FOREACH(flow, list, next) {\n \t\tret = flow_mreg_start_copy_action(dev, flow);\n \t\tif (ret < 0)\n@@ -4674,7 +4677,15 @@ struct rte_flow *\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \n-\tflow_list_destroy(dev, &priv->noncached_flows, flow);\n+\t/*\n+\t * Checking the flow type and then destroying the flows in both lists.\n+\t * Flow with DV type is non-cached (most cases) and flow with legacy\n+\t * verbs mode is still cached right now.\n+\t */\n+\tif (flow->drv_type == MLX5_FLOW_TYPE_DV)\n+\t\tflow_list_destroy(dev, &priv->noncached_flows, flow);\n+\telse\n+\t\tflow_list_destroy(dev, &priv->cached_flows, flow);\n \treturn 0;\n }\n \n@@ -4690,6 +4701,24 @@ struct rte_flow *\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \n+\t/* In most cases, only one tailq list will contain the flows. */\n+\tmlx5_flow_list_flush(dev, &priv->noncached_flows);\n+\tmlx5_flow_list_flush(dev, &priv->cached_flows);\n+\treturn 0;\n+}\n+\n+/**\n+ * Destroy all non-cached flows.\n+ *\n+ * @see rte_flow_flush()\n+ * @see rte_flow_ops\n+ */\n+int\n+mlx5_flow_flush_noncached(struct rte_eth_dev *dev,\n+\t\t\t struct rte_flow_error *error __rte_unused)\n+{\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\n \tmlx5_flow_list_flush(dev, &priv->noncached_flows);\n \treturn 0;\n }\n@@ -5133,6 +5162,7 @@ struct rte_flow *\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \n \tmlx5_flow_list_flush(dev, &priv->noncached_flows);\n+\tmlx5_flow_list_flush(dev, &priv->cached_flows);\n }\n \n /**\ndiff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c\nindex 0053847..26f4863 100644\n--- a/drivers/net/mlx5/mlx5_trigger.c\n+++ b/drivers/net/mlx5/mlx5_trigger.c\n@@ -320,7 +320,7 @@\n \t\t\tdev->data->port_id);\n \t\tgoto error;\n \t}\n-\tret = mlx5_flow_start(dev, &priv->noncached_flows);\n+\tret = mlx5_flow_start(dev, &priv->cached_flows);\n \tif (ret) {\n \t\tDRV_LOG(DEBUG, \"port %u failed to set flows\",\n \t\t\tdev->data->port_id);\n@@ -337,7 +337,7 @@\n \tret = rte_errno; /* Save rte_errno before cleanup. */\n \t/* Rollback. */\n \tdev->data->dev_started = 0;\n-\tmlx5_flow_stop(dev, &priv->noncached_flows);\n+\tmlx5_flow_stop(dev, &priv->cached_flows);\n \tmlx5_traffic_disable(dev);\n \tmlx5_txq_stop(dev);\n \tmlx5_rxq_stop(dev);\n@@ -367,7 +367,12 @@\n \tmlx5_mp_req_stop_rxtx(dev);\n \tusleep(1000 * priv->rxqs_n);\n \tDRV_LOG(DEBUG, \"port %u stopping device\", dev->data->port_id);\n-\tmlx5_flow_stop(dev, &priv->noncached_flows);\n+\tmlx5_flow_stop(dev, &priv->cached_flows);\n+\t/*\n+\t * Flows flushing is still after deleting default copy action & clearing\n+\t * flags of all RX queues.\n+\t */\n+\tmlx5_flow_flush_noncached(dev, NULL);\n \tmlx5_traffic_disable(dev);\n \tmlx5_rx_intr_vec_disable(dev);\n \tmlx5_dev_interrupt_handler_uninstall(dev);\n", "prefixes": [ "2/6" ] }