Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65368/?format=api
{ "id": 65368, "url": "http://patches.dpdk.org/api/patches/65368/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200130160009.6549-3-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200130160009.6549-3-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200130160009.6549-3-david.marchand@redhat.com", "date": "2020-01-30T16:00:07", "name": "[v3,2/4] build: split build helper", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2b5222d4d4dfad433c71d6a9248c71b97927c7ea", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200130160009.6549-3-david.marchand@redhat.com/mbox/", "series": [ { "id": 8357, "url": "http://patches.dpdk.org/api/series/8357/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8357", "date": "2020-01-30T16:00:06", "name": "add ABI checks", "version": 3, "mbox": "http://patches.dpdk.org/series/8357/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65368/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65368/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EF6F7A0524;\n\tThu, 30 Jan 2020 17:00:52 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 35E271C068;\n\tThu, 30 Jan 2020 17:00:40 +0100 (CET)", "from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com\n [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id EFA4D1C044\n for <dev@dpdk.org>; Thu, 30 Jan 2020 17:00:37 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-174-Y6MXWNAwPQavCRyRbW7YiA-1; Thu, 30 Jan 2020 11:00:33 -0500", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com\n [10.5.11.22])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 469B613EB;\n Thu, 30 Jan 2020 16:00:32 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-128.brq.redhat.com\n [10.40.204.128])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 3C1AA1001B30;\n Thu, 30 Jan 2020 16:00:27 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1580400037;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=V9P1sb0i9UOEGssiU6PRP8bXQF4VckTs3RYvJAe0hF8=;\n b=RnWsZZGwgfnma7S41xaV/ZbHQygzInqXQxdPR/VB+Mx3+MXYR/TpJS4JPGrAbidDIkepo8\n lbkAcV1j5RJIzl5yVf8XdRtIVrdNqvoUm9gai0lnCLAFhPohy31utsNzDwSorWrwhri6op\n x21vlVRM+Lq7dUldzdhXcXcjA6iLRHo=", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bruce.richardson@intel.com, kevin.laatz@intel.com,\n aconole@redhat.com, nhorman@tuxdriver.com, akhil.goyal@nxp.com,\n anoobj@marvell.com, bluca@debian.org, fiona.trahe@intel.com,\n ferruh.yigit@intel.com", "Date": "Thu, 30 Jan 2020 17:00:07 +0100", "Message-Id": "<20200130160009.6549-3-david.marchand@redhat.com>", "In-Reply-To": "<20200130160009.6549-1-david.marchand@redhat.com>", "References": "<20191220152058.10739-1-david.marchand@redhat.com>\n <20200130160009.6549-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-MC-Unique": "Y6MXWNAwPQavCRyRbW7YiA-1", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH v3 2/4] build: split build helper", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "No functional change intended, prepare for reusing this code.\nThe config and compilation parts are separated in helpers.\nUnsetting CC is moved to the caller of the helper.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Luca Boccassi <bluca@debian.org>\n---\nChangelog since v2:\n- changed indent in config(),\n- removed useless shift in compile(),\n\n---\n devtools/test-meson-builds.sh | 48 ++++++++++++++++++++++++-----------\n 1 file changed, 33 insertions(+), 15 deletions(-)", "diff": "diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh\nindex 688567714..fb6c404e5 100755\n--- a/devtools/test-meson-builds.sh\n+++ b/devtools/test-meson-builds.sh\n@@ -57,25 +57,27 @@ load_env () # <target compiler>\n \t. $srcdir/devtools/load-devel-config\n }\n \n-build () # <directory> <target compiler> <meson options>\n+config () # <dir> <builddir> <meson options>\n {\n-\tbuilddir=$builds_dir/$1\n+\tdir=$1\n \tshift\n-\ttargetcc=$1\n+\tbuilddir=$1\n \tshift\n-\t# skip build if compiler not available\n-\tcommand -v ${CC##* } >/dev/null 2>&1 || return 0\n-\tload_env $targetcc || return 0\n-\tif [ ! -f \"$builddir/build.ninja\" ] ; then\n-\t\toptions=\"--werror -Dexamples=all\"\n-\t\tfor option in $DPDK_MESON_OPTIONS ; do\n-\t\t\toptions=\"$options -D$option\"\n-\t\tdone\n-\t\toptions=\"$options $*\"\n-\t\techo \"$MESON $options $srcdir $builddir\"\n-\t\t$MESON $options $srcdir $builddir\n-\t\tunset CC\n+\tif [ -f \"$builddir/build.ninja\" ] ; then\n+\t\treturn\n \tfi\n+\toptions=\"--werror -Dexamples=all\"\n+\tfor option in $DPDK_MESON_OPTIONS ; do\n+\t\toptions=\"$options -D$option\"\n+\tdone\n+\toptions=\"$options $*\"\n+\techo \"$MESON $options $dir $builddir\"\n+\t$MESON $options $dir $builddir\n+}\n+\n+compile () # <builddir>\n+{\n+\tbuilddir=$1\n \tif [ -n \"$TEST_MESON_BUILD_VERY_VERBOSE\" ] ; then\n \t\t# for full output from ninja use \"-v\"\n \t\techo \"$ninja_cmd -v -C $builddir\"\n@@ -90,6 +92,19 @@ build () # <directory> <target compiler> <meson options>\n \tfi\n }\n \n+build () # <directory> <target compiler> <meson options>\n+{\n+\ttargetdir=$1\n+\tshift\n+\ttargetcc=$1\n+\tshift\n+\t# skip build if compiler not available\n+\tcommand -v ${CC##* } >/dev/null 2>&1 || return 0\n+\tload_env $targetcc || return 0\n+\tconfig $srcdir $builds_dir/$targetdir $*\n+\tcompile $builds_dir/$targetdir\n+}\n+\n if [ \"$1\" = \"-vv\" ] ; then\n \tTEST_MESON_BUILD_VERY_VERBOSE=1\n elif [ \"$1\" = \"-v\" ] ; then\n@@ -107,6 +122,7 @@ for c in gcc clang ; do\n \tfor s in static shared ; do\n \t\texport CC=\"$CCACHE $c\"\n \t\tbuild build-$c-$s $c --default-library=$s\n+\t\tunset CC\n \tdone\n done\n \n@@ -125,11 +141,13 @@ c=aarch64-linux-gnu-gcc\n export CC=\"clang\"\n build build-arm64-host-clang $c $use_shared \\\n \t--cross-file $srcdir/config/arm/arm64_armv8_linux_gcc\n+unset CC\n # all gcc/arm configurations\n for f in $srcdir/config/arm/arm64_[bdo]*gcc ; do\n \texport CC=\"$CCACHE gcc\"\n \tbuild build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) $c \\\n \t\t$use_shared --cross-file $f\n+\tunset CC\n done\n \n # Test installation of the x86-default target, to be used for checking\n", "prefixes": [ "v3", "2/4" ] }