Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65301/?format=api
{ "id": 65301, "url": "http://patches.dpdk.org/api/patches/65301/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1580292549-27439-13-git-send-email-matan@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1580292549-27439-13-git-send-email-matan@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1580292549-27439-13-git-send-email-matan@mellanox.com", "date": "2020-01-29T10:09:08", "name": "[v2,12/13] vdpa/mlx5: support close and config operations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a76da9f22255e944de45bf8b71459a933a6e80ed", "submitter": { "id": 796, "url": "http://patches.dpdk.org/api/people/796/?format=api", "name": "Matan Azrad", "email": "matan@mellanox.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1580292549-27439-13-git-send-email-matan@mellanox.com/mbox/", "series": [ { "id": 8335, "url": "http://patches.dpdk.org/api/series/8335/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8335", "date": "2020-01-29T10:08:56", "name": "Introduce mlx5 vDPA driver", "version": 2, "mbox": "http://patches.dpdk.org/series/8335/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65301/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65301/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3A3A2A0531;\n\tWed, 29 Jan 2020 11:11:59 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 075FD1C02D;\n\tWed, 29 Jan 2020 11:10:34 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 978F81BFCD\n for <dev@dpdk.org>; Wed, 29 Jan 2020 11:10:30 +0100 (CET)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n asafp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 29 Jan 2020 12:10:26 +0200", "from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx\n [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 00TA9BHS032108;\n Wed, 29 Jan 2020 12:10:25 +0200" ], "From": "Matan Azrad <matan@mellanox.com>", "To": "dev@dpdk.org, Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Wed, 29 Jan 2020 10:09:08 +0000", "Message-Id": "<1580292549-27439-13-git-send-email-matan@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1580292549-27439-1-git-send-email-matan@mellanox.com>", "References": "<1579539790-3882-1-git-send-email-matan@mellanox.com>\n <1580292549-27439-1-git-send-email-matan@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v2 12/13] vdpa/mlx5: support close and config\n\toperations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support dev_conf and dev_conf operations.\nThese operations allow vdpa traffic.\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa.c | 58 ++++++++++++++++++++++++++++++++++++++++---\n drivers/vdpa/mlx5/mlx5_vdpa.h | 1 +\n 2 files changed, 55 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex 4ce0ba0..c8ef3b4 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -167,12 +167,59 @@\n \treturn 0;\n }\n \n+static int\n+mlx5_vdpa_dev_close(int vid)\n+{\n+\tint did = rte_vhost_get_vdpa_device_id(vid);\n+\tstruct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);\n+\tint ret = 0;\n+\n+\tif (priv == NULL) {\n+\t\tDRV_LOG(ERR, \"Invalid device id: %d.\", did);\n+\t\treturn -1;\n+\t}\n+\tif (priv->configured)\n+\t\tret |= mlx5_vdpa_lm_log(priv);\n+\tmlx5_vdpa_cqe_event_unset(priv);\n+\tret |= mlx5_vdpa_steer_unset(priv);\n+\tmlx5_vdpa_virtqs_release(priv);\n+\tmlx5_vdpa_event_qp_global_release(priv);\n+\tmlx5_vdpa_mem_dereg(priv);\n+\tpriv->configured = 0;\n+\tpriv->vid = 0;\n+\treturn ret;\n+}\n+\n+static int\n+mlx5_vdpa_dev_config(int vid)\n+{\n+\tint did = rte_vhost_get_vdpa_device_id(vid);\n+\tstruct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);\n+\n+\tif (priv == NULL) {\n+\t\tDRV_LOG(ERR, \"Invalid device id: %d.\", did);\n+\t\treturn -EINVAL;\n+\t}\n+\tif (priv->configured && mlx5_vdpa_dev_close(vid)) {\n+\t\tDRV_LOG(ERR, \"Failed to reconfigure vid %d.\", vid);\n+\t\treturn -1;\n+\t}\n+\tpriv->vid = vid;\n+\tif (mlx5_vdpa_mem_register(priv) || mlx5_vdpa_virtqs_prepare(priv) ||\n+\t mlx5_vdpa_steer_setup(priv) || mlx5_vdpa_cqe_event_setup(priv)) {\n+\t\tmlx5_vdpa_dev_close(vid);\n+\t\treturn -1;\n+\t}\n+\tpriv->configured = 1;\n+\treturn 0;\n+}\n+\n static struct rte_vdpa_dev_ops mlx5_vdpa_ops = {\n \t.get_queue_num = mlx5_vdpa_get_queue_num,\n \t.get_features = mlx5_vdpa_get_vdpa_features,\n \t.get_protocol_features = mlx5_vdpa_get_protocol_features,\n-\t.dev_conf = NULL,\n-\t.dev_close = NULL,\n+\t.dev_conf = mlx5_vdpa_dev_config,\n+\t.dev_close = mlx5_vdpa_dev_close,\n \t.set_vring_state = mlx5_vdpa_set_vring_state,\n \t.set_features = mlx5_vdpa_features_set,\n \t.migration_done = NULL,\n@@ -320,12 +367,15 @@\n \t\t\tbreak;\n \t\t}\n \t}\n-\tif (found) {\n+\tif (found)\n \t\tTAILQ_REMOVE(&priv_list, priv, next);\n+\tpthread_mutex_unlock(&priv_list_lock);\n+\tif (found) {\n+\t\tif (priv->configured)\n+\t\t\tmlx5_vdpa_dev_close(priv->vid);\n \t\tmlx5_glue->close_device(priv->ctx);\n \t\trte_free(priv);\n \t}\n-\tpthread_mutex_unlock(&priv_list_lock);\n \treturn 0;\n }\n \ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa.h b/drivers/vdpa/mlx5/mlx5_vdpa.h\nindex 70264e4..75e96d6 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.h\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.h\n@@ -92,6 +92,7 @@ struct mlx5_vdpa_steer {\n \n struct mlx5_vdpa_priv {\n \tTAILQ_ENTRY(mlx5_vdpa_priv) next;\n+\tuint8_t configured;\n \tint id; /* vDPA device id. */\n \tint vid; /* vhost device id. */\n \tstruct ibv_context *ctx; /* Device context. */\n", "prefixes": [ "v2", "12/13" ] }