Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65290/?format=api
{ "id": 65290, "url": "http://patches.dpdk.org/api/patches/65290/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1580292549-27439-3-git-send-email-matan@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1580292549-27439-3-git-send-email-matan@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1580292549-27439-3-git-send-email-matan@mellanox.com", "date": "2020-01-29T10:08:58", "name": "[v2,02/13] vdpa/mlx5: support queues number operation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f10fa89498b7fa2baa1dbd6747d93f47ff741f6d", "submitter": { "id": 796, "url": "http://patches.dpdk.org/api/people/796/?format=api", "name": "Matan Azrad", "email": "matan@mellanox.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1580292549-27439-3-git-send-email-matan@mellanox.com/mbox/", "series": [ { "id": 8335, "url": "http://patches.dpdk.org/api/series/8335/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8335", "date": "2020-01-29T10:08:56", "name": "Introduce mlx5 vDPA driver", "version": 2, "mbox": "http://patches.dpdk.org/series/8335/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65290/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65290/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0856DA0531;\n\tWed, 29 Jan 2020 11:09:40 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5A0031BFC6;\n\tWed, 29 Jan 2020 11:09:31 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id F3A351BFAF\n for <dev@dpdk.org>; Wed, 29 Jan 2020 11:09:29 +0100 (CET)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n asafp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 29 Jan 2020 12:09:26 +0200", "from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx\n [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 00TA9BHI032108;\n Wed, 29 Jan 2020 12:09:26 +0200" ], "From": "Matan Azrad <matan@mellanox.com>", "To": "dev@dpdk.org, Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Wed, 29 Jan 2020 10:08:58 +0000", "Message-Id": "<1580292549-27439-3-git-send-email-matan@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1580292549-27439-1-git-send-email-matan@mellanox.com>", "References": "<1579539790-3882-1-git-send-email-matan@mellanox.com>\n <1580292549-27439-1-git-send-email-matan@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v2 02/13] vdpa/mlx5: support queues number\n\toperation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support get_queue_num operation to get the maximum number of queues\nsupported by the device.\n\nThis number comes from the DevX capabilities.\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa.c | 54 ++++++++++++++++++++++++++++++++++++++++++-\n 1 file changed, 53 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex 6286d7a..15e53f2 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -9,6 +9,7 @@\n \n #include <mlx5_glue.h>\n #include <mlx5_common.h>\n+#include <mlx5_devx_cmds.h>\n \n #include \"mlx5_vdpa_utils.h\"\n \n@@ -18,6 +19,7 @@ struct mlx5_vdpa_priv {\n \tint id; /* vDPA device id. */\n \tstruct ibv_context *ctx; /* Device context. */\n \tstruct rte_vdpa_dev_addr dev_addr;\n+\tstruct mlx5_hca_vdpa_attr caps;\n };\n \n TAILQ_HEAD(mlx5_vdpa_privs, mlx5_vdpa_priv) priv_list =\n@@ -25,8 +27,43 @@ struct mlx5_vdpa_priv {\n static pthread_mutex_t priv_list_lock = PTHREAD_MUTEX_INITIALIZER;\n int mlx5_vdpa_logtype;\n \n+static struct mlx5_vdpa_priv *\n+mlx5_vdpa_find_priv_resource_by_did(int did)\n+{\n+\tstruct mlx5_vdpa_priv *priv;\n+\tint found = 0;\n+\n+\tpthread_mutex_lock(&priv_list_lock);\n+\tTAILQ_FOREACH(priv, &priv_list, next) {\n+\t\tif (did == priv->id) {\n+\t\t\tfound = 1;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\tpthread_mutex_unlock(&priv_list_lock);\n+\tif (!found) {\n+\t\tDRV_LOG(ERR, \"Invalid device id: %d.\", did);\n+\t\trte_errno = EINVAL;\n+\t\treturn NULL;\n+\t}\n+\treturn priv;\n+}\n+\n+static int\n+mlx5_vdpa_get_queue_num(int did, uint32_t *queue_num)\n+{\n+\tstruct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did);\n+\n+\tif (priv == NULL) {\n+\t\tDRV_LOG(ERR, \"Invalid device id: %d.\", did);\n+\t\treturn -1;\n+\t}\n+\t*queue_num = priv->caps.max_num_virtio_queues;\n+\treturn 0;\n+}\n+\n static struct rte_vdpa_dev_ops mlx5_vdpa_ops = {\n-\t.get_queue_num = NULL,\n+\t.get_queue_num = mlx5_vdpa_get_queue_num,\n \t.get_features = NULL,\n \t.get_protocol_features = NULL,\n \t.dev_conf = NULL,\n@@ -60,6 +97,7 @@ struct mlx5_vdpa_priv {\n \tstruct ibv_device *ibv_match = NULL;\n \tstruct mlx5_vdpa_priv *priv = NULL;\n \tstruct ibv_context *ctx = NULL;\n+\tstruct mlx5_hca_attr attr;\n \tint ret;\n \n \tif (mlx5_class_get(pci_dev->device.devargs) != MLX5_CLASS_VDPA) {\n@@ -113,6 +151,20 @@ struct mlx5_vdpa_priv {\n \t\trte_errno = ENOMEM;\n \t\tgoto error;\n \t}\n+\tret = mlx5_devx_cmd_query_hca_attr(ctx, &attr);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"Unable to read HCA capabilities.\");\n+\t\trte_errno = ENOTSUP;\n+\t\tgoto error;\n+\t} else {\n+\t\tif (!attr.vdpa.valid || !attr.vdpa.max_num_virtio_queues) {\n+\t\t\tDRV_LOG(ERR, \"Not enough capabilities to support vdpa,\"\n+\t\t\t\t\" maybe old FW/OFED version?\");\n+\t\t\trte_errno = ENOTSUP;\n+\t\t\tgoto error;\n+\t\t}\n+\t\tpriv->caps = attr.vdpa;\n+\t}\n \tpriv->ctx = ctx;\n \tpriv->dev_addr.pci_addr = pci_dev->addr;\n \tpriv->dev_addr.type = PCI_ADDR;\n", "prefixes": [ "v2", "02/13" ] }